D24957: Add new baloo icons

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add new baloo 48px icon and update the preference-desktop-baloo
  icon to the same style.
  Discussed in T7878 

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

AFFECTED FILES
  icons-dark/apps/48/baloo.svg
  icons-dark/preferences/32/preferences-desktop-baloo.svg
  icons/apps/48/baloo.svg
  icons/preferences/32/preferences-desktop-baloo.svg

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a51651fd91a2: Update elisa icon (authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=68192=68470

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich updated this revision to Diff 68192.
astippich added a comment.


  - update and save as optimized svg

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=67836=68192

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  This is with the tape window moved up 1px
  F7608368: elisaBigNew2.png 
  When I look at images of real cassettes, they are not centered, hence why I 
only did this slight adjustment.
  If everyone is okay with this, I will update the revision with the optimized 
svgs.
  I don't think that filling this space is useful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  F7585764: elisaSmallNew.png 
  
  F7585766: elisaBigNew.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich updated this revision to Diff 67836.
astippich added a comment.


  - update

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=67799=67836

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  I have no intention on taking over D12992 
 as I would like rather like to code for 
Elisa. I am no designer.
  I was unsatisfied with the icon and @mgallien agreed on some slight 
adjustments to the current one.
  D12992  has been around for ages. I hope 
that this incremental update can be agreed upon faster and land for next 
frameworks release. Especially I find the "Elisa" text ugly and worth removing 
it quickly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  old icons
  22px
  F7580424: elisaSmallOld.png 
  48px
  F7580438: elisaBigOld.png 
  
  updated icons
  22px
  F7580429: elisaSmall.png 
  48px
  F7580433: elisaBig.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, GB_2, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham, mgallien.
astippich added a project: Elisa.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Since D12992  seems stuck, update the 
current icon
  a little bit and add a blueish gradient to the
  icon. Also remove the ugly text for the 48px icon,
  since it was not readable anyway at small sizes.

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien
Cc: kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, GB_2, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D19088: Use propertymap to store properties in Baloo::Result

[Alexander Stippich]

astippich added a comment.


  ping @bruns
  are you going to land this series?

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:494b068af264: Fix crash in writer collection and cleanup 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23411?vs=67376=67443

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/writercollectiontest.cpp
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich updated this revision to Diff 67376.
astippich added a comment.


  - actually add test file for writercollection

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23411?vs=67372=67376

BRANCH
  fixWriterCollection

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/writercollectiontest.cpp
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich updated this revision to Diff 67372.
astippich added a comment.


  - improve

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23411?vs=64543=67372

BRANCH
  fixWriterCollection

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich added a comment.


  ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D23411

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich added a comment.


  friendly ping. Since this solves a crash and I want to start using the 
writers in Elisa, I would like to have it rather sooner in a frameworks release 
and I'm away the next weeks

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D23411

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> apol wrote in writer.h:63
> Why's this change?

This is only for cleanup and consistency with the corresponding extractor class.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D23411

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D23411

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19088: Use propertymap to store properties in Baloo::Result

[Alexander Stippich]

astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> file.cpp:121
>  const QJsonDocument jdoc = QJsonDocument::fromJson(arr);
> -const QVariantMap varMap = jdoc.object().toVariantMap();
> -d->propertyMap = KFileMetaData::toPropertyMap(varMap);
> +d->propertyMap = Baloo::jsonToPropertyMap(jdoc.object());
>  

We are already using Baloo namespace here.

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  Since released versions of dolphin, baloo-widgets and elisa now actually cope 
with this case, I am no longer opposed merging this

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: mgallien, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22922: Implement writing of images

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4a90e8f348c2: Implement writing of images (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22922?vs=63053=64679

REVISION DETAIL
  https://phabricator.kde.org/D22922

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich updated this revision to Diff 64543.
astippich added a comment.


  - further improvements

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23411?vs=64514=64543

BRANCH
  fixWriterCollection

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, mgallien, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  WriterCollection was apparently never used.
  It crashed upon destruction due to bogus
  deletion of the writer plugins.
  This carries over some code of the 
  ExtractorCollection and cleans up a little
  bit along the way. Adds a simple test.

REPOSITORY
  R286 KFileMetaData

BRANCH
  fixWriterCollection

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22922: Implement writing of images

[Alexander Stippich]

astippich added a comment.


  friendly ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22922

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22922: Implement writing of images

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, mgallien, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Support writing the embedded cover data to the files.

REPOSITORY
  R286 KFileMetaData

BRANCH
  write_embedded_image

REVISION DETAIL
  https://phabricator.kde.org/D22922

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7b9cb48d95e4: Get mobipocket extractor up-to-date, but 
keep disabled (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17500?vs=61690=62098#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17500?vs=61690=62098

REVISION DETAIL
  https://phabricator.kde.org/D17500

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/extractorcoveragetest.cpp
  autotests/mobiextractortest.cpp
  autotests/samplefiles/test.mobi
  src/extractors/CMakeLists.txt
  src/extractors/mobiextractor.cpp

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, 
sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich updated this revision to Diff 61690.
astippich added a comment.


  - rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17500?vs=55848=61690

BRANCH
  mobi

REVISION DETAIL
  https://phabricator.kde.org/D17500

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/mobiextractortest.cpp
  autotests/samplefiles/test.mobi
  src/extractors/CMakeLists.txt
  src/extractors/mobiextractor.cpp

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, 
sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  since this code is not compiled, I will merge it next week if noone objects

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, 
sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a51e96979b4e: Fix extracting of some properties to match 
what was written (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20526?vs=60842=61242

REVISION DETAIL
  https://phabricator.kde.org/D20526

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/extractors/taglibextractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich added a comment.


  thanks

REPOSITORY
  R286 KFileMetaData

BRANCH
  arcpatch-D20526

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich added a comment.


  friendly ping, I would like to get this into 5.60

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich marked 2 inline comments as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22157: Use debugging category in taglib extractor/writer

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ce0b873f1888: Use debugging category in taglib 
extractor/writer (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60844=60850

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22157: Use debugging category in taglib extractor/writer

[Alexander Stippich]

astippich updated this revision to Diff 60844.
astippich added a comment.


  - adjust writer cmake

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60843=60844

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22157: Use debugging category in taglib extractor/writer

[Alexander Stippich]

astippich updated this revision to Diff 60843.
astippich added a comment.


  - use separate debug src

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60838=60843

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:356
> is this always just one value, or a list as well?

as far as I know, asf only allows single entry tags, so just a single value

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich updated this revision to Diff 60842.
astippich marked an inline comment as done.
astippich added a comment.


  - add trimmed(), adjust test
  - fileExtension

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20526?vs=60334=60842

BRANCH
  arcpatch-D20526

REVISION DETAIL
  https://phabricator.kde.org/D20526

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/extractors/taglibextractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22157: Use debugging category in taglib extractor/writer

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich retitled this revision from "fix extracting of some properties to 
match what was writen" to "Fix extracting of some properties to match what was 
written".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich updated this revision to Diff 60334.
astippich added a comment.


  - remove usage of contactsFromString entirely

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20526?vs=56170=60334

BRANCH
  arcpatch-D20526

REVISION DETAIL
  https://phabricator.kde.org/D20526

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/extractors/taglibextractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich commandeered this revision.
astippich edited reviewers, added: mgallien; removed: astippich.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich added a comment.


  @mgallien Are you going to update? There are bug reports which will also be 
fixed by this, so it would be nice to get this in.
  Or do you mind if I take over?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0a042beb5568: Format photo exposure bias value (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59875=60265

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added a comment.


  friendly ping, would be great to get this in before the string freeze

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich updated this revision to Diff 59875.
astippich added a comment.


  - remove unnecessary else

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59874=59875

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich updated this revision to Diff 59874.
astippich added a comment.


  - remove unneeded newline

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59873=59874

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich updated this revision to Diff 59873.
astippich added a comment.


  - cover 1/2 case

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59870=59873

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:183
> You obviously multiply here ...

dividing by one third is multiplying by three :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added a comment.


  In D21830#480181 , @bruns wrote:
  
  > Many cameras can be switched to 1/2 EV steps.
  
  
  Damn ;) do you know any other values? In case not, I would add this case in a 
loop and stupidly try everything

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  ping! this now tests the resulting document and tests how the different data 
types are added to it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added a comment.


  exposure bias seems mostly to be in steps of 1/3 according to 
https://www.geofflawrence.com/exposure_compensation.html

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Format the photo exposure bias value in EV units
  and in steps of thirds when applicable
  
  CCBUG: 343273

REPOSITORY
  R286 KFileMetaData

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fix_races

REVISION DETAIL
  https://phabricator.kde.org/D21707

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21772: Remove photo prefix from every exif property name

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:135fc25b6feb: Remove photo prefix from every exif 
property name (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21772?vs=59678=59817#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21772?vs=59678=59817

REVISION DETAIL
  https://phabricator.kde.org/D21772

AFFECTED FILES
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:131947acb0b2: Rename ImageMake and ImageModel properties 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21519?vs=59676=59816

REVISION DETAIL
  https://phabricator.kde.org/D21519

AFFECTED FILES
  src/extractors/exiv2extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21706

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21772: Remove photo prefix from every exif property name

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Remove the 'photo' prefix from every exif property,
  as this is pretty redundant
  CCBUG: 343273

REPOSITORY
  R286 KFileMetaData

BRANCH
  exif_names

REVISION DETAIL
  https://phabricator.kde.org/D21772

AFFECTED FILES
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21613: Format focal length as milli meter

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:8823b8a37d02: Format focal length as milli meter 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21613?vs=59560=59677

REVISION DETAIL
  https://phabricator.kde.org/D21613

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich updated this revision to Diff 59676.
astippich added a comment.


  - rename to Manufacturer and Model

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21519?vs=58973=59676

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

AFFECTED FILES
  src/extractors/exiv2extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20967: [UserMetaData] Add method to query which attributes are set

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  for the linux part

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:82
> +if (fileInfo.isDir()) {
> +// The folder ctime changes when the file is created, when the 
> folder is
> +// renamed, or when the xattrs (tags, comments, ...) change

"when the folder is created,..." or "when a file is created,..."?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21706

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21613: Format focal length as milli meter

[Alexander Stippich]

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21004: [UserMetaData] Shortcut attribute queries for the common case

[Alexander Stippich]

astippich added a comment.


  This needs a frameworks version bump

REPOSITORY
  R824 Baloo Widgets

BRANCH
  bulk_query

REVISION DETAIL
  https://phabricator.kde.org/D21004

To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame
Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich added a comment.


  In D21519#475829 , @bruns wrote:
  
  > In D21519#475821 , @ngraham 
wrote:
  >
  > > "Camera Manufacturer"?
  >
  >
  > Well, no ... also "Scanner, Phone, video digitizer, ..."
  >
  > Digikam just uses "Manufacturer" and "Model", as does Canons DPP
  
  
  That is a strong reason to use just Manufacture and Model then.
  
  > The more I think about it, the more I dislike the enum renaming - reusing a 
strange name from some widely used standard is one thing, but inventing a new 
one I don't consider a good idea.
  
  I'd still like to rename these to "Manufacturer" and "Model". IMHO ImageMake 
and ImageModel is confusing and meaningless.

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21613: Format focal length as milli meter

[Alexander Stippich]

astippich updated this revision to Diff 59560.
astippich added a comment.


  - test decimal value

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21613?vs=59223=59560

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2dc250bc9239: Format photo exposure time as rational when 
applicable (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59224=59559

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  @bruns okay for you to merge this one?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

astippich updated this revision to Diff 59224.
astippich added a comment.


  - rename format function

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59222=59224

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:167
> For a chart of typical exposure times, see 
> https://www.borrowlenses.com/blog/shutter-speed-chart/
> 
> I can confirm for my Canon SLR there is at one more value which would give a 
> deviating result, 0.3 seconds (!= 1/3s). 0.25 seconds is shown as 1/4s.

Computation now also falls back to decimal representation if it cannot be 
represented with a 1/x rational

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

astippich retitled this revision from "Format photo exposure time and bias as 
rational" to "Format photo exposure time as rational when applicable".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21613: Format focal length as milli meter

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich updated this revision to Diff 59222.
astippich added a comment.


  - add unit

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59221=59222

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:167
> For a chart of typical exposure times, see 
> https://www.borrowlenses.com/blog/shutter-speed-chart/
> 
> I can confirm for my Canon SLR there is at one more value which would give a 
> deviating result, 0.3 seconds (!= 1/3s). 0.25 seconds is shown as 1/4s.

Thanks for the information. From what I've read, for the exposure time the 
right threshold is 0.3, and the value is always a rational of 1/x.
The story seems to be different for the bias, though, so I've excluded it here.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich updated this revision to Diff 59221.
astippich added a comment.


  - only format exposure time

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59028=59221

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich added a comment.


  @ngraham what's your take regarding "Manufacturer" vs. "Equipment 
Manufacturer"?

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21532: Format the aperture values as F numbers.

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:553f96769610: Format the aperture values as F numbers. 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21532?vs=59029=59218

REVISION DETAIL
  https://phabricator.kde.org/D21532

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich planned changes to this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21532: Format the aperture values as F numbers.

[Alexander Stippich]

astippich updated this revision to Diff 59029.
astippich added a comment.


  - change formatting

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21532?vs=59003=59029

BRANCH
  photo_aperture

REVISION DETAIL
  https://phabricator.kde.org/D21532

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21538: [balooctl] Clarify and extend status output

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21538

To: bruns, #baloo, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich marked 2 inline comments as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:167
> This will give a wrong result (1/2) for 0.4 seconds.

I changed the threshold to be lower than that as a workaround.
My impression was that only 1 over something rationals are used, this 
computation will of course fail for all other cases...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich updated this revision to Diff 59028.
astippich added a comment.


  - implement feedback

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59009=59028

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich updated this revision to Diff 59009.
astippich added a comment.


  - check for zero

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59004=59009

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21532: Format the aperture values as F numbers.

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21532

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich added a comment.


  Ideally it would be possible to store rationals in KFM and Baloo, but this is 
probably a lot of work. The computation here is quite simple

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  If value is below 0.5, format the output as
  rational which is commonly used in photography.
  Value is computed from the double input value.

REPOSITORY
  R286 KFileMetaData

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21532: Format the aperture values as F numbers.

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  photo_aperture

REVISION DETAIL
  https://phabricator.kde.org/D21532

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in propertyinfo.cpp:185
> Isn't `Manufacturer` sufficient for the label? Same for `Model`.

Well, I wanted to make clear that it is all about the equipment used for 
recording, but if everyone agrees that it is sufficient without  it, I am fine 
with that. @ngraham?

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Provide a more generic and meaningful property
  and display name for the previous ImageMake and
  ImageModel properties.
  
  CCBUG: 343273

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

AFFECTED FILES
  src/extractors/exiv2extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich added a comment.


  If you have a better description for these, please let me know

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Alexander Stippich]

astippich added a comment.


  Are you still interested in working on this? If not, I would like to take 
over with the following plan:
  I would like to propose a transition phase, e.g. we make sure that there is a 
release available that can handle both formats.
  This diff lands with my requested changes.
  After the Applications 19.08 release, which can handle both cases, the output 
format is changed to multiple entries in the property map.
  All required patches for the applications have already landed: Elisa  (D20502 
) and Baloo-Widgets (D20739 
), and Dolphin (D21157 
)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: mgallien, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20359: Fix rating write for mp4 in newer TagLib versions

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20359

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21499: Show 3 significant figures when displaying doubles

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:de67dcb8263c: Show 3 significant figures when displaying 
doubles (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21499?vs=58897=58903

REVISION DETAIL
  https://phabricator.kde.org/D21499

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21499: Show 3 significant figures when displaying doubles

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21499

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21499: Show 3 significant figures when displaying doubles

[Alexander Stippich]

astippich added a comment.


  Before
  F6860072: before.png 
  After
  F6860073: after.png 
  Note that only 2 digits are displayed in this case since the it is 0.0027**0**

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21499

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21499: Show 3 significant figures when displaying doubles

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Show 3 significant digits for double values when
  displaying them with e.g. baloo-widgets
  CCBUG: 343273

REPOSITORY
  R286 KFileMetaData

BRANCH
  double_pretty

REVISION DETAIL
  https://phabricator.kde.org/D21499

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  friendly ping

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams