D11820: Handle properties with multiple values

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11820

To: astippich, #baloo, #frameworks, michaelh
Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, 
spoorun, abrahams

D11820: Handle properties with multiple values

[Alexander Stippich]

astippich commandeered this revision.
astippich added a reviewer: michaelh.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11820

To: astippich, #baloo, #frameworks, michaelh
Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, 
spoorun, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20942: Reorder includes

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7be7da0ee6f9: Reorder includes (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20942?vs=57337=57391

REVISION DETAIL
  https://phabricator.kde.org/D20942

AFFECTED FILES
  src/embeddedimagedata.cpp
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/writedata.cpp
  src/writercollection.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20942: Reorder includes

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Reorder includes to make EBN happy

REPOSITORY
  R286 KFileMetaData

BRANCH
  headers

REVISION DETAIL
  https://phabricator.kde.org/D20942

AFFECTED FILES
  src/embeddedimagedata.cpp
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/writedata.cpp
  src/writercollection.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

[Alexander Stippich]

astippich accepted this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20913: [TagLibExtractor] Fix crash on invalid Speex files

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.


  Given the outcome, I wish I never added support for speex files to the 
extractor because it was "easy to add".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20913

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:e227a7ce4587: Fix exivextractor crash with malformed 
files (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20877?vs=57157=57212

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich marked 2 inline comments as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich updated this revision to Diff 57157.
astippich marked an inline comment as done.
astippich added a comment.


  - add line break

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20877?vs=57135=57157

BRANCH
  fix_exiv_crash

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich marked an inline comment as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractor.cpp:303
> Shouldn't there be  a check here as well? And probably move the 
> `ratio.second` to after its assignment and immediately return.

Yep, forgot

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich updated this revision to Diff 57135.
astippich added a comment.


  - also check for altitude ref

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20877?vs=57130=57135

BRANCH
  fix_exiv_crash

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractor.cpp:299
> `!it->empty()` ?

Unfortunately, empty() does not exist. Same was done in 
https://phabricator.kde.org/D16165

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich added a reviewer: bruns.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Prevent a segfault by explicitly checking everywhere
  for valid entries.
  
  BUG: 405210

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_exiv_crash

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich updated this revision to Diff 56729.
astippich added a comment.


  - Test result document

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17302?vs=52894=56729

BRANCH
  test_result

REVISION DETAIL
  https://phabricator.kde.org/D17302

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/resulttest.cpp
  src/engine/document.h

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20608: Declare properties as meta type

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:e869bac59302: Declare properties as meta type (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20608?vs=56387=56722

REVISION DETAIL
  https://phabricator.kde.org/D20608

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/properties.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20608: Declare properties as meta type

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Will be used in another test

REPOSITORY
  R286 KFileMetaData

BRANCH
  enum_meta

REVISION DETAIL
  https://phabricator.kde.org/D20608

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/properties.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20528: Change properties attributes for consistency

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4808263e41bf: Change properties attributes for 
consistency (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20528?vs=56173=56385

REVISION DETAIL
  https://phabricator.kde.org/D20528

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20529: add license to python test files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:eb9b1ef9b30d: add license to python test files (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20529?vs=56174=56383

REVISION DETAIL
  https://phabricator.kde.org/D20529

AFFECTED FILES
  autotests/samplefiles/testexternalextractor/main.py
  autotests/samplefiles/testexternalwriter/main.py

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ffdee4011145: Handle variant list in formatting functions 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=55926=56384

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich requested changes to this revision.
astippich added a comment.
This revision now requires changes to proceed.


  In D20526#449780 , @bruns wrote:
  
  > In D20526#449560 , @astippich 
wrote:
  >
  > > IMHO for searching, the separation from a single string into multiple 
entries is the best thing to do, from a metadata editing point of view not so 
much.
  > >  How about inserting the TStringList entry by entry, without using the 
contactsFromString method? That would maintain the exact representation of 
metadata tags also for the baloo database.
  >
  >
  > When searching is left to baloo, it already splits up strings at whitespace 
etc., so you can provide the string as is.
  
  
  Great, that we don't have to worry about that.
  
  > As far as I can see, in some cases (e.g. "ARTIST"), the `Taglib::StringList 
PropertyMap::operator[]` is first joined (`.toString(';')`) and then split 
again. How about avoiding that in the first place?
  
  That's what I meant. That was the easy way before because of the 
contactsFromString function, but if KFM individually adds each entry of the 
TStringList returned from TagLib's PropertyMap, all will be fine.
  Please also adjust "Conductor", "Arranger", "Performer and "Author" for 
consistency

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20523: Remove a dead declaration

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20523

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20529: add license to python test files

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  silence EBN

REPOSITORY
  R286 KFileMetaData

BRANCH
  py_license

REVISION DETAIL
  https://phabricator.kde.org/D20529

AFFECTED FILES
  autotests/samplefiles/testexternalextractor/main.py
  autotests/samplefiles/testexternalwriter/main.py

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20528: Change properties attributes for consistency

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Move all the handling of (string-)lists into
  the member function, and mark the attributes
  consistently.

REPOSITORY
  R286 KFileMetaData

BRANCH
  properties_consistency

REVISION DETAIL
  https://phabricator.kde.org/D20528

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich added a dependent revision: D20528: Change properties attributes for 
consistency.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20528: Change properties attributes for consistency

[Alexander Stippich]

astippich added a dependency: D19445: Handle variant list in formatting 
functions.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20528

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich added a comment.


  IMHO for searching, the separation from a single string into multiple entries 
is the best thing to do, from a metadata editing point of view not so much.
  How about inserting the TStringList entry by entry, without using the 
contactsFromString method? That would maintain the exact representation of 
metadata tags also for the baloo database.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ccc0e0b9238e: Force en locale for propertyinfotest 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20358?vs=56002=56134

REVISION DETAIL
  https://phabricator.kde.org/D20358

AFFECTED FILES
  autotests/propertyinfotest.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D12222: baloodb: Use complete access filtering for all outputs

[Alexander Stippich]

astippich added a comment.
Herald added a subscriber: kde-frameworks-devel.


  @bruns this still applies cleanly to current master, do you think this and 
the dependent revision are still worth it to merge?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D1

To: michaelh, #baloo, #frameworks
Cc: kde-frameworks-devel, astippich, bruns, gennad, domson, ashaposhnikov, 
michaelh, spoorun, ngraham, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  And I propose a different one :)
  IMHO bundling these two is sub-optimal as it creates an unnecessary 
dependency on kde-specific libraries and limits its deployment. To me, this is 
the equivalent of bundling the audio thumbnailer with taglib.
  
  Well, if we disagree here, I'd still like to merge this as is because it gets 
the code into a compiling and working state at least.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich updated this revision to Diff 56002.
astippich added a comment.


  - add comment

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20358?vs=55760=56002

BRANCH
  fix_test

REVISION DETAIL
  https://phabricator.kde.org/D20358

AFFECTED FILES
  autotests/propertyinfotest.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  It creates a dependency loop as you pointed out in the first comment

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20459: [balooctl] Extend options help text, improve error checking

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20459

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich updated this revision to Diff 55926.
astippich added a comment.


  - remove unrequired parenthesis

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=55326=55926

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  In D17500#447049 , @aacid wrote:
  
  > In D17500#446937 , @astippich 
wrote:
  >
  > > The plan I was about to propose is to move the thumbnailer to 
kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting 
the KIO dependency of QMobipocket. I think a KIO dependency for such a library 
is inconvenient.
  >
  >
  > qmobipocket only depends on Qt::Core and Qt::Gui.
  
  
  To be more precise, the thumbnailer packaged alongside qmobipocket requires 
kio

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich added a comment.


  It is a documentation bug.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20358

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  The plan I was about to propose is to move the thumbnailer to 
kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting 
the KIO dependency of QMobipocket. I think a KIO dependency for such a library 
is inconvenient.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Restore mobipocket extractor

[Alexander Stippich]

astippich updated this revision to Diff 55848.
astippich added a comment.


  - rebase and update
  - update test
  - disable mobi extractor

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17500?vs=47335=55848

BRANCH
  mobi

REVISION DETAIL
  https://phabricator.kde.org/D17500

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/mobiextractortest.cpp
  autotests/samplefiles/test.mobi
  src/extractors/CMakeLists.txt
  src/extractors/mobiextractor.cpp

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich retitled this revision from "Restore mobipocket extractor" to "Get 
mobipocket extractor up-to-date, but keep disabled".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich added a comment.


  https://bugreports.qt.io/browse/QTBUG-75069

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20358

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

[Alexander Stippich]

astippich added a comment.


  windows build fails 
  
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/console

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20133

To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: adridg, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich added a comment.


  There already was a bug report some time ago 
  https://bugreports.qt.io/browse/QTBUG-15488
  
  looks like it regressed. The given test in the bug report also does not work 
here.
  I will open a new one.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20358

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich updated this revision to Diff 55760.
astippich added a comment.


  - use enum

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20358?vs=55684=55760

BRANCH
  fix_test

REVISION DETAIL
  https://phabricator.kde.org/D20358

AFFECTED FILES
  autotests/propertyinfotest.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D11882: autotests: Use built executable instead of installed

[Alexander Stippich]

astippich added a comment.


  @bruns this diff tries to accomplish the same as D19268 
, and can be closed, right?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: astippich, bruns, alexeymin, gennad, domson, ashaposhnikov, spoorun, 
abrahams

D20345: Use compact Json format when converting query URLs

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  kio_search

REVISION DETAIL
  https://phabricator.kde.org/D20345

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20364: Dont add default valued date filters to json

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  kio_search

REVISION DETAIL
  https://phabricator.kde.org/D20364

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in propertyinfotest.cpp:51
> This is somewhat strange ...
> 
> According to
> https://doc.qt.io/qt-5/qlocale.html#Language-enum
> 
> > The "C" locale is identical in behavior to English/UnitedStates.
> 
> So either "en" is not "en_US", or the Qt documentation is wrong ...

"en_US" also fixes the test for me...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20358

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20360: Test all extractors with strict mime type

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0cfa32c2a376: Test all extractors with strict mime type 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20360?vs=55692=55703

REVISION DETAIL
  https://phabricator.kde.org/D20360

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/exiv2extractortest.cpp
  autotests/odfextractortest.cpp
  autotests/odfextractortest.h
  autotests/office2007extractortest.cpp
  autotests/popplerextractortest.cpp
  autotests/postscriptdscextractortest.cpp
  autotests/postscriptdscextractortest.h
  autotests/xmlextractortest.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  only one minor nitpick

INLINE COMMENTS

> main.cpp:136
>  
> +stream << "Url:" << url << "\n";
>  stream << "GivenID: " << fid << " ActualID: " << actualFid 
> << "\n";

Also add a space here after "Url:"?

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20328

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20360: Test all extractors with strict mime type

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Test all the extractors with the strictMimeType function
  Fortunately, no new missing mime types

REPOSITORY
  R286 KFileMetaData

BRANCH
  test_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D20360

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/exiv2extractortest.cpp
  autotests/odfextractortest.cpp
  autotests/odfextractortest.h
  autotests/office2007extractortest.cpp
  autotests/popplerextractortest.cpp
  autotests/postscriptdscextractortest.cpp
  autotests/postscriptdscextractortest.h
  autotests/xmlextractortest.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20120: Use new mimetype helper in taglib extractor test

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0d9aebdd05b5: Use new mimetype helper in taglib extractor 
test (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20120?vs=55058=55691#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20120?vs=55058=55691

REVISION DETAIL
  https://phabricator.kde.org/D20120

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.json

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20120: Use new mimetype helper in taglib extractor test

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20120

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  Still kind of hard to read, especially on phabricator. Anyway, a definite 
improvement.
  Untested on anything besides linux

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20133

To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: adridg, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20359: Fix rating write for mp4 in newer TagLib versions

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  This fixes reading and writing rating via the mp4
  rate atom. This does not fix reading from "legacy"
  rating atoms which stores rating as text. 
  Fixes CI writing test.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_writer_int

REVISION DETAIL
  https://phabricator.kde.org/D20359

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Fix CI propertyinfotest

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_test

REVISION DETAIL
  https://phabricator.kde.org/D20358

AFFECTED FILES
  autotests/propertyinfotest.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20033: Default string formatting test to C locale, add localized run

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  works nicely!

REPOSITORY
  R286 KFileMetaData

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D20033

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> propertydata.cpp:88
> +if (it.value().isArray()) {
> +const auto values = it.value().toArray();
> +for (const auto val : values) {

Can you return arrays as lists here so that current behavior is unchanged, and 
put the behavior change into another patch so that we can merge this diff?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: mgallien, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18665: Cleanup taglib writer test

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:452edb1b4c80: Cleanup taglib writer test (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18665?vs=50711=55429

REVISION DETAIL
  https://phabricator.kde.org/D18665

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:8e79f7ce2b7c: Implement support for writing rating 
information for taglib writer (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18604?vs=55298=55428

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18603: Implement more tags for taglib writer

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:926c70460edc: Implement more tags for taglib writer 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18603?vs=55126=55427

REVISION DETAIL
  https://phabricator.kde.org/D18603

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:982ebe58b3c8: Rewrite taglib writer to use property 
interface (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18601?vs=55125=55426#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18601?vs=55125=55426

REVISION DETAIL
  https://phabricator.kde.org/D18601

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20121: Test ffmpeg extractor using mime type helper

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:25eca3185ffa: Test ffmpeg extractor using mime type 
helper (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20121?vs=55301=55425

REVISION DETAIL
  https://phabricator.kde.org/D20121

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  src/extractors/ffmpegextractor.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich updated this revision to Diff 55326.
astippich added a comment.


  - rebase on master

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=54956=55326

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20219: Propose Stefan Bruns as KFileMetaData maintainer

[Alexander Stippich]

astippich added a comment.


  I think @bruns is much more qualified than me as a maintainer as I lack 
overall experience in programming. He still finds wrong stuff in almost any 
revision of mine :)
  also +1 for baloo

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20219

To: apol, #frameworks, mgallien
Cc: mgallien, bruns, ngraham, astippich, kde-frameworks-devel, #baloo, gennad, 
domson, ashaposhnikov, michaelh, spoorun, abrahams

D20121: Test ffmpeg extractor using mime type helper

[Alexander Stippich]

astippich updated this revision to Diff 55301.
astippich added a comment.


  - add friend and use member function

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20121?vs=55059=55301

BRANCH
  ffmpeg_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D20121

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  src/extractors/ffmpegextractor.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich updated this revision to Diff 55298.
astippich added a comment.


  - cleanup and formatting

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18604?vs=55127=55298

BRANCH
  rating_write2

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20046: Verify mimetypes for all existing sample files, add some more

[Alexander Stippich]

astippich added a comment.


  This causes one test failure on FreeBSD:
  
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20082: Safeguard against invalid files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1ac4253f3cf0: Safeguard against invalid files (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20082?vs=54958=55296

REVISION DETAIL
  https://phabricator.kde.org/D20082

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20138: Add a helper to determine actual supported parent mime type

[Alexander Stippich]

astippich added a comment.


  Oh, another idea: Cannot this be used to determine that the extractor 
supports the inheriting mimetype as required in D20121 
? Would need to be public for this, though, 
or the test needs to be made a friend class.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20138

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20138: Add a helper to determine actual supported parent mime type

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  Forget my comment, I thought it would be possible to share some code with the 
ExtractorCollection, but the implementation is too different

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20138

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich updated this revision to Diff 55127.
astippich added a comment.


  - rebase
  - simplify id3 rating to array

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18604?vs=55056=55127

BRANCH
  rating_write2

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich updated this revision to Diff 55126.
astippich added a comment.


  - rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18603?vs=50705=55126

BRANCH
  enhance_taglibwriter2

REVISION DETAIL
  https://phabricator.kde.org/D18603

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter2

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich updated this revision to Diff 55125.
astippich added a comment.


  - check that file is valid
  - rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18601?vs=50704=55125

BRANCH
  rewrite_taglib2

REVISION DETAIL
  https://phabricator.kde.org/D18601

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20082: Safeguard against invalid files

[Alexander Stippich]

astippich added a comment.


  ping. I would like to land this for KF 5.57 to fix crashes in the taglib 
extractors because of invalid files once and for all.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20082

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich added a comment.


  ping. This will be beneficial for handling lists regardless of the discussion 
in D19087 

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20138: Add a helper to determine actual supported parent mime type

[Alexander Stippich]

astippich added a comment.


  Shouldn't this go into MimeUtils?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20138

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Alexander Stippich]

astippich added a subscriber: mgallien.
astippich added a comment.


  My main concern is that this changes current behavior and as such is not 
backwards compatible. The rest is a bonus.
  That is why my plan was to make the extractors output (string-)lists as 
outlined in T8196  (this task has been there 
for quite a while, feedback would have been nice). 
  This way, current behavior can be preserved while also fixing all bugs with 
multi-value properties.
  If changing this behavior is okay, then you should at least post patches that 
adapt all clients. I know of Baloo-widgets, Dolphin and Elisa.
  But there will be combinations of frameworks and applications that will not 
work correctly for multi-value properties.
  What do others think of this? @mgallien?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: mgallien, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20121: Test ffmpeg extractor using mime type helper

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> ffmpegextractor.cpp:64
>  QStringLiteral("video/x-msvideo"),
> +QStringLiteral("video/x-theora+ogg"),
>  };

This is quite specific to the codec. ExtractorCollection should handle this 
case I think (mime type of file is more specific than in the mime type list), 
but I added it nevertheless.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20121

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20121: Test ffmpeg extractor using mime type helper

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Use mime type helper to test ffmpeg extractor and add
  new mime type
  
  CCBUG: 399650

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D20121

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20120: Use new mimetype helper in taglib extractor test

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Use the new mimetype helper in the taglib extractor test
  and fix the resulting failures

TEST PLAN
  tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  mimetype_tests

REVISION DETAIL
  https://phabricator.kde.org/D20120

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.json

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added a comment.


  After some thinking, I have split up the function for writing specific Ape 
and Vorbis tags, as many more tags like "Opus" etc. are in use for Vorbis tags 
and not for Ape, and can be easily added this way. I am still using the 
property map, though.
  Are you fine with this?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich updated this revision to Diff 55056.
astippich added a comment.


  - split ape and vorbis tag writing functions

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18604?vs=50709=55056

BRANCH
  rating_write2

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  In D17302#439605 , @bruns wrote:
  
  > IMHO this test is pointless, as the contents of the variant map is 
inaccessible, it is only an intermediate storage. The correct way to retrieve 
the data is via `Result::document()`. Or you can just accept D19087 
, which already checks this is correct.
  
  
  I would appreciate it next time if you think it is pointless, you say so 
right away, instead of providing hints on how to improve it. Otherwise it is a 
waste of time.
  Also, testing Result::document() was always the next step. And at the time of 
writing (4 month ago!), it certainly was not pointless as this is the code 
responsible that Baloo outputs lists after serialization/deserialization.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Alexander Stippich]

astippich requested changes to this revision.
astippich added a comment.
This revision now requires changes to proceed.


  This still alters the map during deserialization. Lists are converted into 
multi single properties afterwards. As I said, due to backwards-compatibility 
lists should stay lists.

INLINE COMMENTS

> propertyserializationtest.cpp:55
> +
> +// Test empty property map
> +void PropertySerializationTest::testSingleProp()

wrong comment, also everywhere below

> propertyserializationtest.cpp:130
> +properties.insertMulti(KFMProp::Ensemble, 
> QVariantList({QVariant("ensemble1"), QVariant("ensemble2")}));
> +properties.insertMulti(KFMProp::Rating, QVariantList({QVariant(10), 
> QVariant(20.0)}));
> +

nitpick: the rating is usually normalized to 0 to 10, so using 20 here is a 
little bit strange

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20011: Be more precise with mimetype detection

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a256687a1d11: Be more precise with mimetype detection 
(authored by astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20011?vs=54959=55055

REVISION DETAIL
  https://phabricator.kde.org/D20011

AFFECTED FILES
  src/file/extractor/app.cpp

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20011: Be more precise with mimetype detection

[Alexander Stippich]

astippich edited the summary of this revision.
astippich edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20011

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20011: Be more precise with mimetype detection

[Alexander Stippich]

astippich updated this revision to Diff 54959.
astippich added a comment.


  - use new mime type helper

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20011?vs=54649=54959

BRANCH
  mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D20011

AFFECTED FILES
  src/file/extractor/app.cpp

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20082: Safeguard against invalid files

[Alexander Stippich]

astippich added a comment.


  Seems like a good idea in general, and a patch for upstream to fix the crash 
was rejected.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20082

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20082: Safeguard against invalid files

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Invalid vorbis files may crash in taglib due to a dereference
  on an invalid pointer. Explicitly check that the file is valid.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_invalid

REVISION DETAIL
  https://phabricator.kde.org/D20082

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  ping?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich updated this revision to Diff 54956.
astippich marked an inline comment as done.
astippich added a comment.


  - implement feedback

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=54651=54956

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20012: Fix number localization for properties

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:607286e97229: Fix number localization for properties 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20012?vs=54950=54953

REVISION DETAIL
  https://phabricator.kde.org/D20012

AFFECTED FILES
  src/formatstrings.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20013: Use Qt function for string list formatting

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:3a83a49a4350: Use Qt function for string list formatting 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20013?vs=54951=54954

REVISION DETAIL
  https://phabricator.kde.org/D20013

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20013: Use Qt function for string list formatting

[Alexander Stippich]

astippich added a comment.


  Is removing a string allowed during string freeze?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20013

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich removed a dependent revision: D20013: Use Qt function for string list 
formatting.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20013: Use Qt function for string list formatting

[Alexander Stippich]

astippich removed a dependency: D19445: Handle variant list in formatting 
functions.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20013

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams