D16018: Fix align of doxygen comments in templates

2018-10-21 Thread Bernd Buschinski 
buschinski closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor, dhaumann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16018: Fix align of doxygen comments in templates

2018-10-21 Thread Bernd Buschinski 
buschinski updated this revision to Diff 44010.
buschinski retitled this revision from "Fix align of doxygen comments" to "Fix 
align of doxygen comments in templates".
buschinski removed a project: KDevelop.
buschinski removed a subscriber: kdevelop-devel.
buschinski added a comment.


  - updated again master
  - mentioned templates in commit title

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16018?vs=43201&id=44010

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  autotests/src/templatehandler_test.cpp
  autotests/src/templatehandler_test.h
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor, dhaumann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, 
geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16018: Fix align of doxygen comments

2018-10-21 Thread Bernd Buschinski 
buschinski added a comment.


  Thx for the review :)
  I will update the patch (and post it here again).
  
  I can commit it myself, to master? or any special branch?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor, dhaumann
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-09 Thread Bernd Buschinski 
buschinski updated this revision to Diff 43201.
buschinski added a comment.


  Changed to (correct) ktexteditor repository. Someday... I will learn how to 
use phabricator :)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16018?vs=43088&id=43201

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  autotests/src/templatehandler_test.cpp
  autotests/src/templatehandler_test.h
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-07 Thread Bernd Buschinski 
buschinski changed the repository for this revision from R32 KDevelop to R39 
KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-07 Thread Bernd Buschinski 
buschinski added a comment.


  This did not work for templates as "isComment" uses line attributes and at 
the time the template is inserted it is always "C/C++ Code/Data"-attribute 
never a comment. It only becomes a "doxygen comment"-attribute after the 
template "editing" is finished.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-07 Thread Bernd Buschinski 
buschinski updated this revision to Diff 43088.
buschinski edited the summary of this revision.
buschinski edited the test plan for this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16018?vs=43050&id=43088

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  autotests/src/templatehandler_test.cpp
  autotests/src/templatehandler_test.h
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-07 Thread Bernd Buschinski 
buschinski added a comment.


  In D16018#338441 , @cullmann wrote:
  
  > ...
  >  For the code:
  >  Hmm, why do you use rtrim? That removes trailing spaces, that won't help 
the startsWith checks. Or do I misread that?
  
  
  You are absolutely right, this makes no sense. I further investigate & fix.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-07 Thread Bernd Buschinski 
buschinski created this revision.
buschinski added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
buschinski requested review of this revision.

REVISION SUMMARY
  After 
  https://bugs.kde.org/show_bug.cgi?id=360456
  
https://cgit.kde.org/ktexteditor.git/commit/?id=58baf7c318d4641a243ea18f04ef15ee017509e3
  
  the align of doxygen comments in templates stopped working.
  
  Without the patch:
  
/**
* foo
*/
void foo();
  
  with the patch:
  
/**
 * foo
 */
void foo();
  
  TODO: the added testcase does work with and without the patch. I can not 
create a reproducible test and need some help.
  
  currently only reproducible with kdevelop

TEST PLAN
  - start kdevelop
  - open any c/cpp file with functions
  - select the function / click in the name
  - Code -> Document Declaration
  
  -> not properly align
  
  - LD_PRELOAD=libKF5TextEditor.so kdevelop (with the patch)
  - repeat the rest of the steps
  
  -> correctly aligned

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

Re: KItemModels, Solid & KJS licenses

2014-02-26 Thread Bernd Buschinski 
hi,
I confirm that I would be happy to the files listed below relicensed from
GPL to LGPLv2+.

Seriously, I don't really care that much if its gpl or lgpl, as long as its
available for everyone who want to improve it ;>
Or ,if possible, I would relicense it to LGPLv2+ & beer license, but sadly
they are incompatible ;-)


2014-02-26 15:27 GMT+01:00 šumski :

> On Thursday 20 of February 2014 11:41:48 Alex Merry wrote:
> > CC'd people: please can you confirm that you would be happy to have the
> > files listed below relicensed from GPL to LGPLv2+?
> 
> Small ping :)
> It would be awesome if we could get this sorted for alpha2
>
>
> Cheers,
> Hrvoje
> > ___
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115502: Fix math function checks

2014-02-05 Thread Bernd Buschinski 


> On Feb. 5, 2014, 7:37 p.m., Bernd Buschinski wrote:
> > Ship It!

and btw good catch for the math vs. cmake undef, seems like I overlooked it :)


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115502/#review49067
---


On Feb. 5, 2014, 5:03 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115502/
> ---
> 
> (Updated Feb. 5, 2014, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.
> 
> 
> Repository: kjs
> 
> 
> Description
> ---
> 
> Fix math function checks
> 
> Between things being in the std:: namespace and  and 
> interfering with each other (at least for glibc), the configure checks
> for math functions do not actually perform the checks they claim to.
> 
> This tests that the functions (in whatever form) can reasonably be
> called from C++ code that includes both  and .
> 
> 
> Diffs
> -
> 
>   src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
>   src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
>   src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 
> 
> Diff: https://git.reviewboard.kde.org/r/115502/diff/
> 
> 
> Testing
> ---
> 
> Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux).  
> The configure checks report the results you would expect (providing you are 
> aware that cmath undefs signbit).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Bernd Buschinski 


> On Feb. 5, 2014, 5:04 p.m., Alex Merry wrote:
> > Nope, still breaks on Linux.  I think it's because  undefs the 
> > signbit macro.
> > 
> > I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for 
> > this part of your request.

I would also prefer https://git.reviewboard.kde.org/r/115494/ for the math 
checks.

But still your patch is not invalid, as it has the struct timerval wrt thingie, 
so as it looks safe, I would say, for the struct stuff, ship it


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/#review49051
---


On Feb. 5, 2014, 4:06 p.m., Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115494/
> ---
> 
> (Updated Feb. 5, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Bernd Buschinski.
> 
> 
> Repository: kjs
> 
> 
> Description
> ---
> 
> Build on Mac OS X
> 
> Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, 
> so manually cast to the required type.
> 
> Also, there seems to be some magic with __signbit, it seems to be detected 
> but then compilation fails. Prefer the suggested ::signbit() instead if 
> available.
> 
> 
> Diffs
> -
> 
>   src/kjs/ConfigureChecks.cmake 473da1c 
>   src/kjs/global.h.cmake d821a72 
>   src/kjs/interpreter.cpp e699651 
>   src/kjs/operations.h a54f366 
> 
> Diff: https://git.reviewboard.kde.org/r/115494/diff/
> 
> 
> Testing
> ---
> 
> It compiles again on Mac OS X :)
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115502: Fix math function checks

2014-02-05 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115502/#review49067
---

Ship it!


Ship It!

- Bernd Buschinski


On Feb. 5, 2014, 5:03 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115502/
> ---
> 
> (Updated Feb. 5, 2014, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.
> 
> 
> Repository: kjs
> 
> 
> Description
> ---
> 
> Fix math function checks
> 
> Between things being in the std:: namespace and  and 
> interfering with each other (at least for glibc), the configure checks
> for math functions do not actually perform the checks they claim to.
> 
> This tests that the functions (in whatever form) can reasonably be
> called from C++ code that includes both  and .
> 
> 
> Diffs
> -
> 
>   src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
>   src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
>   src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 
> 
> Diff: https://git.reviewboard.kde.org/r/115502/diff/
> 
> 
> Testing
> ---
> 
> Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux).  
> The configure checks report the results you would expect (providing you are 
> aware that cmath undefs signbit).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel