D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added a comment.


  Ping :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, 
skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23879

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 updated this revision to Diff 73195.
GB_2 marked an inline comment as done.
GB_2 added a comment.


  Use David's suggestion

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26043?vs=71675=73195

BRANCH
  arcpatch-D26043

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart, ngraham, davidedmundson
Cc: davidedmundson, ngraham, broulik, mart, #vdg, kde-frameworks-devel, 
#plasma, LeGast00n, GB_2, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:629db2f3b55b: Add edit mode menu item to desktop widget 
context menu (authored by GB_2).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26043?vs=73195=73196

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart, ngraham, davidedmundson
Cc: davidedmundson, ngraham, broulik, mart, #vdg, kde-frameworks-devel, 
#plasma, LeGast00n, GB_2, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 added a comment.


  Ping :-)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart, ngraham
Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> broulik wrote in containmentinterface.cpp:1128
> Please check `m_containment->immutability()` so we don't add this if widgets 
> are locked

Are you sure? It is already automatically disabled when immutability is 
`UserImmutable` and completely hidden if `SystemImmutable`, as it should be 
(same as for the desktop).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart
Cc: broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24522: Add presentwindows icon (old "task view" from windows)

[Björn Feber]

GB_2 added a comment.


  In D24522#544338 , @Zren wrote:
  
  > > `preferences-system-windows-effect-presentwindows`
  >
  > That would look like the `homerun` icon, which looks like the "windows" 
logo.
  >
  > F7557693: 2019-10-09___13-01-07.png 
  >
  > When you clicked on "Task View" in Windows, the 2 "obscured" windows would 
animate left/right a little to demonstrate that all windows are now visible. 
There isn't really a good way to know when the KWin Effect is active like that 
though to do a similar animation.
  >
  > Nowadays, Windows has a different icon for their "task history" view.
  
  
  What about this, but with 3 or 2 windows?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

To: Zren, #vdg, #breeze
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23352: make button icons follow a reasonable size and layout

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23352

To: camiloh, #plasma, mart, ngraham
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 updated this revision to Diff 71675.
GB_2 added a comment.


  Remove space

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26043?vs=71674=71675

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 updated this revision to Diff 71674.
GB_2 added a comment.


  Decrease line count

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26043?vs=71670=71674

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 added a reviewer: mart.
GB_2 added a subscriber: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  - much improves discoverability of the ability to move added widgets without 
clicking and holding (I have seen people having trouble figuring it out)
- makes it more consistent with panel widget context menus
- allows easier access to the edit mode when the desktop is full of widgets

TEST PLAN
  Open the context menu of a widget on the desktop.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Björn Feber]

GB_2 added a comment.


  In D25360#573798 , @IlyaBizyaev 
wrote:
  
  > Should this also affect GTK apps? There's a matching radio group in the GTK 
KCM.
  
  
  D25703 

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D25360

To: ngraham, #frameworks, #plasma
Cc: GB_2, IlyaBizyaev, broulik, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D25149: Add a new template for KCMs

[Björn Feber]

GB_2 added reviewers: Plasma, Frameworks.
GB_2 added a project: Plasma.
GB_2 added a subscriber: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25149: Add a new template for KCMs

[Björn Feber]

GB_2 added a comment.


  In D25149#559684 , @tcanabrava 
wrote:
  
  > We need a better icon. it's the icon for the `Plasmoid` template.
  
  
  Why not use the system settings icon as it's a KCM template?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava
Cc: GB_2, yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D25123: [WIP] New yakuake logo/icon

[Björn Feber]

GB_2 added a comment.


  In D25123#560491 , @ndavis wrote:
  
  > I think I prefer C the most now that I've seen it next to other icons. It 
has a similar level of detail to other Breeze icons.
  
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: GB_2, ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, michaelh, bruns

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Björn Feber]

GB_2 added a comment.


  +1

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25049

To: ngraham, #vdg, #plasma, mart
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23951: Improve panel options menu entries

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bbe0148db5d1: Improve panel options menu entries 
(authored by GB_2).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=68467=68469

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

GB_2 removed a dependent revision: D24162: Hide "Lock Widgets" button from 
panel edit mode toolbar.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 updated this revision to Diff 68467.
GB_2 added a comment.


  Don't hide lock action here

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=8=68467

BRANCH
  arcpatch-D23951

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

GB_2 retitled this revision from "Improve and clean up panel options menu 
entries" to "Improve panel options menu entries".
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 marked an inline comment as done.
GB_2 added a comment.


  In D23951#551472 , @mart wrote:
  
  > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in 
the UI (hide "Lock Widgets" from the UI)  i would try to go from the context 
menu plugin instead and not adding the action there by default (but still 
possible to add it)
  >  apart from that, it looks good
  
  
  Wait, doesn't that mean you won't be able to unlock it anymore?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 added a comment.


  In D23951#551472 , @mart wrote:
  
  > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in 
the UI (hide "Lock Widgets" from the UI)  i would try to go from the context 
menu plugin instead and not adding the action there by default (but still 
possible to add it)
  
  
  Ok, will do that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24263: edit mode action

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> corona.cpp:502
> +});
> +editAction->setText(i18n("Customize Layout"));
> +editAction->setAutoRepeat(true);

Missing ellipsis (...)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Björn Feber]

GB_2 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Björn Feber]

GB_2 added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Björn Feber]

GB_2 added a comment.


  Can we also set the root folder icon?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Björn Feber]

GB_2 added a comment.


  Can you clean the SVGs a bit?

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Björn Feber]

GB_2 added a dependent revision: D24533: Draw categories in iconview in a 
similiar style as Kirigami and new KCategoryDrawer.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kde_edu, #kde_pim, 
#kpublictransport, #amarok, ngraham
Cc: ndavis, ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24318: Make 32px document-save icon colorful

[Björn Feber]

GB_2 added a comment.


  In D24318#542048 , @ndavis wrote:
  
  > Yeah, that was a feature of the original icon that I didn't remove. I 
wasn't so sure about it either.
  
  
  If you don't like it then remove it :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24598: Update elisa icon

[Björn Feber]

GB_2 added a comment.


  I don't think it makes sense to change the icon here if D12992 
 already does it. If you want it to 
progress then take over the revision and work on the completely new style there 
or make a ping comment and have some patience.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24263: edit mode action

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> corona.cpp:419
> +} else {
> +editAction->setText(i18n("Customize Layout"));
> +}

Missing ellipsis (...)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 retitled this revision from "Improve desktop layout and panel editing UX" 
to "Improve and clean up panel options menu entries".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:50593c561899: Add standard icons to support to all 
entries in QDialogButtonBox (authored by GB_2).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24415?vs=67336=67508

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg, davidedmundson, ngraham
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ppeter wrote in executablefileopendialog.cpp:58
>   if (mode == OnlyExecute)
> connect(executeButton, ...)
>   else if (mode == OpenAsExecute)
> ...
> 
> looks better :)

That would be against the common KDE coding style: 
https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Björn Feber]

GB_2 updated this revision to Diff 67336.
GB_2 marked 2 inline comments as done.
GB_2 added a comment.


  Address comments

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24415?vs=67329=67336

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 398973
  Implement the new enumarations introduced in Qt 5.14: 
https://codereview.qt-project.org/c/qt/qtbase/+/254494/

TEST PLAN
  Can't really test since Qt 5.14 is not released yet, but QDialogButtonBox 
buttons should now all have icons.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Björn Feber]

GB_2 added a reviewer: davidedmundson.
GB_2 added a subscriber: davidedmundson.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

[Björn Feber]

GB_2 added a comment.


  In D24318#541839 , @ndavis wrote:
  
  > How about this?
  >  F7513643: document-save.svg 
  >  F7513644: montage.png 
  
  
  I love it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 resigned from this revision.
This revision now requires review to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in corona.cpp:406
> This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would 
> make the name better correspond with the text of the opposite state too.
> 
> Alternatives:
> 
> - Edit Layout and Widgets/Freeze Layout and Widgets
> - Configure Layout and Widgets/Freeze Layout and Widgets
> - Configure Layout and Widgets/Finish Configuring Layout and Widgets
> - Customize Layout/Finish Customizing Layout

What about...

- "Switch to Edit Mode"/"Leave Edit Mode"
- "Enter Edit Mode"/"Exit Edit Mode"
- "Edit Panels and Widgets"/"Finish Editing Panels and Widgets"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23388: add a border for the toolbars WIP

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23388

To: camiloh, #plasma, mart, ngraham, apol
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added 1 blocking reviewer(s): Plasma.
This revision now requires review to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 removed a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24239: make editMode a corona global property

[Björn Feber]

GB_2 added a dependent revision: D24246: Only show panel toolbox when desktop 
toolbox is open.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24239: make editMode a corona global property

[Björn Feber]

GB_2 added a comment.


  Thanks!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24227: Add colorful preferences-desktop-filter icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:63b9438be1e4: Add colorful preferences-desktop-filter 
icon (authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24227?vs=66839=66846

REVISION DETAIL
  https://phabricator.kde.org/D24227

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-filter.svg
  icons/preferences/32/preferences-desktop-filter.svg

To: GB_2, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D24227: Add colorful preferences-desktop-filter icon

[Björn Feber]

GB_2 updated this revision to Diff 66839.
GB_2 added a comment.


  Make bottom hard show slightly stronger

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24227?vs=66838=66839

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24227

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-filter.svg
  icons/preferences/32/preferences-desktop-filter.svg

To: GB_2, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D24227: Add colorful preferences-desktop-filter icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 406900
  F7431167: preferences-desktop-filter Icon.png 


TEST PLAN
  Search for `preferences-desktop-filter` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24227

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-filter.svg
  icons/preferences/32/preferences-desktop-filter.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23879

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a comment.


  In D23951#537202 , @ngraham wrote:
  
  > we need to wait for a visible non-right-click method to enter Panel Edit 
Mode.
  
  
  I think we'll need a task for that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a comment.


  In D23951#537202 , @ngraham wrote:
  
  > +1 in general, but since this removes the GUI ability to enter locked mode, 
it can't land until D23952  is ready, which 
means we need to wait for a visible non-right-click method to enter Panel Edit 
Mode. Maybe for now we can put that in the Desktop Toolbox lol.
  
  
  What if we don't remove the panel toolbox yet, but only show it when the 
desktop toolbox is open, similar to how widget controls are shown when you have 
the desktop toolbox open.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a comment.


  Changed the menu again!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 edited dependent revision(s), added 1: D24162: Hide "Lock Widgets" button 
from panel edit mode toolbar; removed 1: D23952: Remove panel toolbox.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 removed a dependency: D23950: Only show "Add Widgets..." panel context 
menu option in panel edit mode.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 updated this revision to Diff 8.
GB_2 added a comment.


  Fix diff

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66162=8

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 updated this revision to Diff 66167.
GB_2 added a comment.


  Also for Qt 4

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23879?vs=66166=66167

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23879

AFFECTED FILES
  icons-dark/apps/48/designer-qt5.svg
  icons/apps/48/designer-qt5.svg

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 updated this revision to Diff 66166.
GB_2 added a comment.


  Rename to `designer-qt5` to avoid overriding unrelated icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23879?vs=65857=66166

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23879

AFFECTED FILES
  icons-dark/apps/48/designer-qt5.svg
  icons/apps/48/designer-qt5.svg

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 updated this revision to Diff 66162.
GB_2 added a comment.


  Really add back "Show Alternatives..." item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66160=66162

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 updated this revision to Diff 66160.
GB_2 added a comment.


  Add back "Show Alternatives..." item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66103=66160

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/private/applet_p.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23969: [kpropertiesdialog] add icons for the size section

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:764616b91b21: [kpropertiesdialog] add icons for the size 
section (authored by tienisto, committed by GB_2).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23969?vs=66130=66146

REVISION DETAIL
  https://phabricator.kde.org/D23969

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23969: [kpropertiesdialog] add icons for the size section

[Björn Feber]

GB_2 accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23972: Add icons for "Open With" and "Actions" menus

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Excellent!

REPOSITORY
  R241 KIO

BRANCH
  icons-in-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23972

To: ngraham, #vdg, GB_2
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a dependent revision: D23952: Remove panel toolbox clean up editing 
options.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 retitled this revision from "Move "Panel Options" context menu items out 
of submenu and rename "Configure Panel..." option" to "Improve desktop layout 
and panel editing UX".
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 updated this revision to Diff 66103.
GB_2 added a comment.


  Only show "Unlock Widgets" in the UI and only show "Show Alternatives..." in 
panel edit mode

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66095=66103

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 added a comment.


  In D23951#531545 , @ngraham wrote:
  
  > Two things with this patch series:
  >
  > 1. Now there's no way to lock widgets without entering panel edit mode. 
Feels like we might as well just get rid of unlocked mode entirely. Or are more 
patches coming? Did we ever come to a conclusion in T10190 
?
  
  
  Right, I think we'll need to discuss it a bit more.
  
  > - Delay D23950  until Plasma 5.18 
(maybe for the best if the final UX is not clear yet)
  
  Yeah, then we have some more time to think about the UX and test it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 added a dependency: D23950: Only show "Add Widgets..." and "Lock Widgets" 
panel context menu options in panel edit mode.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  See M144  and T10047 
. This makes the panel customization 
options much more discoverable. This is how it looks like together with 
PATCH_HERE:
  
  Unlocked Widgets: F7352335: Improved Panel Context Menu Widgets Unlocked.png 

  
  Locked Widgets: F7352331: Improved Panel Context Menu Widgets Locked.png 


TEST PLAN
  Open the panel context menu

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  Now it's good!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531364 , @guoyunhe wrote:
  
  > @GB_2 is it correct now?
  
  
  There's still a hardcoded `style="fill:#da4453"` in the `disable` icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531349 , @guoyunhe wrote:
  
  > I was asked to remove the hard code color like: `fill="currentColor"` and 
`fill="#da4453"`. But I see other icons have something like 
`style="fill:currentColor"`. Can anyone tell me correct way of applying colors?
  
  
  Just `fill="currentColor"` is correct.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531347 , @guoyunhe wrote:
  
  > @ndavis it looks strange when I removed the inline style
  >
  >   {F7351830}
  
  
  The inline style needs to be included, how it is now.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  Then it's fine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531330 , @ngraham wrote:
  
  > Shouldn't the checkmark be green?
  
  
  FWIW, both should be black/white. Disabling is not a destructive action like 
removing.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added a comment.


  +1
  Next time please also add VDG as a subsriber and reviewer if there is a UI 
related change :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg
Cc: GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, 
feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, 
navarromorales, firef, ngraham, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added reviewers: Frameworks, VDG.
GB_2 added a project: VDG.
GB_2 added subscribers: Frameworks, Dolphin, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg
Cc: #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, 
feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, 
navarromorales, firef, ngraham, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23879

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  This symlink was missing, so the desktop file was using the default icon.

TEST PLAN
  The Qt Designer now uses the Breeze icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23879

AFFECTED FILES
  icons-dark/apps/48/designer.svg
  icons/apps/48/designer.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23879

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D10362: Change reveal password button logic

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fb18347e4dea: Change reveal password button logic 
(authored by GB_2).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10362?vs=65592=65681

REVISION DETAIL
  https://phabricator.kde.org/D10362

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml

To: GB_2, #plasma, #vdg, ngraham, broulik, ndavis
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23782: Add "edit-none-border" icon

[Björn Feber]

GB_2 added a comment.


  In D23782#527672 , @ndavis wrote:
  
  > This is kind of more like a selection icon than a No Borders icon TBH. I'm 
not sure if this is really more accurate than `edit-none`.
  
  
  Yeah, maybe it's best if we just use that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23782

To: GB_2, #vdg, ndavis
Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, 
LeGast00n, GB_2, michaelh, bruns