D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim updated this revision to Diff 55475.
bonghyunkim added a comment.


  It's been about three weeks since I've uploaded last diff but haven't 
received any response since then. I've made another diff against the most 
recent commit of KDE/syntax-highlighting 
(508be5417e67dc697166e72bde49a1fbf59c23a8 
), 
but I doubt anything would have changed. I'm including the logs of outputs from 
compiling the project and running tests. Failure seems to start from Qt library 
but I'm not sure what's going on here.
  
  I'm running Ubuntu 18.04, cmake 3.13.4, Make 4.1, and QT 5.10.0.
  
  Log for compiling and overall tests: Link 

  Log for HTMLHighlighterTest Link 

  Log for TestHighlighterTest Link 

  Log for FoldingTest Link 


REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19438?vs=53736=55475

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  autotests/input/highlight.elm
  data/syntax/elm.xml

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim updated this revision to Diff 53736.
bonghyunkim added a comment.


  Sorry that I forgot to update the actual diff file - this should compile now!

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19438?vs=53180=53736

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  autotests/input/highlight.elm
  data/syntax/elm.xml

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim planned changes to this revision.
bonghyunkim added a comment.


  I finally got some time to install various dependencies to set up the tests 
and run them, but three tests keep failing. They are: folding_test, 
testhighlighter_test, htmlhighlighter_test.
  
  The error message is always same:
  
FAIL!  : HTMLHighlighterTest::testHighlight(highlight.elm) 
'ref.open(QIODevice::ReadOnly | QIODevice::Text)' returned FALSE. ()
   Loc: 
[/home/lambda/Documents/Projects/syntax-highlighting/autotests/test-config.h(65)]
  
  I tried giving all privileges through chmod 777, changing file name and 
extension to that of another language that already works, i.e. test.hs, and 
making the file an empty file by deleting all texts in it.
  None worked, and I couldn't google how to handle this error.
  
  I'm running Ubuntu 18.04, cmake 3.13.4, Make 4.1, and QT 5.10.0.
  
  Is there any further advice?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim updated this revision to Diff 53180.
bonghyunkim edited the summary of this revision.
bonghyunkim added a comment.


  I created 'highlight.elm' in autotests/input/ folder, as per guide on 
https://github.com/KDE/syntax-highlighting, but couldn't follow the instruction.
  I tried running make && make test, but the root folder didn't have Makefile, 
and when I ran it inside autotests/input/, it failed to run because of the 
missing Makefile.in.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19438?vs=52880=53180

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  autotests/input/highlight.elm
  data/syntax/elm.xml

To: bonghyunkim
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim planned changes to this revision.
bonghyunkim added a comment.


  In D19438#422676 , @dhaumann wrote:
  
  > Could you elaborate what Elm is used for?
  >  Also, could you please provide a small test file (also MIT licensed) that 
we can use for unit testing?
  
  
  I created 'highlight.elm' in autotests/input/ folder, as per guide on 
https://github.com/KDE/syntax-highlighting, but couldn't follow the instruction.
  I tried running make && make test, but the root folder didn't have Makefile, 
and when I ran it inside autotests/input/, it failed to run because of
  missing Makefile.in. What should I do next?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
bonghyunkim requested review of this revision.

REVISION SUMMARY
  This commit adds syntax definition for Elm language to syntax-highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  data/syntax/elm.xml

To: bonghyunkim
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann