D29049: add telephant icon
muesli accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH telephant (branched from master) REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D29049: add telephant icon
muesli added a comment. Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg' are intentional to match the appstream ID? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D24401: Use exposed DBus methods to switch activities in CLI
This revision was automatically updated to reflect the committed changes. Closed by commit R6:a1c973c01ece: Use exposed DBus methods to switch activities in CLI (authored by muesli). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24401?vs=67281=75776 REVISION DETAIL https://phabricator.kde.org/D24401 AFFECTED FILES src/cli/main.cpp src/lib/controller.cpp src/lib/controller.h To: muesli, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D24401: Use exposed DBus methods to switch activities in CLI
muesli added a comment. @ivan @ngraham Ok, with 5.18 out I think we can finally review this one :-) REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D24401: Use exposed DBus methods to switch activities in CLI
muesli added a comment. Actually I'm mistaken, we can't merge this just yet. We'll still need to wait for the Plasma 5.18 release. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24401: Use exposed DBus methods to switch activities in CLI
muesli added a comment. @ivan Do you think we can merge this now? REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24401: Use exposed DBus methods to switch activities in CLI
muesli added a comment. Careful: we must _not_ land this before the next Plasma release. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24401: Use exposed DBus methods to switch activities in CLI
muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. muesli requested review of this revision. REVISION SUMMARY Since https://phabricator.kde.org/D22381 has landed kactivitymanagerd now exposes methods to switch to the previous/next activity via DBus. We can call them from kactivities-cli and remove some duplicated code. REPOSITORY R6 KActivities BRANCH cli-nextprev-activity (branched from master) REVISION DETAIL https://phabricator.kde.org/D24401 AFFECTED FILES src/cli/main.cpp src/lib/controller.cpp src/lib/controller.h To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
This revision was automatically updated to reflect the committed changes. Closed by commit R6:c450f09e8921: Simplify previous-/nextActivity code in kactivities-cli (authored by muesli). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22370?vs=61499=61502 REVISION DETAIL https://phabricator.kde.org/D22370 AFFECTED FILES src/cli/main.cpp To: muesli, ivan, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
muesli added a reviewer: ivan. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D22370 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
muesli created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. muesli requested review of this revision. REVISION SUMMARY Removed unnecessary bool found and directly return from inner loop. REPOSITORY R6 KActivities BRANCH kactivities-cli-simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D22370 AFFECTED FILES src/cli/main.cpp To: muesli Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
