Re: CI system maintainability
Hi, > Hi, > > On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote: > >> Hello, >> >> On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: >> > I am against to force mandatory review, as it will create a lot of lose >> of >> > time, >> >> As I said, unpopular. >> > > I don't get why mandatory code reviews are so unpopular. > > I don't care if you lose time. I don't want the guys building my house to > cut corners mixing my concrete because it's going to save time. Why are you > in such a massive hurry to make changes to software which for example holds > access to my Google Account password? In fact, the very fact that you make > this argument makes me wonder if I'm running trustable code on my computer > at all, because apparently doing it quickly is far more important than > doing it right. > > As a user, I simply do not want unreviewed crap running on my computer. > Yes, crap, because no software engineer writes bug-free code all the time, > and if you're so overconfident that you don't need reviews on even your > one-liners, you're probably too overconfident to be writing good code > anyway, so I'm going to operate on the presumption that if the code hasn't > had more than one pair of eyeballs ever looking at it, it's crap. > > As a developer, I know that even one-liners, and especially one-liners, the > sort where you think "meh, this is a tiny little thing, I don't have to be > careful" are the ones that have the most dangerous typos and unintended > bugs. Reviews catch that. > > In a project like PIM, if the code hasn't been through review, which > independent party do I trust to verify that you're not, for example, > leaking my Google password to some world-readable tempfile? Do you really > expect every user to read the entire codebase for themselves and make sure > that's not being done? The whole point of having all the code out in the > open for independent audit purposes, to protect your security and privacy > and what not is completely moot if no one else actually looks at the code > anyway. And let's be honest, the code quality of some of KDE's projects - I > wouldn't touch them with a six-foot pole. The ones I would touch though, > all have multiple people looking at the code and reviewing everything that > goes in. > > Let me be very clear - even if you're the best damn programmer on the > planet, if *you* wrote the code, I do not trust *you* one inch to tell me > that that code is correct. That verification needs to come from someone > else, someone who does not have a conflict of interest in seeing that code > get into production. This is nothing personal, this is confirmation bias on > the author's part which leads to issues that even though they might be > infrequent, usually have catastrophic impact. > > And if "culture" trumps over engineering best practices, it follows that I > should just stop using software produced by this entity because who knows > what it's doing. Mandatory code reviews are nice, if you have the manpower. Look at our phabricator, look for example at the queue of reviews for KTextEditor. The team is small and the code is complex and old (not rocket-science, it is a text editor, but still...). I and others tried to get more reviews done in the past, but actually I merged more than once stuff that I reviewed but it did break the CI. In most cases I fixed it myself afterwards or reverted again, but a few times I needed to get ping'd by others that I was stupid, too. In the current case discussed an error happend, it could have happend exactly the same way if for example "me" would have reviewed it. A lot of the changes which are at the moment in the queue are stuck because a) lack of time to review the change b) lack of time to ever be able to test the change For any non-trivial behavior change (especially for features you not use yourself at all), any meaningful review is a full-time job. e.g. in our company you would let some student test the changed behavior some days. This is just not feasible for me, and yes, for some of these changes, rather than abandoning them (and trashing precious work others did), I will somewhen apply them with close to zero real testing. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!
Hi, this is very likely an evil Qt JS regression in 5.12.x, see https://bugreports.qt.io/browse/QTBUG-72879 Greetings Christoph - Am 7. Jan 2019 um 1:32 schrieb CI System nore...@kde.org: > BUILD UNSTABLE > Build URL [ > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/9/ > | > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/9/ > ] > Project: kf5-qt5 FreeBSDQt5.12 > Date of build:Sun, 06 Jan 2019 23:55:27 + > Build duration: 37 min and counting > JUnit Tests > Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), > Total: 61 test(s) > * Failed: projectroot.autotests.kateindenttest_testCppstyle > > Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), > Skipped: 0 > test(s), Total: 5 test(s) -- ----- Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!
Hi, > ;=( > > 5.12 breaks more scripting tests than just templatehandler_test, > have ATM no fix for the indentation stuff, thought. I spend a bit time debugging this, somehow some regex .exec's are regressed from 5.11 to 5.12: https://phabricator.kde.org/D17998 If somebody has insight if either the js code we have is borked or the Qt implementation of it, any help is appreciated, as I am neither a JS nor V4 engine guru ;=) > > Greetings > Christoph > > - Am 5. Jan 2019 um 20:02 schrieb CI System nore...@kde.org: > >> BUILD UNSTABLE >> Build URL[ >> https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/5/ >> | >> https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/5/ >> ] >> Project: kf5-qt5 FreeBSDQt5.12 >> Date of build: Sat, 05 Jan 2019 18:57:34 + >> Build duration: 5 min 4 sec and counting >> JUnit Tests >> Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), >> Total: 61 test(s) >> * Failed: projectroot.autotests.kateindenttest_testCppstyle >> >> Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), >> Skipped: 0 >> test(s), Total: 5 test(s) >> * Failed: projectroot.autotests.src.vimode.vimode_keys > > -- > - Dr.-Ing. Christoph Cullmann - > AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com > Science Park 1 Tel: +49-681-38360-22 > 66123 Saarbrücken Fax: +49-681-38360-20 > GERMANYWWW: http://www.AbsInt.com > ---- > Geschäftsführung: Dr.-Ing. Christian Ferdinand > Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!
;=( 5.12 breaks more scripting tests than just templatehandler_test, have ATM no fix for the indentation stuff, thought. Greetings Christoph - Am 5. Jan 2019 um 20:02 schrieb CI System nore...@kde.org: > BUILD UNSTABLE > Build URL [ > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/5/ > | > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/5/ > ] > Project: kf5-qt5 FreeBSDQt5.12 > Date of build:Sat, 05 Jan 2019 18:57:34 + > Build duration: 5 min 4 sec and counting > JUnit Tests > Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), > Total: 61 test(s) > * Failed: projectroot.autotests.kateindenttest_testCppstyle > > Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), > Skipped: 0 > test(s), Total: 5 test(s) > * Failed: projectroot.autotests.src.vimode.vimode_keys -- ----- Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!
Hi, if somebody has an idea, why this test case doesn't work with Qt 5.11 but works ok with Qt 5.9, any hints would be appreciated :( Greetings Christoph - Am 9. Dez 2018 um 15:22 schrieb CI System nore...@kde.org: > BUILD UNSTABLE > Build URL [ > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/4/ > | > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/4/ > ] > Project: kf5-qt5 SUSEQt5.11 > Date of build:Sun, 09 Dec 2018 14:09:15 + > Build duration: 12 min and counting > JUnit Tests > Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: > 1 > test(s) > Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), > Total: 61 test(s) > Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), > Skipped: 0 > test(s), Total: 5 test(s) > * Failed: projectroot.autotests.src.vimode.vimode_keys > > Cobertura Report Project Coverage Summary NamePackagesFiles > Classes Lines > Conditionals > Cobertura Coverage Report 79% (22/28) 88% (254/289) 88% (254/289) > 68% > (32944/48219) 51% (15832/30966) Coverage Breakdown by Package Name > Files > Classes Lines Conditionals > autotests.src 100% (37/37)100% (37/37)94% (4431/4730) > 49% (1696/3450) > autotests.src.vimode 100% (9/9) 100% (9/9) 99% (5483/5523) > 58% (996/1712) > src.buffer88% (15/17) 88% (15/17) 90% (1681/1863) 76% > (1195/1578) > src.completion100% (11/11)100% (11/11)57% (1772/3109) > 43% (1160/2717) > src.completion.expandingtree 100% (3/3) 100% (3/3) 40% (184/459) > 22% > (76/348) > src.dialogs 0% (0/4)0% (0/4)0% (0/732) 0% (0/176) > src.document 100% (4/4) 100% (4/4) 59% (1870/3165) 47% > (1565/3313) > src.export0% (0/4)0% (0/4)0% (0/119) 0% (0/162) > src.include.ktexteditor 93% (14/15) 93% (14/15) 91% (221/244) > 65% (146/226) > src.inputmode 100% (8/8) 100% (8/8) 63% (189/302) 51% > (39/77) > src.mode 83% (5/6) 83% (5/6) 41% (171/417) 40% (111/275) > src.part 0% (0/1)0% (0/1)0% (0/7)100% (0/0) > src.printing 0% (0/4)0% (0/4)0% (0/830) 0% (0/294) > src.render100% (7/7) 100% (7/7) 77% (953/1244) 67% (627/942) > src.schema29% (2/7) 29% (2/7) 1% (20/1492)1% (6/673) > src.script100% (16/16)100% (16/16)68% (731/1069) 58% (268/465) > src.search100% (6/6) 100% (6/6) 74% (1109/1498) 64% > (576/904) > src.spellcheck86% (6/7) 86% (6/7) 30% (374/1249) 28% > (216/778) > src.swapfile 50% (1/2) 50% (1/2) 32% (122/376) 31% (62/199) > src.syntax88% (7/8) 88% (7/8) 66% (478/729) 36% (204/572) > src.undo 100% (5/5) 100% (5/5) 88% (657/746) 73% (302/412) > src.utils 94% (32/34) 94% (32/34) 68% (2732/4005) 51% > (1351/2654) > src.variableeditor0% (0/5)0% (0/5)0% (0/580) 0% > (0/128) > src.view 88% (15/17) 88% (15/17) 56% (3670/6555) 42% > (1698/4010) > src.vimode100% (29/29)100% (29/29)81% (1894/2325) 60% > (1042/1751) > src.vimode.config 0% (0/1)0% (0/1)0% (0/124) 0% > (0/88) > src.vimode.emulatedcommandbar 100% (12/12) 100% (12/12)99% > (904/915) 91% > (617/678) > src.vimode.modes 100% (10/10)100% (10/10)87% (3298/3812) > 79% (1879/2384) -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: Regression in Frameworks - DBus Hangs
Hi, > Ping? >> > >> > Anyone got any idea why this behaviour has regressed? >> >> The complete lack of response to this issue (and any mail to this >> mailing list i've noticed, I highly suspect everyone just filters it >> into a corner in their mail client and doesn't read it at all) is >> really disappointing. >> >> Given that Kurt has disabled the test within Konsole this doesn't have >> any urgency anymore. >> >> None the less though the fact a regression with >> hang-on-application-close implications was detected by the CI system >> and then completely ignored by those who broke it brings up other >> concerns, and essentially means the CI system is given no regard by >> the Frameworks developers. >> >> As a consequence i'll be terminating CI and Phabricator notification >> mails to the Frameworks mailing list, effective immediately. I think that is a bit harsh. I assume nobody replied because nobody has an idea which commit it was (at least I have none). The mails are really useful, I am not sure that cutting them off will help. Greetings Christoph P.S. I appreciate all the work you put in the CI (and all other stuff you admin)! -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: QStandardPaths::GenericDataLocation on MacOS
t;I share stuff" way like on Linux. Actually all frameworks I patched use the QRC way on Linux nowadays, too, which IMHO has no real drawbacks and even avoids a lot of hassle during deployment for e.g. Windows (where a lot of small files do suck incredibly more than on Unices with a decent filesystem). Much harder is the issue of deploying all plugins/... that are bundled with the application in a app bundle, as e.g. stuff like my macqtdeploy patch to patch the kio plugins and co. just rot away in the qt bug tracker. https://bugreports.qt.io/browse/QTBUG-48836 Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 40 - Still Unstable!
Hi, has somebody an idea why that fails only on BSD? Problem with that particular Qt version? Greetings Christoph - Am 29. Jul 2017 um 5:03 schrieb no-re...@kde.org: > BUILD UNSTABLE > Build URL [ > https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/40/ > | > https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/40/ > ] > Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 > Date of build:Sat, 29 Jul 2017 02:42:13 + > Build duration: 20 min and counting > JUnit Tests > Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: > 66 test(s) > * Failed: TestSuite.bug205447 -- ----- Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
