Re: Review Request 122642: an include is not correct
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122642/ --- (Updated Oct. 21, 2016, 11:17 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kcoreaddons Description --- trying to compile frameworks/kservice/src/services/kserviceaction.cpp I get: /usr/local/include/KF5/KCoreAddons/kpluginfactory.h:25:10: fatal error: 'kcoreaddons_export.h' file not found fatal error: 'kcoreaddons_export.h' file not found#include "kcoreaddons_export.h" I propose to change it to #include Diffs - src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 Diff: https://git.reviewboard.kde.org/r/122642/diff/ Testing --- Thanks, Guy Maurel
Re: Review Request 123831: Coding Style for main.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123831/ --- (Updated June 30, 2015, 1 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit df5ffbdf5a9d940a61e4552603e6a19832285781 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - examples/helloworld/main.cpp 8ec882f Diff: https://git.reviewboard.kde.org/r/123831/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123830: Coding Style for main.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123830/ --- (Updated June 30, 2015, 1 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit df5ffbdf5a9d940a61e4552603e6a19832285781 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - examples/bzip2gzip/main.cpp 2cdcd6c Diff: https://git.reviewboard.kde.org/r/123830/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/ --- (Updated May 17, 2015, 4:03 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit c10e72b8b641a4777672bd35c0ba080b1b075fd2 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - src/k7zip.cpp edd1090234e34d669f42815c9d2c653291c0fd2a src/kar.cpp fb31185 src/karchive.cpp 1b3371b1479581eb1d83f8f245cf3b85677517d0 src/kbzip2filter.cpp 52acb76 src/kcompressiondevice.cpp 05d6859 src/kfilterdev.cpp dd9e6a3 src/kgzipfilter.cpp 160cff57d851820f92c99da6a2fe034ebdd4c8b5 src/klimitediodevice.cpp 66b9b3d src/knonefilter.cpp 055fab9 src/krcc.cpp cb8b2cca8262ed0986cc52d01c7b44d5662d1dd5 src/ktar.cpp 1386382939bb0f0e3a0b9b2b841b909a03ec6e85 src/kxzfilter.cpp 0e7ae09ccae30e179d63400de921c259e832cb2a src/kzip.cpp 4bbbcf5464a9e5aae305798201fda641e5b744f2 Diff: https://git.reviewboard.kde.org/r/123803/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123830: Coding Style for main.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123830/ --- Review request for KDE Frameworks, Mario Bensi and David Faure. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - examples/bzip2gzip/main.cpp 2cdcd6c Diff: https://git.reviewboard.kde.org/r/123830/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123831: Coding Style for main.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123831/ --- Review request for KDE Frameworks, Mario Bensi and David Faure. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - examples/helloworld/main.cpp 8ec882f Diff: https://git.reviewboard.kde.org/r/123831/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp
On May 15, 2015, 9:49 p.m., David Faure wrote: About your commit log: we won't have a different coding style for karchive, all frameworks should follow https://techbase.kde.org/Policies/Kdelibs_Coding_Style and https://techbase.kde.org/Policies/Library_Code_Policy About the diff: so this is the result of uncrustify, not astyle? Can you put the uncrustify script in kde-dev-scripts too? I found a problem with the two references you give: The first says: For pointers or references, use a single space before '*' or '', but not after The second: QString myMethod( const QString foo, which one is to follow? The diff I provided is a product of astyle with some more scripts (not provided by astyle). uncrustify provides much more diversity (500 options). Is more complicate. I am working on uncrustify to provide an uncrustiy script to follow the kdelibs. - Guy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/#review80430 --- On May 15, 2015, 6:17 p.m., Guy Maurel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/ --- (Updated May 15, 2015, 6:17 p.m.) Review request for KDE Frameworks, Mario Bensi and David Faure. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - src/k7zip.cpp edd1090234e34d669f42815c9d2c653291c0fd2a src/kar.cpp fb31185 src/karchive.cpp 1b3371b1479581eb1d83f8f245cf3b85677517d0 src/kbzip2filter.cpp 52acb76 src/kcompressiondevice.cpp 05d6859 src/kfilterdev.cpp dd9e6a3 src/kgzipfilter.cpp 160cff57d851820f92c99da6a2fe034ebdd4c8b5 src/klimitediodevice.cpp 66b9b3d src/knonefilter.cpp 055fab9 src/krcc.cpp cb8b2cca8262ed0986cc52d01c7b44d5662d1dd5 src/ktar.cpp 1386382939bb0f0e3a0b9b2b841b909a03ec6e85 src/kxzfilter.cpp 0e7ae09ccae30e179d63400de921c259e832cb2a src/kzip.cpp 4bbbcf5464a9e5aae305798201fda641e5b744f2 Diff: https://git.reviewboard.kde.org/r/123803/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h kcompressiondevice.h kfilterbase.h kfilterdev.h klimitediodevice_p.h kxzfilter.h kzip.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123439/ --- (Updated May 15, 2015, 4:05 p.m.) Status -- This change has been marked as submitted. Review request for Akonadi, KDE Frameworks, Mario Bensi, and David Faure. Changes --- Submitted with commit 5b895eba62517c69020736276dd35c4ac96bb957 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - src/karchive_p.h 26a98659b860b379f28ee9442df7a0dd5209f89d src/kbzip2filter.h 767dabe src/kcompressiondevice.h 9e0c2c0f04ac9f4401e9f1a8c2a0b71f3ef327ed src/kfilterbase.h 9cbaf950ce42878d426b358582c3b62a1ded9aaf src/klimitediodevice_p.h 51929aa src/kxzfilter.h 8747a29 src/kzip.h 11ca330 Diff: https://git.reviewboard.kde.org/r/123439/diff/ Testing --- Could anybody take care of this review after 30 days? Thanks. Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp kxz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/ --- Review request for KDE Frameworks, Mario Bensi and David Faure. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - src/k7zip.cpp edd1090234e34d669f42815c9d2c653291c0fd2a src/kar.cpp fb31185 src/karchive.cpp 1b3371b1479581eb1d83f8f245cf3b85677517d0 src/kbzip2filter.cpp 52acb76 src/kcompressiondevice.cpp 05d6859 src/kfilterdev.cpp dd9e6a3 src/kgzipfilter.cpp 160cff57d851820f92c99da6a2fe034ebdd4c8b5 src/klimitediodevice.cpp 66b9b3d src/knonefilter.cpp 055fab9 src/krcc.cpp cb8b2cca8262ed0986cc52d01c7b44d5662d1dd5 src/ktar.cpp 1386382939bb0f0e3a0b9b2b841b909a03ec6e85 src/kxzfilter.cpp 0e7ae09ccae30e179d63400de921c259e832cb2a src/kzip.cpp 4bbbcf5464a9e5aae305798201fda641e5b744f2 Diff: https://git.reviewboard.kde.org/r/123803/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h kcompressiondevice.h kfilterbase.h kfilterdev.h klimitediodevice_p.h kxzfilter.h kzip.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123439/ --- (Updated May 14, 2015, 1:08 a.m.) Review request for Akonadi, KDE Frameworks, Mario Bensi, and David Faure. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http://techbase.kde.org/Policies/Kdepim_Coding_Style If wished, we could have extra policy for karchive. (Let me know) Diffs - src/karchive_p.h 26a98659b860b379f28ee9442df7a0dd5209f89d src/kbzip2filter.h 767dabe src/kcompressiondevice.h 9e0c2c0f04ac9f4401e9f1a8c2a0b71f3ef327ed src/kfilterbase.h 9cbaf950ce42878d426b358582c3b62a1ded9aaf src/klimitediodevice_p.h 51929aa src/kxzfilter.h 8747a29 src/kzip.h 11ca330 Diff: https://git.reviewboard.kde.org/r/123439/diff/ Testing --- Could anybody take care of this review after 30 days? Thanks. Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123419: CodingStyle for autotests
On April 18, 2015, 10:04 p.m., David Faure wrote: Looks ok but it's strange to quote a wiki page called *kdepim*. This isn't kdepim. You are right. I continue the work I do for kdepim. Where should I put the informations? - Guy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/#review79179 --- On April 19, 2015, 4:52 p.m., Guy Maurel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/ --- (Updated April 19, 2015, 4:52 p.m.) Review request for KDE Frameworks, Mario Bensi and David Faure. Repository: karchive Description --- Details can be seen at: http://techbase.kde.org/Policies/Kdepim_Coding_Style Diffs - autotests/karchivetest.cpp 9e27ffcedbd8a6b62ee080238713580f2a81eb07 autotests/kfiltertest.cpp e0d9c57 autotests/klimitediodevicetest.h 6ec205f Diff: https://git.reviewboard.kde.org/r/123419/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123419: CodingStyle for autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/ --- (Updated April 19, 2015, 2:52 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit b8f25b58e7dbf641fbe5e16c2982566c6729e9de by Guy Maurel to branch master. Repository: karchive Description --- Details can be seen at: http://techbase.kde.org/Policies/Kdepim_Coding_Style Diffs - autotests/karchivetest.cpp 9e27ffcedbd8a6b62ee080238713580f2a81eb07 autotests/kfiltertest.cpp e0d9c57 autotests/klimitediodevicetest.h 6ec205f Diff: https://git.reviewboard.kde.org/r/123419/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123419: CodingStyle for autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/ --- Review request for KDE Frameworks, Mario Bensi and David Faure. Repository: karchive Description --- Details can be seen at: http://techbase.kde.org/Policies/Kdepim_Coding_Style Diffs - autotests/karchivetest.cpp 9e27ffcedbd8a6b62ee080238713580f2a81eb07 autotests/kfiltertest.cpp e0d9c57 autotests/klimitediodevicetest.h 6ec205f Diff: https://git.reviewboard.kde.org/r/123419/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122642: an include is not correct
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122642/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description --- trying to compile frameworks/kservice/src/services/kserviceaction.cpp I get: /usr/local/include/KF5/KCoreAddons/kpluginfactory.h:25:10: fatal error: 'kcoreaddons_export.h' file not found fatal error: 'kcoreaddons_export.h' file not found#include kcoreaddons_export.h I propose to change it to #include kcoreaddons_export.h Diffs - src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 Diff: https://git.reviewboard.kde.org/r/122642/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
---
(Updated Feb. 16, 2015, 6:29 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and
Thiago Macieira.
Repository: kconfig
Description
---
The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.
I propose to use:
QString plus = QLatin1String(/);
QString dirPlus;
...
Q_FOREACH (...) {
dirPlus = dir;
dirPlus.append(plus);
if (path.startsWith(dirPlus)) {
Diffs
-
src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509
Diff: https://git.reviewboard.kde.org/r/122445/diff/
Testing
---
Thanks,
Guy Maurel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly
On Feb. 12, 2015, 11:49 p.m., Albert Astals Cid wrote:
Guy: ping?
pong! I was on the road until today
- Guy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/#review75949
---
On Feb. 5, 2015, 7:36 p.m., Guy Maurel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
---
(Updated Feb. 5, 2015, 7:36 p.m.)
Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and
Thiago Macieira.
Repository: kconfig
Description
---
The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.
I propose to use:
QString plus = QLatin1String(/);
QString dirPlus;
...
Q_FOREACH (...) {
dirPlus = dir;
dirPlus.append(plus);
if (path.startsWith(dirPlus)) {
Diffs
-
src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509
Diff: https://git.reviewboard.kde.org/r/122445/diff/
Testing
---
Thanks,
Guy Maurel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
---
Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and
Thiago Macieira.
Repository: kconfig
Description
---
The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.
I propose to use:
QString plus = QLatin1String(/);
QString dirPlus;
...
Q_FOREACH (...) {
dirPlus = dir;
dirPlus.append(plus);
if (path.startsWith(dirPlus)) {
Diffs
-
src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509
Diff: https://git.reviewboard.kde.org/r/122445/diff/
Testing
---
Thanks,
Guy Maurel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
a problem with kdesktopfile.cpp
Hello!
I wonder about the code of kdesktopfile.cpp at line 80:
...
QString KDesktopFile::locateLocal(const QString path)
{
QString relativePath;
// Relative to config? (e.g. for autostart)
Q_FOREACH (const QString dir,
QStandardPaths::standardLocations(QStandardPaths::GenericConfigLocation)) {
if (path.startsWith(dir) + '/') {
because path.startsWith(dir) returns bool and '/' is a character.
HOW can be the + be made and what is the type of the result?
...
relativePath = dir.mid(path.length() + 1);
relativePath is sometimes mysterious:
(gdb) printqs5static path
(Qt5 QString)0xbcb8 length=17: kdevninja.desktop
(gdb) printqs5static dir
(Qt5 QString)0x26be3f8 length=21: /home/guy-kde/.config
(gdb) printqs5static relativePath
(Qt5 QString)0xbc40 length=3: fig
Can anybody help?
--
Guy Maurel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
