D27632: Implement UString operator= to make gcc happy

2020-04-11 Thread Harri Porten
porten accepted this revision.
porten added a comment.
This revision is now accepted and ready to land.


  I now see that the member is kept as a RefPtr. Unlike the previously used raw 
pointer I now understand why the the assignment operator can be implemented 
that simple.
  
  For completness: the gcc switch that triggers the warning is -Wdeprecated-copy

REPOSITORY
  R314 KJs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27632

To: aacid, porten
Cc: porten, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28726: [KJS] Port QRegExp to QRegularExpression

2020-04-11 Thread Harri Porten
porten accepted this revision.

REPOSITORY
  R314 KJs

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28726

To: ahmadsamir, #frameworks, porten, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27632: Implement UString operator= to make gcc happy

2020-02-24 Thread Harri Porten
porten added a comment.


  On first sight I don't get how the class' memory management works these days. 
Before commenting on the patch I have to refresh my knowledge.

REPOSITORY
  R314 KJs

REVISION DETAIL
  https://phabricator.kde.org/D27632

To: aacid
Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns