D23685: Make user-trash icons look like trashcans

[Hazem Salem]

Codezela added a comment.


  I think they looks different
  The shadow on the empty one make it looks very flat
  Or maybe squashed
  The full state looks better

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23685

To: ndavis, #vdg, ngraham
Cc: Codezela, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23650: Add an icon for the trash root and a proper label

[Hazem Salem]

Codezela added a comment.


  Why trash icon don't look like trash
  Like any other os

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23650

To: meven, ngraham, #frameworks, broulik
Cc: Codezela, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D20367: Add alternatives icon

[Hazem Salem]

Codezela added a comment.


  I think in small size it will be difficult to recognize this icon because it 
has a lot of datils
  we need to use more simple version of it
  I found this on the web as example of what I mean
  we can review them as a base
  https://pngtree.com/free-icon/replace_784228

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20367

To: GB_2, #vdg, ngraham
Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Hazem Salem]

Codezela added a comment.


  another option we put the delete button only
  and align it to the corner of the thumbnail
  make it circle button
  and ditch the other one
  no need for it here
  what do u think

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Hazem Salem]

Codezela added a comment.


  how about make it global under
  beside add image button aligned left
  tow buttons disablef by default

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Hazem Salem]

Codezela added a comment.


  can i talk about other thing
  why the vlise button have this circle around it
  i think it will look cleaner with simple border strock or with only the close 
red circle

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

[Hazem Salem]

Codezela added a comment.


  can we change enter different name to just rename
  for simplicity

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin
Cc: Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

[Hazem Salem]

Codezela added a comment.


  In D15739#356310 , @ndavis wrote:
  
  > In D15739#356309 , @Codezela 
wrote:
  >
  > > i know that the icons size is adjustable i mean make the default more 
bigger first time u run dolphin this icons is so small "out of the box 
experience"
  > >  the other thing  i mean we may keep the root partion icon on the devices 
sections and make it fixed position above all other mounted drives so even any 
hd mounted the root icons still top
  > >  i hope i explain well
  > >  sorry i know my English is not so good
  >
  >
  > It's ok, I understand now. Those seem like good ideas.
  
  
  sorry but i added some picture after
  
  do u see this is my places section
  F6398445: Screenshot_20181108_203553.png 

  can u tell me where is my root
  and the phone icon is on top

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Hazem Salem]

Codezela added a comment.


  In D15739#356269 , @ndavis wrote:
  
  > In D15739#356026 , @Codezela 
wrote:
  >
  > > maybe there is 2 alternatives
  > >
  > > 1. remove the icon from devices section and keep it in places section 
with some icon change in the top one
  >
  >
  > You mean hide the root partition from Devices and keep the Root Places 
bookmark? That's what I currently do. I hide my `/` and `/home` partitions and 
use Places to get to those directories.
  >
  > > 2. keep it in the places section but change the label to root or system 
and it will always be top of all other hd with the lock emblem in it and remove 
the places one and we need to make the icons little bigger in this  side bar 
what do you think or i come oo late
  >
  > This confuses me. You say to keep it in Places, but remove it from Places? 
Keep what above other hard drives?
  >
  > BTW, the sidebar icons do have adjustable sizes. Perhaps it should be 
easier to find, but if you right click in an area without something selectable 
(e.g., a section label), you can go to "Icon Size" and change the size to 16, 
22, 32 or 48 px.
  
  
  i know that the icons size is adjustable i mean make the default more bigger 
first time u run dolphin this icons is so small "out of the box experience"
  the other thing  i mean we may keep the root partion icon on the devices 
sections and make it fixed position above all other mounted drives so even any 
hd mounted the root icons still top
  i hope i explain well
  sorry i know my English is not so good

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Hazem Salem]

Codezela added a comment.


  there is 2 alternatives
  
  1. remove the icon from devices section and keep it in places section with 
some icon change in the top one
  2. keep it in the places section but change the label to root or system and 
it will always be top of all other hd
  
  with the lock emblem in it and remove the places one

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham