Re: KDE Frameworks 6.0.0 tars

[Ismael Asensio]

Hi Jonathan,

We would also need a respin for KNewStuff to add this bugfix:
https://invent.kde.org/frameworks/knewstuff/-/merge_requests/294

With the commit:
https://invent.kde.org/frameworks/knewstuff/-/commit/a6a02162cd2c71fb986aadc77f3ce3cd32da7837

Thanks!


El lun, 26 feb 2024 a las 20:02,  escribió:

> On 2024-02-22 18:46, Jonathan Riddell wrote:
> > kstatusnotifieritem respin up
> >
> http://embra.edinburghlinux.co.uk/~jr/tmp/kstatusnotifieritem-6.0.0-changes_report.html
> >
> > > href="
> http://download.kde.org/stable/frameworks/6.0/kstatusnotifieritem-6.0.0.tar.xz
> ">kstatusnotifieritem-6.0.0
> >46kB
> > -
> >
> f64d46c340f455fb3354d41ed73c23766e0256943de3a316fbc56c3b51020095
> > +
> >
> b426176d2cbc6fe80c758b6c476a47341d89a92cbb3355c2be37428a41772907
>
> Hi,
>
> could we respin the kfilemetadata and baloo tars for:
>
> https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/129
>
> https://invent.kde.org/frameworks/baloo/-/merge_requests/188
>
> Greetings
> Christoph
>

D29198: filenamesearch:/ define a title for the query

[Ismael Asensio]

iasensio accepted this revision.
iasensio added a comment.


  Sorry I missed the ping.
  Along with D29197 , it looks nice to me.

INLINE COMMENTS

> dolphinsearchbox.cpp:479
> +return i18nc("@title UDS_DISPLAY_NAME for a KIO directory listing. %1 is 
> the query the user entered.",
> + "Query Results from '%1'", text);
> +}

Please, align the two strings

> elvisangelaccio wrote in dolphinsearchbox.h:164
> Please drop the `get` prefix.

I'd move this line up to separate private methods from private member variables

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D29198_1

REVISION DETAIL
  https://phabricator.kde.org/D29198

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D28457: kdirwatch: fix a recently introduced crash

[Ismael Asensio]

iasensio accepted this revision.
iasensio added a comment.
This revision is now accepted and ready to land.


  Thanks! It fixes `BUG: 419428`

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28457

To: meven, bruns, #frameworks, iasensio
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28349: Fix Warnings

[Ismael Asensio]

iasensio added a comment.


  In D28349#638395 , @bruns wrote:
  
  > @iasensio - are you using NFS?
  
  
  It's a NTFS partition using `fuseblk`, but anyway D28457 
 fixes the crash

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28349

To: meven, #frameworks, davidedmundson
Cc: bruns, iasensio, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham

D28349: Fix Warnings

[Ismael Asensio]

iasensio added a comment.


  I seemed to reach the unreachable when I tried to open an external HDD on 
dolphin:
  https://bugs.kde.org/show_bug.cgi?id=419428
  
  `ASSERT failure in Q_UNREACHABLE(): "Q_UNREACHABLE was reached", file 
/home/isma/kde/src/kcoreaddons/src/lib/io/kdirwatch.cpp, line 956`

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28349

To: meven, #frameworks, davidedmundson
Cc: iasensio, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

[Ismael Asensio]

iasensio added a dependent revision: D28152: [RFC] KWinRules KCM Redesign.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D28197

To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

[Ismael Asensio]

iasensio accepted this revision.
iasensio added a comment.


  It's working nicely, thanks!

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D28197

To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

[Ismael Asensio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:1a838e468d05: Expose capture signal on KeySequenceItem 
(authored by iasensio).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27795?vs=76808=76810

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

[Ismael Asensio]

iasensio updated this revision to Diff 76808.
iasensio marked an inline comment as done.
iasensio added a comment.


  Add API comment

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27795?vs=76807=76808

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

[Ismael Asensio]

iasensio created this revision.
iasensio added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Expose the signal `captureFinished` from the private helper to 
`KeySequenceItem`.
  Currently, if we set `keySequence` from a model and use 
`onKeySequenceChanged` to
  update that model, a binding loop happens. Using `onCaptureFinished` prevents 
that.

TEST PLAN
keySequence: modelData
onCaptureFinished: { modelData = keySequence }

REPOSITORY
  R296 KDeclarative

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ismael Asensio]

iasensio added a comment.


  Hi! This change fails to build for me, and also in CI  
(https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/console)
  
kcoredirlister_p.h:148:37: error: field 'lstFilters' has incomplete type 
'QVector'
09:29:39148 | QVector lstFilters;
  
  I just needed to `#include ` to fix it

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: iasensio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:34e682a1c0ed: Move URL parsing methods from kioslave to 
query object (authored by iasensio).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24433?vs=71523=71531

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven, ngraham, astippich, bruns
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio updated this revision to Diff 71523.
iasensio marked 5 inline comments as done.
iasensio added a comment.


  - Use return statements

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24433?vs=69836=71523

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven, ngraham, astippich, bruns
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4bb4195a6fc6: xattr: fix crash on dangling symlinks 
(authored by iasensio).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70035=71397

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio added a comment.


  Ping?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio added inline comments.

INLINE COMMENTS

> bruns wrote in usermetadatawritertest.cpp:44
> You can just use the static overload and provide an invalid target name.
> https://doc.qt.io/qt-5/qfile.html#link-1

You are right. I tried that with an empty string and it didn't work, but it 
does with a non-existent filename.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio updated this revision to Diff 70035.
iasensio marked an inline comment as done.
iasensio added a comment.


  - Simplify symlink creation

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70031=70035

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio edited the test plan for this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio updated this revision to Diff 70031.
iasensio added a comment.


  - Use temporal symlink

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70029=70031

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio updated this revision to Diff 70029.
iasensio marked 2 inline comments as done.
iasensio added a comment.


  - Protect from size < 0
  - Add test case for dangling symlink

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70019=70029

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/samplefiles/dangling_symlink
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio created this revision.
iasensio added a reviewer: astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  When requesting metadata on a dangling symlink, the framestack ends up 
calling `k_queryAttributes` with the symlink path.
  There, the `listxattr` syscall returns `size=-1` and `errno=ENOENT` (2 No 
such file or directory), which was not covered before, and provoking a segfault 
on `QByteArray`. Full traceback on: https://bugs.kde.org/show_bug.cgi?id=414227
  
  It might be also a good idea to protect the function in any other cases where 
`size=-1`
  
  BUG: 414227

TEST PLAN
  On dolphin, with panel information open, hover over a dangling symlink

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  src/xattr_p.h

To: iasensio, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio added inline comments.

INLINE COMMENTS

> bruns wrote in kio_search.cpp:88
> @broulik - why `endsWith()`?

should I just change the comparisons to `path == ...`, just like the 
`/documents` one?

REPOSITORY
  R293 Baloo

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio updated this revision to Diff 69836.
iasensio added a comment.


  Remove extra spaces

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24433?vs=69613=69836

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio updated this revision to Diff 69613.
iasensio marked 2 inline comments as done.
iasensio added a comment.


  Simplify helper function

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24433?vs=67361=69613

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven, ngraham, astippich
Cc: bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio removed a dependent revision: D25130: [dolphin/search] Search by 
(multiple) tags.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio added a dependent revision: D25130: [dolphin/search] Search by 
(multiple) tags.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio added a comment.


  Friday ping 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio created this revision.
iasensio added reviewers: Baloo, meven.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  This allows for query objects generated from `Baloo::Query::fromSearchUrl` to 
use the same URLs parsing as those using the kioslave. 
  Previously, only query urls with `json` format were available, while the 
kioslave could also parse the `query` keyword and simple type urls (e.g. 
`baloosearch://videos`)
  This was preventing the file type to be updated for places panels' default 
search urls (e.g. `baloosearch://videos`)

TEST PLAN
  - Open dolphin searchbar and activate "More Options"
  - Type `baloosearch://images`
  - The type 'Images' gets selected

REPOSITORY
  R293 Baloo

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio added a comment.


  Friendly ping

REPOSITORY
  R292 KUnitConversion

BRANCH
  log_power_units

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio marked an inline comment as done.
iasensio added a comment.


  Well, in my field of work (telephony, radar and radio signal transmission) it 
makes totally sense (altought Terawatts would be major words ). It is a non 
trivial conversion that we make quite frequently.
  
  If the question is between dBm and dBW as a common unit, I would go for dBm 
with no doubt. In my experience dBm is widely more used that its counterpart 
dBW. Also, as a quick and dirty comparison, one can check the difference in 
length and quality of those two articles: https://en.wikipedia.org/wiki/DBm and 
https://en.wikipedia.org/wiki/Decibel_watt.
  
  If it is wether decibel power units are common globally, I would say (knowing 
that I have a field bias) that at least as important as horsepower on a 
different field. 
  Of course, I will gently (and happily) accept your decision. Just wanted to 
provide some context.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio updated this revision to Diff 63588.
iasensio added a comment.


  - Set frameworks version

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23103?vs=63575=63588

BRANCH
  log_power_units

REVISION DETAIL
  https://phabricator.kde.org/D23103

AFFECTED FILES
  src/power.cpp
  src/unit.h

To: iasensio, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio added a reviewer: broulik.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio edited the test plan for this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Add decibel power units (dBW and mulitples)
  
  Decibel power units are widely used in the fields of signal trasnmission and 
radiofrequency. 
  This patch adds decibel units to the Power category (dBm, dbW, dBµW and dBk).
  
  The decibel calculation might be also interesting to other categories such as 
voltage or pressure (acoustics)

TEST PLAN
  - Check the units of the power category on krunner
  - The reference unit: 1W = 0dBW = 30dBm = 60dBµW = -30dBk
  - The decibel is a logarithmic scale so multiplying on natural units implies 
addition in decibel units:
  
  10W = 10dBW = 40dBm = 70dBµW = -20dBk

REPOSITORY
  R292 KUnitConversion

BRANCH
  log_power_units

REVISION DETAIL
  https://phabricator.kde.org/D23103

AFFECTED FILES
  src/power.cpp
  src/unit.h

To: iasensio
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns