Re: Rollout of Gitlab CI

[Laurent Montel]

On jeudi 30 septembre 2021 08:40:04 CEST Ben Cooksley wrote:
> On Thu, Sep 30, 2021 at 7:10 PM Laurent Montel  wrote:
> > Hi,
> 
> Hi Laurent,
> 
> I added in .kde-ci.yml
> 
> > 'kde/pim/akonadi-contacts': '@latest'
> > 'frameworks/kcontacts': '@stable'
> > 
> > for kgpg and it doesn’t find akonadi-contacts. Do you have an idea ?
> > What I missed ?
> > “https://invent.kde.org/utilities/kgpg/-/jobs/134772/raw”
> 
> As mentioned in my email, this is only available for projects that depend
> only on KDE Frameworks at the moment.
Ah ? I didn’t see this line :( too bad.

> 
> KGpg does not meet this criteria as it depends on akonadi-contacts - which
> is in KDE PIM / Release Service, not Frameworks.

For sure.
I will comment .kde-ci.yml for the moment.

> 
> > Regards
> 
> Cheers,
> Ben
> 
> > On mercredi 29 septembre 2021 11:27:08 CEST Ben Cooksley wrote:
> > > Hi all,
> > 
> > --
> > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software
> > Engineer
> > KDAB (France) S.A.S., a KDAB Group company
> > Tel: France +33 (0)4 90 84 08 53, http://www.kdab.fr
> > KDAB - The Qt, C++ and OpenGL Experts


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company
Tel: France +33 (0)4 90 84 08 53, http://www.kdab.fr
KDAB - The Qt, C++ and OpenGL Experts

Re: Rollout of Gitlab CI

[Laurent Montel]

Hi,
I added in .kde-ci.yml
'kde/pim/akonadi-contacts': '@latest'
'frameworks/kcontacts': '@stable'

for kgpg and it doesn’t find akonadi-contacts. Do you have an idea ?
What I missed ?
“https://invent.kde.org/utilities/kgpg/-/jobs/134772/raw”

Regards

On mercredi 29 septembre 2021 11:27:08 CEST Ben Cooksley wrote:
> Hi all,

-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company
Tel: France +33 (0)4 90 84 08 53, http://www.kdab.fr
KDAB - The Qt, C++ and OpenGL Experts

D28967: [KRichTextEditor] Add support for headings

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28967

To: poboiko, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28967: [KRichTextEditor] Add support for headings

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krichtexteditorui.rc:2
>  
>  
>  

increase version. => 14

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D28967

To: poboiko, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> poboiko wrote in krichtextedit.cpp:346
> Yes, that's true. I agree it's a bit confusing, but that's the case with HTML 
> too, which I had in mind (see screenshot, it's Chrome)
> F8241667: scr1.png 
> 
> For markdown, it seems like there are only 5 levels, 5th having the same size 
> as normal text (6th level gets ignored, that's Okular)
> F8241670: scr2.png 
> 
> I guess we probably can follow the Markdown way and bound it with 5, just to 
> avoid confusion.

But if you insert html text from html with title6 how it will work if it just 
supports h5 ?

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: abstractdevelop, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80344.
mlaurent added a comment.


  Use m_menu->addActions(m_dropActions);

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80182=80344

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure, apol
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:48f60533b922: [plasma-framework] make it compiles without 
foreach (authored by mlaurent).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80344=80345

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure, apol
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R310 KTextWidgets

BRANCH
  textwidget-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  Can you improve autotest KRichTextEditTest ?

INLINE COMMENTS

> krichtextedit.cpp:346
> +// level=2 look the same
> +int sizeAdjustment = boundedLevel > 0 ? 5 - boundedLevel: 0;
> +

const int

> krichtextedit.h:351
> + *
> + * @since FIXME
> + */

since @5.70

> krichtextwidget.cpp:499
> +d->action_heading_level = new KSelectAction(i18nc("@title:menu", 
> "Heading Level"), this);
> +QStringList listStyles = {i18nc("@item:inmenu no heading",   
>   "Basic text"),
> +  i18nc("@item:inmenu heading level 1 
> (largest)",  "Title"),

const QStringList

> krichtextwidget.h:233
> + *
> + * @since FIXME
> + */

@since 5.70

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80182.
mlaurent added a comment.


  Fix comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80170=80182

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent retitled this revision from "[plasma-desktop] make it compiles without 
foreach" to "[plasma-framework] make it compiles without foreach".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80170.
mlaurent added a comment.


  Fix David comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80169=80170

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80169.
mlaurent added a comment.


  Port last element to for(...:...)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80168=80169

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80168.
mlaurent added a comment.


  Rebase against master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=55796=80168

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D25660: Decouple KBookmarksMenu from KActionCollection

[Laurent Montel]

mlaurent added a comment.


  In D25660#635693 , @dfaure wrote:
  
  > @mlaurent AFAICS you removed the deprecation macro completely in master, 
and left it (with 0x06) in release/20.04?
  
  
  nope or I missed to forward port in 20.04. So it's an error.
  but by default There is not some 0x06 in 20.04

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25660

To: nicolasfella, #frameworks, dfaure
Cc: mlaurent, bcooksley, kossebau, dfaure, apol, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

[laurent Montel]

Le lundi 16 mars 2020, 15:43:29 CET Friedrich W. H. Kossebau a écrit :
> Am Montag, 16. März 2020, 10:39:39 CET schrieb Ben Cooksley:
> > On Mon, Mar 16, 2020 at 10:24 PM David Edmundson
> > 
> >  wrote:
> > > There is not a SIC. KIO is fine
> > > 
> > > It's merely this crap again:
> > > 
> > > if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
> > > 
> > >add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06)
> > >add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06)
> > > 
> > > endif()
> > 
> > May I suggest that we tweak this macro so that passing 0x06 makes
> > it no-op and fail open (disabling nothing)?

Hi,

> We could only tweak the macros handling K*_DISABLE_DEPRECATED_BEFORE_AND_AT,
> though those are complicated enough and this would also just be a
> work-around for a usage currently not favoured by many (it will be wanted
> at KF6 preparation/porting times though).
> 
> Instead we should finally create the policy everywhere to use
> QT_DISABLE_DEPRECATED_BEFORE & KF_DISABLE_DEPRECATED_BEFORE_AND_AT only with
> numbers of released versions that have been checked against. And not use
> those with version numbers of the future to trigger failing builds for
> developers once further API in use is deprecated, to force people into
> working on usage of deprecated API instantly.
> 
> Some thought doing 0x06 would be still acceptable with master branches.
> Though this would need active avoiding to have this setup on creating new
> stable branches being copied into those. Which seems not cared for though.
> And myself I am among the people who think also for master being forced into
> deprecated API work is overdoing - it is good to do things as early as
> possible, to "flatten the curve" of Qt6/KF6 porting work. But that is what
> warnings are for.
> 
> Laurent,
> could you do the favour to change all the usages of
> *DISABLE_DEPRECATED_BEFORE_AND_AT you introduced to a version matching to
> the latest released version you are sure works fine? (or organize such a
> change by people working on those repos). And this should be done for
> stable as well (sadly 20.04 was just branched :/ ).
> The "if (EXISTS "${CMAKE_SOURCE_DIR}/.git")" should be removed as well then,
> no longer being needed, and to also ensure released tarballs are built with
> same flags as developer builds (might e.g. affect overloaded methods).

I vote indeed for removing all theses lines in CmakeLists.txt, as it's the 
method used at the moment for fixing compile error.

I liked the Volker's work about deprecated method, he ported all code before 
to deprecate API. It was a good method as he knew how to port code, so he 
ported and after deprecated.

For other devs they deprecated API but no port KDE code and didn't write info 
how to port it, and it's too sad because for sure we will port this code later 
perhaps when we will port to Qt6, all this port will we do quickly perhaps 
with bugs (ok I already made some errors but I make the porting on several 
release so we can see problem on a long time.).

As Friedrich wrote the people/maintainer will port code when they will see 
compile warning, I will trust him but when I look at git commit I don't see a 
lot of commit about it, but I see some commit which removed this 
DISABLE_DEPRECATED_BEFORE_AND_AT macro.

Ok before when we increased kf5 or qt version sometimes it didn't build so the 
solution was to fixing 1 compile error or two, sometime no very hard to fix, 
without theses macros we will accumulate a lot of compile warning and it will 
harder to port at the end when we will migrate at qt6, and not sure that we 
will have more dev at this moment.



To conclude I will remove theses lines in all modules (but in pim* and some 
apps as I maintains them) and "wait and see" how devs will make porting.

Regards 

> 
> Yes, this will break your personal workflow of your deprecated API usage
> work (which IMHO is very valuable, sadly of the kind nobody will really
> notice due to Qt6/KF6 porting life being easier for them without knowing
> how bad it would have been, you will stay an unsung hero).
> I have no simple idea yet how to enable a similar approach yet again.
> Passing "-Werror=deprecated-declarations" to the build configurations via
> env vars is not targeted only at Qt & KF, so might have undesired
> sideeffects.
> 
> Cheers
> Friedrich


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Laurent Montel]

mlaurent added a comment.


  Did you test to compile with flags == 5.68.0 ?
  I tested it with kdepim and I need to adapt it.
  -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Laurent Montel]

mlaurent added a comment.


  "/compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:582:63: erreur: 
impossible de convertir « KIO::StatJob::DestinationSide » de « 
KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »}
  
582 |  KIO::StatJob* statJob = KIO::stat(url, 
KIO::StatJob::DestinationSide, 0);
| 
~~^~~
|   |
|   
KIO::StatJob::StatSide
  
  /compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp: Dans la fonction 
membre « void Game::loadGame() »:
  /compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:627:60: erreur: 
impossible de convertir « KIO::StatJob::SourceSide » de « 
KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »}
  
627 |   KIO::StatJob* statJob = KIO::stat(url, 
KIO::StatJob::SourceSide, 0);
|  ~~^~
||
|
KIO::StatJob::StatSide
  
  "
  
  compile is broken in several package see below.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  somefix

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Laurent Montel]

mlaurent added a comment.


  if splitting is already done why this code re-call 
"m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ?
  
  > QProcess::startDetached(commands, parts) no ?
  ===

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kserviceactioncomponent.cpp:72
>  } else {
> -
> QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"),
>  QString()), QStringList());
> +
> QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"),
>  QString()));
>  }

Hum... interesting:

#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"),
 QString()));
#else
const QString commandLine = 
m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString());
if (!commandLine.isEmpty()) {

  QStringList arguments = QProcess::splitCommand(commandLine);
  const QString prog = arguments.takeFirst();
  QProcess::startDetached(prog, arguments);

}   
#endif

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27591

To: alex, elvisangelaccio, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:c5863523f3aa: Port QLinkedList which is deprecated in 
qt5.15 (authored by mlaurent).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27459?vs=75830=75936

REVISION DETAIL
  https://phabricator.kde.org/D27459

AFFECTED FILES
  src/ktoolbarhandler.cpp

To: mlaurent, dfaure, apol
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27459: Port QLinkedList which is deprecated in qt5.15

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port QLinkedList (deprecated in qt5.15)

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

AFFECTED FILES
  src/ktoolbarhandler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27270: Use ecm_qt_install_logging_categories over manual categories files

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R174 KContacts

BRANCH
  generateqtlogcatfile

REVISION DETAIL
  https://phabricator.kde.org/D27270

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  In D27150#608491 , @kossebau wrote:
  
  > In D27150#608318 , @mlaurent 
wrote:
  >
  > > Yep you need to create a file name "foo.renamecategories" where you 
change the categorie name
  > >
  > > 1. old module namenew module name
  > >
  > >   for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail
  >
  >
  > Does kdebugsettings also support multiple renames? Like log1 > log2 > log3?
  
  
  Perhaps :) I will test it next week
  
  > 
  > 
  >> What do you need as " Could that be supported by some additional macro or 
adaption of the existing/new ones?" ?
  > 
  > We could have another argument for `ecm_qt_declare_logging_category`& 
`ecm_qt_export_logging_category` to pass old log names, and then have 
`ecm_qt_install_logging_categories` also generate & install a .renamecategories 
file. Should be easy to add, working on it next.
  
  oki

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  Yep you need to create a file name "foo.renamecategories" where you change 
the categorie name
  
  old module namenew module name
  =
  
  for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail
  
  What do you need as " Could that be supported by some additional macro or 
adaption of the existing/new ones?" ?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  I don't see other case. For me your macro works for all case that we can 
implement.
  
  No other idea.
  But avoiding to create by hand the file is a good idea. I never successed to 
create a macro for it
  So thanks

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  Seems ok for me

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27151: Use ecm_qt_install_logging_categories over manual categories file

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  generateqtlogcatfile

REVISION DETAIL
  https://phabricator.kde.org/D27151

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Banning QNetworkAccessManager

[laurent Montel]

Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit :
> I updated:
> 
> https://community.kde.org/Policies/API_to_Avoid
> 
> Which had no mention of this.
> 
> David

I think that you made an error 

"networkAccessManger->setAttribute(QNetworkRequest::FollowRedirectsAttribute, 
true); "
Doesn't exist it's a enum from QnetworkRequest::RedirectPolicy
And  FollowRedirectsAttribute is old value
It seems that we need to use QnetworkRequest::NoLessSafeRedirectPolicy 
directly no ?


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9b77746a6b1e: QApplication::globalStrut() will be removed 
in qt6. Its deprecated in qt5.15… (authored by mlaurent).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27010?vs=74627=74783

REVISION DETAIL
  https://phabricator.kde.org/D27010

AFFECTED FILES
  src/kcolorbutton.cpp
  src/kdatepicker.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[Laurent Montel]

mlaurent added a comment.


  ping ?:)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27010

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  QApplication::globalStrut() will be removed in qt6

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  remove_globalStrut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27010

AFFECTED FILES
  src/kcolorbutton.cpp
  src/kdatepicker.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27010

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:87471e14b370: QXmlInputSource is deprecated in qt5.15. 
Port it to QXmlStreamReader (authored by mlaurent).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74428=74460

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent updated this revision to Diff 74428.
mlaurent added a comment.


  Use QStringRef here too

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74406=74428

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent updated this revision to Diff 74406.
mlaurent added a comment.


  Use QStringRef::compare

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74349=74406

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent marked 4 inline comments as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent updated this revision to Diff 74349.
mlaurent added a comment.


  We need to open QIODevice. Now all works correctly after rebuilding all

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74348=74349

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent updated this revision to Diff 74348.
mlaurent added a comment.


  Trim better calling toString()

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74295=74348

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  autotests/kconfigloadertest.cpp
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent edited the test plan for this revision.
mlaurent added a reviewer: dfaure.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  QXmlInputSource is deprecated in qt5.15

REPOSITORY
  R237 KConfig

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  autotests/kconfigloadertest.cpp
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent added a comment.


  Yep done :)

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent added a comment.


  it replace D26432 
  I don't know why it created a new version

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

[Laurent Montel]

mlaurent abandoned this revision.
mlaurent added a comment.


  created a new one D26860 

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26432

To: mlaurent, dfaure, tcanabrava
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to "\n" as it's qt namespaced

TEST PLAN
  autotest ok

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

[Laurent Montel]

mlaurent added a comment.


  It's not used in kmail it seems.
  we use this class in kmail-account-wizard only.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  it's ok for me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:c0bc818c744e: QJsonDocument::fromBinaryData is deprecated 
in qt5.15. We need to port to… (authored by mlaurent).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26737?vs=73792=73813

REVISION DETAIL
  https://phabricator.kde.org/D26737

AFFECTED FILES
  src/externalprocess/processjob.cpp
  src/externalprocess/purposeprocess_main.cpp

To: mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1e5966147de1: QHash::insertMulti is deprecated in qt5.15 
= port to QMultiHash (authored by mlaurent).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26736?vs=73789=73812

REVISION DETAIL
  https://phabricator.kde.org/D26736

AFFECTED FILES
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp

To: mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  QJsonDocument::fromBinaryData is deprecated in qt5.15 Port to 
QCborValue::fromCbor

REPOSITORY
  R495 Purpose Library

BRANCH
  port_to_QCborValue (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26737

AFFECTED FILES
  src/externalprocess/processjob.cpp
  src/externalprocess/purposeprocess_main.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QMultiHash

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  use_multihash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26736

AFFECTED FILES
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26614: Remove extra flush when we close file it will flush

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:aed4416be700: Remove extra flush when we close file it 
will flush (authored by mlaurent).

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26614?vs=73365=73378

REVISION DETAIL
  https://phabricator.kde.org/D26614

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26614: Remove extra flush when we close file it will flush

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26614

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26614: Remove extra flush when we close file it will flush

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Remove extra flush

REPOSITORY
  R269 BluezQt

BRANCH
  remove_extra_flush (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26614

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:d08e77529bd1: endl is Qt:: namespaced in qt5.15. Port to 
\n and flush when QTextStream is not… (authored by mlaurent).

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26320?vs=72512=73177

REVISION DETAIL
  https://phabricator.kde.org/D26320

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.cpp

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  From me I am ok with David comment for this code it's not necessary to have a 
flush() many time.
  Adding \n is enough for me.
  Regards

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  No change needed ? I will commit in two days if no complains.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26496: Log categories: fix format adding DEFAULT_SEVERITY

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  But you're wrong "log_kdebugsettings: In this file:  
"/home/meven/kde/usr/etc/xdg/kio.categories"  this line  "kf5.kio.cookiejar 
kcookiejar (KIO)"  still use old format. We need to port it" it not for missing 
DEFAULT_SEVERITY argument it's just that kio.categories doesnt use new format.
  but it seems that it's an old version as here I don't see this warning for 
kio.categories.
  
  And you add DEFAULT_SEVERITY [WARNING] but ecm_qt_declare_logging_category 
doesn"t use WARNING as default argument for example:
  "ecm_qt_declare_logging_category(kio_trash_PART_DEBUG_SRCS HEADER 
kiotrashdebug.h IDENTIFIER KIO_TRASH CATEGORY_NAME kf5.kio.trash)"
  so this patch is not correct for sure.

INLINE COMMENTS

> kio.categories:17
> +kf5.kio.widgets KIOWidgets (KIO) DEFAULT_SEVERITY [WARNING] IDENTIFIER 
> [KIO_WIDGETS]
> +org.kde.kio.kpasswdserver KPasswdServer (KIO) IDEFAULT_SEVERITY [WARNING] 
> DENTIFIER [category]
>  org.kde.kurifilter-localdomain KUriFilter Local Domain (KIO)  
> DEFAULT_SEVERITY [WARNING] IDENTIFIER [category]

It's not correct when you paste DEFAULT_SEVERITY [WARNING] => you add "I" from 
identifier

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26496

To: meven, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:837621e0e305: Port to QMultiHash as QHash::insertMulti is 
deprecated (authored by mlaurent).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26450?vs=72846=72944

REVISION DETAIL
  https://phabricator.kde.org/D26450

AFFECTED FILES
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginfactory_p.h

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b387faa93526: Port qrand to QRandomGenerator (qrand is 
deprecated in qt5.15) (authored by mlaurent).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26464?vs=72877=72943

REVISION DETAIL
  https://phabricator.kde.org/D26464

AFFECTED FILES
  autotests/coronatest.cpp
  src/plasma/datacontainer.cpp
  src/plasmaquick/appletquickitem.cpp

To: mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3f30f91fb04c: Port endl to \n Not necessary to flush as 
QTextStream uses QFile which flush… (authored by mlaurent).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26465?vs=72878=72942

REVISION DETAIL
  https://phabricator.kde.org/D26465

AFFECTED FILES
  src/plasma/private/dataenginemanager.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9aeb3bef288f: Port endl as \n or std::cout ... std::endl 
when we wrote directly on console or… (authored by mlaurent).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26463?vs=72876=72935

REVISION DETAIL
  https://phabricator.kde.org/D26463

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/katewildcardmatcher_test.cpp
  autotests/src/script_test_base.cpp
  src/export/htmlexporter.cpp

To: mlaurent, dfaure, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26465

AFFECTED FILES
  src/plasma/private/dataenginemanager.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26465

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QRandomGenerator

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26464

AFFECTED FILES
  autotests/coronatest.cpp
  src/plasma/datacontainer.cpp
  src/plasmaquick/appletquickitem.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26463

To: mlaurent, dfaure
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl as it's Qt:: namespaced in qt5.15

REPOSITORY
  R39 KTextEditor

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26463

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/katewildcardmatcher_test.cpp
  autotests/src/script_test_base.cpp
  src/export/htmlexporter.cpp

To: mlaurent
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QMultiHash

REPOSITORY
  R244 KCoreAddons

BRANCH
  port_multi_hash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26450

AFFECTED FILES
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginfactory_p.h

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26450

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> dfaure wrote in kconfig_compiler.cpp:694
> Why? Surely the QTextStream destructor (which is called here) will take care 
> of that.

I think that it was a problem when QTextStream used QString which doesn't flush 
it.
code is a QString

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26432

To: mlaurent, dfaure, tcanabrava
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26449: [PoC] Port to KRecentFileMenu

[Laurent Montel]

mlaurent added a comment.


  So you need to increase kf5 dependancy no ?

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D26449

To: nicolasfella, #ark, #frameworks
Cc: mlaurent, kde-utils-devel, fbampaloukas, tctara

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26432

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl as in qt5.15 it's namespaced

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26432

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26420: Add a logging category to smb ioslave

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26420

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:27
> +IDENTIFIER KIO_SMB_LOG
> +CATEGORY_NAME log_kio_smb)
> +

indent

> kio_smb.cpp:36
>  
> -Q_LOGGING_CATEGORY(KIO_SMB, "kio_smb")
> +#include smb-logsettings.h
>  

#include "..."

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26420

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:128ed7ce3a1e: Remove endl in qDebug as its already 
add \n + port to Qt::endl in qt5.15 (authored by mlaurent).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26303?vs=72419=72694

REVISION DETAIL
  https://phabricator.kde.org/D26303

AFFECTED FILES
  src/sycoca/vfolder_menu.cpp
  tests/pluginlocator/plugintest.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  So what I need to change in this patch ? (if I need to change a code :) )

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Laurent Montel]

mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26303

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a5f8bfc9bf14: In qt5.15 QHash::insertMulti is deprecated 
now we need to use QMultiHash (authored by mlaurent).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26372?vs=72638=72664

REVISION DETAIL
  https://phabricator.kde.org/D26372

AFFECTED FILES
  src/extractorcollection.cpp
  src/writercollection.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26373: Port endl to \n

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:011c329fa4f3: Port endl to \n (authored by mlaurent).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26373?vs=72639=72663

REVISION DETAIL
  https://phabricator.kde.org/D26373

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26373: Port endl to \n

[Laurent Montel]

mlaurent added reviewers: dfaure, apol.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D26373

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26373: Port endl to \n

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n + flush when necessary

REPOSITORY
  R290 KPackage

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26373

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D26372

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QMultiHash

REPOSITORY
  R286 KFileMetaData

BRANCH
  use_qmultihash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26372

AFFECTED FILES
  src/extractorcollection.cpp
  src/writercollection.cpp

To: mlaurent
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:2d40d4f5f0f1: Remove endl in qDebug its already add 
\n at the end + port endl + flush when… (authored by mlaurent).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26301?vs=72594=72606

REVISION DETAIL
  https://phabricator.kde.org/D26301

AFFECTED FILES
  src/kbookmarkimporter_ns.cpp
  src/kbookmarkimporter_opera.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R298:f9e10975740d: Port endl to \n + flush at the 
end (authored by mlaurent).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26302?vs=72593=72604

REVISION DETAIL
  https://phabricator.kde.org/D26302

AFFECTED FILES
  src/kgendesignerplugin.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  nm  -gDC libQt5Core.so.5.15.0 | grep endl
  00336680 T endl(QTextStream&)
  00336500 T QTextStreamFunctions::endl(QTextStream&)
  003361e0 T Qt::endl(QTextStream&)

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Laurent Montel]

mlaurent added a reviewer: apol.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D26301

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Laurent Montel]

mlaurent updated this revision to Diff 72594.
mlaurent added a comment.


  Merge "\n" + use '\n'

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26301?vs=72417=72594

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26301

AFFECTED FILES
  src/kbookmarkimporter_ns.cpp
  src/kbookmarkimporter_opera.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Laurent Montel]

mlaurent added a reviewer: apol.

REPOSITORY
  R298 KDesignerPlugin

REVISION DETAIL
  https://phabricator.kde.org/D26302

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Laurent Montel]

mlaurent updated this revision to Diff 72593.
mlaurent added a comment.


  Merge \n and use '\n'

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26302?vs=72418=72593

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26302

AFFECTED FILES
  src/kgendesignerplugin.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6ed68fd17385: Port endl to \n flush at the 
end + use constref in loop (authored by mlaurent).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26318?vs=72513=72592

REVISION DETAIL
  https://phabricator.kde.org/D26318

AFFECTED FILES
  autotests/scalabletest.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:99009fc60051: endl is namespaced in qt5.15 (authored by 
mlaurent).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26299?vs=72510=72591

REVISION DETAIL
  https://phabricator.kde.org/D26299

AFFECTED FILES
  src/tools/prison-datamatrix.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns