D27928: [VIM Mode] Add g g commands

2020-03-11 Thread Mikhail Zolotukhin 
gikari added a comment.


  Yes, my case.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Mikhail Zolotukhin 
gikari added a comment.


  I added a unit test, but I do not know why it is failing. Actually I do not 
know if I've added it correctly at all. Help is very necsasary.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 77355.
gikari added a comment.


  - Add unit-test

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27928?vs=77199=77355

BRANCH
  g-up-g-down-commands (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27928

AFFECTED FILES
  autotests/src/vimode/keys.cpp
  src/vimode/modes/normalvimode.cpp
  src/vimode/modes/visualvimode.cpp

To: gikari, #kate, #frameworks
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D27928: [VIM Mode] Add g g commands

2020-03-09 Thread Mikhail Zolotukhin 
gikari added a comment.


  I am not sure where I should add it. Is it supposed to be a new pair of 
`bug418486` `.h/.cpp` files? Or should the test reside inside `keys.cpp` in big 
intimidating 500 line wide `MappingTest` function?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin 
gikari edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin 
gikari added reviewers: Kate, Frameworks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin 
gikari created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Add twin commands for `gj` and `gk` for usage with standard
  arrow keys.
  
  BUG: 418486

TEST PLAN
  1. Open document with large sentences, that span across multiple visual lines 
in Kate and use `gj` and `gk` commands in normal mode to move inside a line.
  2. Use `g` and `g` commands - the result must be the same, as using 
`gj` and `gk` commands.
  3. Repeat the same for `visual` mode.

REPOSITORY
  R39 KTextEditor

BRANCH
  g-up-g-down-commands (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27928

AFFECTED FILES
  src/vimode/modes/normalvimode.cpp
  src/vimode/modes/visualvimode.cpp

To: gikari
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann