D23771: Improve API documentation for Definition::setKeywordList()

[Nikita Sirgienko]

sirgienko accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-docs

REVISION DETAIL
  https://phabricator.kde.org/D23771

To: dhaumann, sirgienko
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23771: Improve API documentation for Definition::setKeywordList()

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> definition.h:344
>   *
> - * This function can be usefull for dynamic higlighting, when the 
> document rehiglights more, that one time.
> - * For example, you have a program for editing and running Octave 
> scripts files and
> - * you are using KSyntaxHighlighting for syntax higlighting. But also, 
> you can request list of
> - * variables, functions, etc from corresponed Octave process.
> - * And, used this function, you can provide Octave live higlighting - by 
> passing, for
> - * example, variables names from Octave to KSyntaxHighlighting variable 
> keyword list via this function.
> + * @note In general, changing keyword lists via setKeywordList() in 
> general
> + *   is discouraged, since if a keyword list name  in the syntax

> In general, ... in general

Is it correct? Or just accidental typo?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23771

To: dhaumann, sirgienko
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> dhaumann wrote in definition.h:339
> Fair enough :-) What you just described here is missing in the API 
> documentation. Can you add this to setKeywordList()? Then it's clear to the 
> user of KSyntaxHighlighting (e.g. that you have to force a rehighlight of 
> your document, best even explain how).

Is it enough? I mean, I can add explanation, that rehiglighting whole document 
(after keyword list modification) works via 
`QSyntaxHighlighter::rehighlight()`, but i think, it is pretty obivously for a 
KSyntaxHiglighting user.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, GB_2, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko updated this revision to Diff 64595.
sirgienko added a comment.


  Add explanation, how setKeywordList can be used

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23061?vs=63599=64595

BRANCH
  read-write

REVISION DETAIL
  https://phabricator.kde.org/D23061

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist_p.h

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, GB_2, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added a comment.


  Mm, any changes?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, GB_2, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> dhaumann wrote in definition.h:339
> Please improve the API documentation and add, for instance:
> 
> - Only existing keywordLists() can be changed. For non-existent keyword 
> lists, false is returned.
> - @see keywordList(), keywordLists()
> 
> What I am currently also missing is a section about highlight invalidation: 
> Does one have to trigger a document rehighlight oneself, and if so, how?
> 
> My point is: Assume a doc is highlighted up to line 100. Now you add keywords 
> to a list that are used in these 100 lines, i.e. the highlighting may change 
> arbitrarily.
> 
> How is the KSyntaxHighlighting user supposed to trigger a rehighlight? Or 
> should one only change keyword lists before highlighting any document?

I more thinking in variant, when the highlighting more dynamic, and is done 
more, that one time. For example, in Cantor, we rehighlight whole worksheet, 
when a new variable created in curresponding session. So, if you write "my_var 
= 3" in Python session (and run command cell with this command), "my_var" 
starts to highlight by Cantor as variable after that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko updated this revision to Diff 63599.
sirgienko added a comment.


  Add test and change the function description

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23061?vs=63492=63599

BRANCH
  read-write

REVISION DETAIL
  https://phabricator.kde.org/D23061

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist_p.h

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko updated this revision to Diff 63492.
sirgienko added a comment.


  Bugfix

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23061?vs=63489=63492

BRANCH
  read-write

REVISION DETAIL
  https://phabricator.kde.org/D23061

AFFECTED FILES
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist_p.h

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added a comment.


  In D23061#509851 , @cullmann wrote:
  
  > Hmm, I think we want an unit test for this, too.
  >  And I think it won't work like it is, before the call to 
initLookupForCaseSensitivity one needs to clear both 
m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.
  
  
  Yes, I have forgotten, that `reserve` don't clear `std::vector`. 
  But, considering this, is realization of `initLookupForCaseSensitivity` 
correct?
  I mean, inside `initLookupForCaseSensitivity` are used `reserve` and 
`push_back`.
  So, if I will call `initLookupForCaseSensitivity` twice, I will have 
`m_keywordsSortedCaseSensitive` (for example) with duplicatesof keywords, right?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko updated this revision to Diff 63489.
sirgienko added a comment.


  Use `setKeywordList` instead previous API

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23061?vs=63448=63489

BRANCH
  read-write

REVISION DETAIL
  https://phabricator.kde.org/D23061

AFFECTED FILES
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist_p.h

To: sirgienko, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko marked an inline comment as done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added a comment.


  In D23061#509540 , @cullmann wrote:
  
  > Actually, wouldn't it make more sense to just provide a way to set the full 
keyword list?
  >  You can get the QStringlist will all keywords already with keywordList, a 
setKeywordList(...) would make more sense to me than this modifiers.
  >  That would allow to alter it like you want and then write it back in one 
go with just one re-init of the mapping.
  
  
  Yes, you right. I will change the pull request to `setKeywordList`.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> keywordlist_p.h:73
> +m_keywords.removeAll(keyword);
> +initLookupForCaseSensitivity(m_caseSensitive);
> +}

Not sure about this realization, I think, we could modify it without lookuping 
all data.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko created this revision.
sirgienko added reviewers: dhaumann, cullmann.
sirgienko added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sirgienko requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  read-write

REVISION DETAIL
  https://phabricator.kde.org/D23061

AFFECTED FILES
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist_p.h

To: sirgienko, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Nikita Sirgienko]

sirgienko closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19570

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Nikita Sirgienko]

sirgienko updated this revision to Diff 53515.
sirgienko added a comment.


  Increase syntax file version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19570?vs=53292=53515

BRANCH
  octave-weak-delimiter

REVISION DETAIL
  https://phabricator.kde.org/D19570

AFFECTED FILES
  autotests/html/test.octave.html
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Nikita Sirgienko]

sirgienko created this revision.
sirgienko added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sirgienko requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  octave-weak-delimiter

REVISION DETAIL
  https://phabricator.kde.org/D19570

AFFECTED FILES
  autotests/html/test.octave.html
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko updated this revision to Diff 52442.
sirgienko added a comment.


  Remove outdate Octave tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=52441=52442

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  autotests/folding/highlight_octave.m.fold
  autotests/folding/test.octave.fold
  autotests/html/highlight_octave.m.html
  autotests/html/test.octave.html
  autotests/input/highlight_octave.m
  autotests/input/highlight_octave.m.syntax
  autotests/input/test.octave
  autotests/reference/highlight_octave.m.ref
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko updated this revision to Diff 52441.
sirgienko added a comment.


  Add tests for Octave highlighting

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=50963=52441

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  autotests/folding/test.octave.fold
  autotests/html/highlight_octave.m.html
  autotests/html/test.octave.html
  autotests/input/highlight_octave.m
  autotests/input/highlight_octave.m.syntax
  autotests/input/test.octave
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added a comment.


  Could I specify, what dot is also word delimiter? Because, for example, 
"p.poly" has a wrong highlighting: "poly" highlighted as function, but it is 
not a function, it is a part of object "p".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added a comment.


  In D18734#411032 , @cullmann wrote:
  
  > Good question:
  >
  > I added a minimal howto to the README.md:
  >
  > 
https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978
  >
  > Does that help you?
  
  
  Partially. I have written the test file (`test.octave`), but after `make 
test`, I have errors in `testhighlighter_test`, `htmlhighlighter_test` and 
`folding_test`  like this
  `FAIL!  : TestHighlighterTest::testHighlight(test.octave) 
'ref.open(QIODevice::ReadOnly | QIODevice::Text)' returned FALSE. ()`.
  
  Also, what difference between `highlight.tex` and `test.tex`, for example? 
Octave have `highlight_octave.m.syntax`, which, I guess, is test file, should I 
remove it?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added a comment.


  In D18734#410977 , @cullmann wrote:
  
  > I think this is fine now, but I would like to have some autotests input 
file to have something we can later check for regressions.
  >  Could you provide some MIT or otherwise freely licensed test file?
  >  It must not cover all things, but at least some basic syntax and perhaps 
include some of your new things.
  >  Thanks!
  
  
  Is there documentation for writing tests? For example, I see `input/Makefile` 
and correct tests results like `folding/Makefile.fold`, `html/Makefile.html`, 
`html/Makefile.html`, but I don't understand, how I make the correct results, 
manually?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> octave.xml:2745
> + String="end_try_catch" endRegion="Try" />
>  
> + endRegion="block" />

Could one word (`end`) be in several region?
Because, in Octave, you could end `if` statement by `endif` or just `end`.
In this variant, this syntax supported, but correct implementation also allow 
wrong Octave sytnax, like ending `while` via `endfor` (because we are using one 
region for them in code above).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko marked an inline comment as done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko updated this revision to Diff 50963.
sirgienko added a comment.


  Add requested changes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=50877=50963

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added a comment.


  @dhaumann, look on the `eps` (this word contained in command list) on this 
image. The word have wrong highlighting.
  F6589241: изображение.png 
  I am testing my `octave.xml` file on v5.49.0 (current master need ecm 5.55 
and I haven't it). Is it bug and I should create bug report, or it is already 
fixed?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko created this revision.
sirgienko added a reviewer: Framework: Syntax Highlighting.
sirgienko added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sirgienko requested review of this revision.

REVISION SUMMARY
  I have updated keywords, commands, builtions and functions. As you can see, i 
move all builtins with normal name to functions list (like it was done before 
in third version), because builtins have highlight different from functions 
(for example, `acos` is builtin and `acot` is function, so if we *really* fill 
builtins list by octave builtions, file will turn into colour mess).
  
  I aslo have added new blocks for classes. But some of them (`events`, 
`methods`, etc.) valid only into `classdef` block, how I could add resctriction 
for this?

TEST PLAN
  As I see, there aren't tests for octave, right?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18714: Add some Maxima constans and function

[Nikita Sirgienko]

sirgienko closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18714

To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18714: Add some Maxima constans and function

[Nikita Sirgienko]

sirgienko added a comment.


  Should I land it via arc? Or mannualy commit it (for short commit message)?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18714

To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18714: Add some Maxima constans and function

[Nikita Sirgienko]

sirgienko updated this revision to Diff 50809.
sirgienko added a comment.


  Increase version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18714?vs=50807=50809

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18714

AFFECTED FILES
  data/syntax/maxima.xml

To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18714: Add some Maxima constans to MaximaVariable list

[Nikita Sirgienko]

sirgienko updated this revision to Diff 50807.
sirgienko added a comment.


  Add Maxima function

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18714?vs=50805=50807

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18714

AFFECTED FILES
  data/syntax/maxima.xml

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18714: Add some Maxima constans and function

[Nikita Sirgienko]

sirgienko retitled this revision from "Add some Maxima constans to 
MaximaVariable list" to "Add some Maxima constans and function".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18714

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18714: Add some Maxima constans to MaximaVariable list

[Nikita Sirgienko]

sirgienko created this revision.
sirgienko added a reviewer: Framework: Syntax Highlighting.
sirgienko added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sirgienko requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18714

AFFECTED FILES
  data/syntax/maxima.xml

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann