D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Welp, there's nothing objectively wrong with making this patch. LGTM

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Noah Davis]

ndavis added a comment.


  This doesn't seem wrong, but why is it needed? Do people get confused about 
the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we 
put their configuration menu under a different menu option?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

[Noah Davis]

ndavis added a comment.


  In D25296#563291 , @ngraham wrote:
  
  > Never mind, I wasn't deleting the cache files properly after rebuilding. 
When I do that, the monochrome icons don't get used at all and it reverts to 
the colorful one:
  >  F778: Screenshot_20191116_084222.png 

  
  
  The color vs monochrome issue strikes again :(
  
  Maybe remove the size prefix from the 32px version? If that doesn't work, 
I've got nothing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch 
hardcoded numbers for enum items (authored by ndavis).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25677?vs=70812&id=70813

REVISION DETAIL
  https://phabricator.kde.org/D25677

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis marked 2 inline comments as done.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D25677 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis updated this revision to Diff 70812.
ndavis added a comment.


  More code formatting

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25677?vs=70802&id=70812

BRANCH
  arcpatch-D25677 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25677

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis marked 3 inline comments as done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis updated this revision to Diff 70802.
ndavis added a comment.


  - [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
  - fix code style

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25677?vs=70720&id=70802

BRANCH
  arcpatch-D25677 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25677

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:38b02c1baa84: [KColorScheme] Add items to ColorSet and 
Role enums for the total number of… (authored by ndavis).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25676?vs=70718&id=70798

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a comment.


  In D25677#570896 , @ngraham wrote:
  
  > > This also replaces some for-loops with C++11 range based for-loops and 
switches for simpler if/else control blocks.
  >
  > Seems like these changes are unrelated and should maybe be in a separate 
commit?
  
  
  The intention of the patch is to reduce the number of hardcoded values, so 
they're related. It wouldn't make sense to switch the hardcoded for-loop ranges 
for the enum values introduced in the parent patch only to replace them with 
range based for-loops immediately afterward.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis added a reviewer: dfaure.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a reviewer: dfaure.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis added a dependent revision: D25677: [KColorScheme/KStatefulBrush] Switch 
hardcoded numbers for enum items.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and 
Role enums for the total number of items.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This also replaces some for-loops with C++11 range based for-loops and 
switches for simpler if/else control blocks.

TEST PLAN
  Open colorscheme editor in the Colors KCM to see if any colors or effects 
look broken.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  remove-hardcoded-values (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25677

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis updated this revision to Diff 70718.
ndavis added a comment.


  - Split up Effects enum

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25676?vs=70717&id=70718

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis retitled this revision from "Add items to ColorSet and Role enums for 
the total number of items" to "[KColorScheme] Add items to ColorSet and Role 
enums for the total number of items".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis updated this revision to Diff 70717.
ndavis added a comment.


  - Also do Effects enum

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25676?vs=70716&id=70717

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  I noticed that QPalette had these, but KColorScheme didn't. Since there is no 
function to get the number of items in an enum for C++, it seems like it would 
be useful to have a built-in way to get the total number of items. I will make 
a follow up patch to reduce the amount of hardcoded values in KColorScheme.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.h

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configuration-icons.svg:17
> @ndavis can you review this icon change please

I couldn't see any issues in the SVG code. @mart Where is `showbackground` used 
in the UI so that I can test it?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25590

To: mart, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#566992 , @ngraham wrote:
  
  > In D25334#566745 , @ndavis wrote:
  >
  > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  >
  >
  > To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.
  
  
  I've found that breeze dark needs high chroma dark blue for the background to 
look good. It's easy enough to do with `KColorUtils::tint()` (doesn't work the 
same as `Qt.tint()` in QML), but I don't know how you'd do that in SVG. When 
you use semi-transparency for a higher chroma color on top of a background with 
lower chroma, it reduces the chroma of the higher chroma color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#566524 , @niccolove 
wrote:
  
  > F7780227: Screenshot_20191123_130602.png 

  >  I'm sorry, isn't this right?
  >  The top one was like that before, and I just edited the bottom one, and 
they seem to be the same; shouldn't it be right then?
  
  
  Yes, that's right, it's the panel that doesn't look right.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In that case, maybe 5% opacity for minimized?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  Here's the fixed file: F680: tabbar.svg 

  Unfortunately, it still doesn't look right.
  F681: Screenshot_20191121_160905.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ndavis wrote in tabbar.svg:47
> Oh wait, this must be where the color problem is. It's hardcoded to a light 
> color.

It should be ButtonFocus with semi-transparency instead.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> tabbar.svg:47
> +
> + height="12" fill="#93cee9" opacity=".34"/>
> + height="12" fill="#93cee9" opacity=".34"/>

Oh wait, this must be where the color problem is. It's hardcoded to a light 
color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#565851 , @ngraham wrote:
  
  > Are you talking about the effect itself in terms of its background color, 
or how it fits in the space available when displayed by widgets? The latter 
will require many complicated changes in various places to fix, but can't the 
former be fixed in this patch?
  
  
  I'm talking about both. I believe the former may also be complicated since I 
don't know where the problem is coming from. It should have been as simple as 
setting the opacity to an appropriate level, but something is tinting the 
background white.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#565798 , @ngraham wrote:
  
  > Honestly I think this is fine to land now. We can incrementally improve 
things with patches to individual widgets, but for the most part I think this 
is a big improvement already.
  
  
  I disagree. Maybe it looks good enough on Breeze, but it looks pretty bad on 
Breeze Dark, even if it's not the fault of this patch. If those issues didn't 
get fixed before the next frameworks release, we'd have to revert this commit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  F7769041: Screenshot_20191117_203818.png 

  15% Inactive BG opacity
  10% Minimized BG opacity

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#563908 , @ngraham wrote:
  
  > Decreasing the opacity of the icon itself? Maybe that could work.
  
  
  Not the icon, the background.
  
  > A pet peeve I have with the status quo is that minimized apps/windows have 
greater visual prominence than other ones, which seems backwards. This patch 
generally fixes that (especially for the active app/window), but now minimized 
apps/windows have a state that looks too similar to other ones. We just need to 
figure out how to make that state look de-emphasized.
  
  I agree.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#563783 , @ngraham wrote:
  
  > I don't hate the current state, let me note. It's just not what I expected, 
and I feel like I would need to get used to it rather than immediately falling 
in love with it.
  
  
  What could be done to make it better? I noticed the same feeling myself, but 
decreasing the opacity of the inactive/minimized modes felt better.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  Even if the colors are fixed, there are a number of other places that need 
fixes in order for this to look right, so I think we should hold off landing 
this until these issues are fixed:
  Not extending to the edge: F7768790: Screenshot_20191117_171047.png 

  Something about this feels wrong: F7768797: Screenshot_20191117_171225.png 

  Same here: F7768799: Screenshot_20191117_171323.png 

  
  These may need separate patches to the code that controls the widgets.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  These colors don't look right
  F7768670: Screenshot_20191117_152000.png 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  I wonder if the Light gray line on the inactive mode should be a little 
brighter (up to 35% opacity) or if the background for inactive and minimized 
should be a little darker (down to 15% opacity)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  Here's a cleaned up version of the file with the changes Nate and I 
requested: F7767647: tasks.svg 
  F7767649: Screenshot_20191117_005703.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  Unfortunately, InactiveText doesn't work and neither does DisabledText. I 
might need to change whatever library handles stylesheets for plasmashell.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#563388 , @niccolove 
wrote:
  
  > > @ndavis said:
  > >  Here's what I think:
  > > 
  > > - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  > > - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  >
  > Please note that would require change in how desktop themes are handled, 
not in the desktop theme itself, as far as I understand it. I'm afraid I don't 
have the experience to implement what you are saying; this is the best I can 
offer. Of course, if there is anybody else, it could be a good idea.
  
  
  It looks like you already did it, but the opacity levels of the inactive bars 
need to be changed. I noticed that the SVG uses black in inkscape as the base 
color for the minimized and normal (inactive) modes, but actually uses the text 
color in Plasmashell. Keep that in mind when adjusting the opacity and the 
color class should be changed to InactiveText. I haven't actually tested if 
this value works, but it should. Right now I'm playing around with your patch a 
bit.
  
  Based on my experience, this should have broken stylesheet support, but 
apparently not...
  

  


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#563295 , @niccolove 
wrote:
  
  > In D25334#563285 , @ngraham 
wrote:
  >
  > > Perfect, all issues fixed, and thanks for pointing  me in the direction 
of the cache files. Deleting those fixed a bunch of other issues I was having 
with applying plasma theme SVG changes.
  >
  >
  > Did it fix the shadows? I can't apply my own shadows to the new distro I'm 
using.
  >
  > Regarding this task, I just realized a possible problem: 
  >  I originally copied this effect from the highlight effect that's used when 
you hover on applications, which uses a 3px blue line:
  >  F774: Screenshot_20191116_164209.png 

  >  But then, tweaking things around, I realized that a 2px line looks way 
better in my panel, imo:
  >  F776: Screenshot_20191116_164303.png 

  >  Therefore right now this effect and the application hover effect are 
inconsistent. I'm not a fan of bringing back that 3px line though. Do you think 
I should change the application top lines, or leave them as-is?
  
  
  If we use a 2px line here, then using a 2px outline for button focus in 
D24706  would be more acceptable. If a 2px 
line looks good in the task manager, it might be worth making the change.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#563346 , @ngraham wrote:
  
  > Found the bug report tracking that requested change: 
https://bugs.kde.org/show_bug.cgi?id=370465
  >
  > Based on the comments there, it's likely that this proposal would receive 
pushback, and we should endeavor to understand why it was changed to the 
current state in the first place. That's not a reason to hold back on doing it, 
we just need to understand the history and make the change for legitimate 
usability-based reasons so it's not perceived as "flipping things back and 
forth over and over again".
  
  
  The relevant quote:
  
  > Kai Uwe Broulik 2018-04-03 07:51:10 UTC 
  >  We had exactly what you suggest for a while and then it was changed back 
to line art. Can we stop randomly changing theme whenever someone comes by and 
doesn't like something unless it actually comes enclosed with a 20 page 
empirical study made in a lab or something?
  
  Looks like he's referring to using only colored backgrounds, which is not 
what we're doing now. I do think the current way of showing window state is 
visually a bit confusing.
  
  Here's what I think:
  
  - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  
  This way it mostly doesn't change, but the visuals have more of a logical 
relation to each other.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25296: [RFC] Fix Display Configuration icon margins

[Noah Davis]

ndavis added a comment.


  I figured it out. The 22px version needs the `22-22-` prefix in its ID.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> preferences.svg:4
> +.ColorScheme-Text {
>  color:#7B7C7E;
>}

Wrong default colors. Just replace the whole stylesheet with this one: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze

> preferences.svg:36
> +  }
> +

D25296: [RFC] Fix Display Configuration icon margins

[Noah Davis]

ndavis added a comment.


  It's blurry in your screenshot because you're scaling a 22px icon up to 32px. 
The solution is to make a 32px version named 
`32-32-preferences-desktop-display-randr`. BTW, the icon is not actually 
aligned with the grid. It's a little off here and there. You should be able to 
fix it easily with the node tool by snapping nodes to the grid.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM, but I noticed that there is a 32px monochrome icon. Should we keep 
using 32px monochrome icons for now? It seems like we can't make up our minds 
on this issue and the amount of work required to complete a move in either 
direction leads to us not wanting to commit to either direction.

REPOSITORY
  R266 Breeze Icons

BRANCH
  eyedropper-style-color-picker-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  all-apps-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25291

To: ngraham, #vdg, broulik, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Noah Davis]

ndavis added a comment.


  In D25226#560363 , @ngraham wrote:
  
  > Or maybe should the UI be changed to show a clickable link and an "edit" 
button that temporarily turns it into a text field that lets you edit it?
  
  
  So like this?
  
  __​/media/external-drive/Pictures__ ​ {icon pencil-square-o}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1120
> +QPushButton *goThereButton = new QPushButton(d->m_frame);
> +goThereButton->setIcon(QIcon::fromTheme(QStringLiteral("go-next")));
> +

`go-jump` is more semantically correct.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  In D25015#560516 , @cblack wrote:
  
  > In D25015#560515 , @ndavis wrote:
  >
  > > One thing we might need to do in order to finally stop changing the 
shadows is come up with a math based system for deciding how shadows should 
look based on the elevation we want certain UI elements to have. We could copy 
Material Design shadows, but I don't think we should. MD's shadows get darker 
the larger they are, but that's not how real shadows work. Real shadows get 
darker the smaller they are because light bounces around.
  >
  >
  > Material shadows get more voluminous, not darker.
  
  
  Well, they look darker, which still isn't realistic: 
https://material.io/design/environment/light-shadows.html#shadows

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  One thing we might need to do in order to finally stop changing the shadows 
is come up with a system for deciding how shadows should look based on the 
elevation we want certain UI elements to have. We could copy Material Design 
shadows, but I don't think we should. MD's shadows get darker the larger they 
are, but that's not how real shadows work. Real shadows get darker the smaller 
they are because light bounces around.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  In D25015#560498 , @niccolove 
wrote:
  
  > In D25015#559344 , @filipf wrote:
  >
  > > I'd prefer the shadows to have equal strength all around, I couldn't get 
used to weaker shadows in the corners.
  >
  >
  > Oh! That's a pity, I really liked them. I will update it as soon as I have 
time.
  >
  > In D25015#559687 , @ngraham 
wrote:
  >
  > > Ah, pixel-perfect before-and-after images make it much easier to see. I 
will reiterate my belief that the shadows now need to be bigger if we're going 
to make them lighter and weaker.
  >
  >
  > Uhm, I will try something and get back to you.
  >
  > In D25015#559765 , @ndavis wrote:
  >
  > > Rather than painstakingly making shadows by hand in Inkscape, perhaps we 
should be using KWin for the shadows?
  >
  >
  > Remember that there are third party desktop themes with SVG that we 
probably want to support. Wouldn't using KWin for shadows break those?
  
  
  If we remove the code for using those SVG shadows, it won't break them in the 
sense that they will stop working. It'll just mean those parts of the desktop 
themes won't be used. I suppose that could be seen as a form of visual breakage.
  
  For complete theme sets, this shouldn't be such a problem since they also 
typically come with their own window decorations and recommend a specific 
widget style. For people who just want to get rid of the shadows we should 
probably provide an option somewhere to disable them rather than making them 
edit the plasma theme. I suppose we could wait until Plasma 6 to make that kind 
of change, but that's a ways away.
  
  Regardless of the method we use to achieve it (including continuing to use 
SVGs), I think it might be best to make Plasmashell's shadows match the shadows 
cast by menus (such as context menus) in applications. These are defined in the 
Breeze widget style and have different sizes to match the different window 
shadow sizes.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25123: [WIP] New yakuake logo/icon

[Noah Davis]

ndavis added a comment.


  I think I prefer C the most now that I've seen it next to other icons. It has 
a similar level of detail to other Breeze icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I still think the lines on the side of the tube need to be a bit thicker. 
They're almost half a pixel thick, which is not in line with what we normally 
do and it makes them fuzzy or light gray. 1px diagonal strokes converted to 
paths should look right, but you'll have to change the shape of the body a bit 
to fit the new sides. The tip should also be exended to fill the bottom left 
pixel, otherwise it's kind of blurry.
  
  You see the difference in clarity for the sides and tip?
  top: original
  left: modified with pointy tip, right: modified with thicker tip
  F7749303: Screenshot_20191108_203534.png 
 8x F7749305: 
Screenshot_20191108_203747.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  I see the difference now as well. @niccolove BTW, the top right corner is a 
bit messed up. It's rising above the rest of the shadow on the top edge.
  
  Rather than painstakingly making shadows by hand in Inkscape, perhaps we 
should be using KWin for the shadows?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  I haven't said much about this idea because I just have a hard time seeing 
the difference from the screenshots. It seems like a good amount of effort went 
into this, and I know from experience that adjusting shadows in Inkscape is a 
major PITA, but I can't approve something just because of that. Maybe we're 
using the wrong approach for shadows in the first place?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  another set
  F7736364: Screenshot_20191104_154914.png 

  
  F7736366: Screenshot_20191104_154930.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25123: [WIP] New yakuake logo/icon

[Noah Davis]

ndavis added a comment.


  In D25123#558353 , @mglb wrote:
  
  > Breaking nice-looking proportions just to fill vertical space is not good 
IMO. Making the bar a bit higher might make it look more reasonably. Your 
second proposition (icon C) looks nice though.
  
  
  I agree, the modified `A` didn't turn out that well.
  
  > Note that size is perceived differently on different shapes - compare e.g. 
square and circle - with the same logical sizes, circle looks smaller (Breeze 
has this problem).
  >  The icon C is 48px wide (44px when counting only the screen), so 36px 
(38px with "handle" on the bottom) height makes its sizes visually similar to 
40x40px square icons.
  > 
  > The same applies for alignment (see e.g. plasmadiscover.svg), but that 
shouldn't be a problem here.
  
  I'm aware of that. I know Material Design uses different sizes for circles, 
squares and rectangles for that reason. Unfortunately, switching to that system 
means we would need to change many icons. I believe the reason why we use the 
system we use is because of horizontal text alignment, but I think that matters 
more for monochrome icons than color icons. On the other hand, nothing actually 
lines up with text in a way that stands out as lining up particularly well 
whether you choose 10, 11 or 12pt Noto Sans.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  The chunky look works well at 16px, but I can see it sticking out at larger 
sizes.
  
  These ones have pointier tips:
  
  1x F7730340: Screenshot_20191103_174917.png 
 4x F7730343: 
Screenshot_20191103_175058.png 
  
  partially filled: F7730357: Screenshot_20191103_175409.png 

  
  F7730361: Screenshot_20191103_175458.png 

  
  In D25132#558307 , @ngraham wrote:
  
  > Like this maybe?
  >
  > F7730326: Screenshot_20191103_154347.png 

  
  
  Can you show it at 16px and 4x 16px?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  Here's another idea: F7730258: Screenshot_20191103_173337.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  I think it needs to be a little more Breezy. Here are 2 of my attempts with 
the 16px version: F7730187: Screenshot_20191103_172328.png 
 F7730173: Screenshot_20191103_172121.png 
 F7730179: color-picker.svg 

  
  In order to make the lines crisper at small sizes: used the technique 
described here: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Diagonal_lines
  
  For the 1st attempt, I tried to make it more like your version. The round 
bubble at the end was tricky. If you want me to explain exactly how I did it, I 
can, but it's rather lengthy. There might be a faster way that I haven't 
discovered.
  
  For the 2nd attempt, I tried to make it more like what I usually see when I 
see eyedroppers IRL. I just made a simple 3x3 circle, put it in the top right, 
cut it in half from top left to bottom right and drew a diagonal box from the 
ends of the semicircle to the main body of the shape.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25123: [WIP] New yakuake logo/icon

[Noah Davis]

ndavis added a comment.


  A or C for me.
  
  `A` looks more like how I imagine a "drop down terminal", but it's got a lot 
of margin below the bottom of it.
  
  I tried seeing how it would look extended down to the bottom margin: 
F7728707: Screenshot_20191103_135015.png 
  
  `C` looks more like a pull down projector screen, but that's not necessarily 
bad. It also doesn't quite reach the bottom.
  
  I tried seeing how it would look extended down to the bottom margin: 
F7728733: Screenshot_20191103_135310.png 
  
  #vdg ,  Should we allow some types of 
icons to be vertically off center? If not that, should we allow some icons to 
not reach all the way to the top and bottom margins? There are already some 
icons like that, but that doesn't necessarily mean we should want that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Noah Davis]

ndavis added a comment.


  I'm not sure if my review is really necessary since I lack the technical 
expertise to know what the right solution is, but +1 to light and dark Breeze 
icon support on other platforms.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

T11950: Reduce the pain of working on monochrome Breeze icons

[Noah Davis]

ndavis added a comment.


  I don't trust optimizers unless it's `scour`. That's the only one I know of 
that doesn't seem to cause problems occasionally. Inkscape's Optimized SVG save 
option actually uses `scour` to do the optimization.
  
  I'm somewhat open to the idea of only requiring optimization at build time 
for the sake of making it easier for newbies to contribute, but I prefer 
reading optimized SVGs in patches because that makes it easier for me to spot 
mistakes. The massive quantity of noise that Inkscape puts into SVGs, even 
plain SVGs, is staggering. Maybe we could have something that cleans the SVGs 
when submitted for a patch? If it won't work with Phabricator, it might work 
with GitLab.
  
  In T11950#206330 , @ngraham wrote:
  
  > As far as I can tell, every single icon in the `icons-dark` folder is 
identical to the other ones with the exception of having the colors in the 
stylesheet changed. Auto-generating these in CMake seems quite feasible.
  
  
  There are a few that can't be auto-generated that way (gradients don't work 
with stylesheets), so we should have some logic to avoid overwriting files that 
already exist. Then we can eliminate all the icons that only need to have their 
stylesheet changed while keeping the option to do Breeze Dark specific icons.
  
  > Optimization creates real problem - sometimes icons after optimizations 
become hard to edit, so less people want to do modifications.
  
  There are 2 main issues that Optimizers introduce (in order of severity):
  
  - That gradients that don't get their properties from another gradient that 
they reference can't be swapped, unless you unset and reset the fill of the 
object you want to change the gradient for. This seems like a bug in Inkscape.
  - That some optimizers combine paths with similar properties by default. This 
isn't a big deal if you know to go to Path > Break Apart in Inkscape, but 
obviously not everyone is going to know Inkscape or SVGs very well. It's hard 
to say how much a new contributor should be expected to know about SVGs or 
Inkscape.
- Sometimes Break Apart causes objects to lose their properties and turn 
black. Usually not a big deal, it's very easy to fix, but not good for workflow.
- I suppose we could just make sure we don't use any settings in the 
optimizer for combining paths.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, ndavis
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, LeGast00n, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a comment.


  I don't have time to do all 32px icons at once, but thankfully, they're 
usually only used in the desktop shell (I can put 32px monochrome icons in the 
desktop theme), or in preferences or navigation sidebars. I suppose it also 
affects people who raise the toolbar icon size to 32px, but I wonder how many 
people even know they can do that. I could just keep this diff unlanded for as 
long as it takes to convert all 32px icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a subscriber: ngraham.
ndavis added a comment.


  In D24975#554721 , @mglb wrote:
  
  > Why do you replace action icons instead of adding separate colorful icons 
for use in preference dialogs? Right now all action icons are "monochrome", 
making few of them colorful will introduce inconsistency.
  
  
  Maybe I should have explained it in the summary. It's kind of impossible to 
have consistent icon styles in 3rd party apps and well be breaking 
compatibility with 3rd party icon themes whenever we add another `preferences-` 
icon. @ngraham and I have talked about this and we decided that it might be 
best to just make all 32px and larger icons use the color style. In order to 
fix the problem we have without changing breeze-icons, we may need a new 
freedesktop.org icon spec that is designed to handle the type of theme we have. 
The current fd.o spec works in a way that assumes an icon theme will have one 
style. GNOME gets around that by just naming some icons symbolic, but that 
means apps have to choose to use symbolic icons. If you want more time to 
discuss changes like these and find other solutions, that's fine with me. This 
patch doesn't need to be landed in a hurry.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Noah Davis]

ndavis added a comment.


  In D24959#554523 , @trickyricky26 
wrote:
  
  > On the technical side, we usually convert everything to paths, and even 
though I can't imagine Qt SVG Renderer would have a problem with `circle`, it 
might be better to convert the background to a path.
  
  
  I don't think this matters. Usually, it's strokes that need to be converted 
to paths because otherwise they appear jagged for whatever reason.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a task: T10165: Large category icons should all be colorful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  - document-open-recent, document-save-all, document-save-as, document-save, 
folder-open-recent, view-presentation, view-preview.svg

REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

AFFECTED FILES
  icons-dark/actions/32/document-open-recent.svg
  icons-dark/actions/32/document-save-all.svg
  icons-dark/actions/32/document-save-as.svg
  icons-dark/actions/32/document-save.svg
  icons-dark/actions/32/folder-open-recent.svg
  icons-dark/actions/32/view-presentation.svg
  icons-dark/actions/32/view-preview.svg
  icons/actions/32/document-open-recent.svg
  icons/actions/32/document-save-all.svg
  icons/actions/32/document-save-as.svg
  icons/actions/32/document-save.svg
  icons/actions/32/folder-open-recent.svg
  icons/actions/32/view-presentation.svg
  icons/actions/32/view-preview.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2a36922a8cc4: Add folder-recent, extend hand of clock in 
folder-temp (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24652?vs=67939&id=68773

REVISION DETAIL
  https://phabricator.kde.org/D24652

AFFECTED FILES
  icons-dark/places/32/folder-recent.svg
  icons-dark/places/32/folder-temp.svg
  icons-dark/places/64/folder-recent.svg
  icons/places/32/folder-recent.svg
  icons/places/32/folder-temp.svg
  icons/places/64/folder-recent.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:8732c6a99ad1: Fill middle mouse button area (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24625?vs=67877&id=68774

REVISION DETAIL
  https://phabricator.kde.org/D24625

AFFECTED FILES
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-middle.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  In D24476#554110 , @pino wrote:
  
  > Please remember that the properties dialog is a general dialog offered by 
the KIO framework, and it can be used perfectly outside of dolphin. Removing 
pieces of information just because "dolphin has them" is not a good option, 
especially if you want to make KDE frameworks really friendly outside of the 
KDE project.
  
  
  That's a good point. Another app using KIO isn't necessarily going to have a 
different way to show the current amount of free space.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik, ndavis
Cc: pino, ndavis, Zren, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I agree with this change.

REPOSITORY
  R241 KIO

BRANCH
  only-show-volume-info-for-volumes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik, ndavis
Cc: ndavis, Zren, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-appropriate-ghns-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24871

To: ngraham, #vdg, leinir, ndavis
Cc: kde-frameworks-devel, ndavis, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

[Noah Davis]

ndavis added a comment.


  Oh yes, that would be a good thing. Any of these will be fine: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24537: Icons for windy weather

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I'm fine with this blue.

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

[Noah Davis]

ndavis added a comment.


  For some reason, Arc made me the committer and the author instead of just the 
committer.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24652

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  folder-recent is merely a symlink to folder-temp since they both normally use 
the same iconography. I don't like that they are identical and have completely 
different meanings though. If I can do it without breaking anything, I'll 
replace folder-temp with folder-recent in the future.

REPOSITORY
  R266 Breeze Icons

BRANCH
  recent-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24652

AFFECTED FILES
  icons-dark/places/32/folder-recent.svg
  icons-dark/places/32/folder-temp.svg
  icons-dark/places/64/folder-recent.svg
  icons/places/32/folder-recent.svg
  icons/places/32/folder-temp.svg
  icons/places/64/folder-recent.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:15ed55b4cb71: [icons/media.svg] Add 16 & 32px icons, 
update style (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24627?vs=67885&id=67938

REVISION DETAIL
  https://phabricator.kde.org/D24627

AFFECTED FILES
  src/desktoptheme/breeze/icons/media.svg

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:83c8768b2a70: Fix incorrect margins in 16/22px media 
icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24628?vs=67887&id=67924

REVISION DETAIL
  https://phabricator.kde.org/D24628

AFFECTED FILES
  icons-dark/actions/16/media-eject.svg
  icons-dark/actions/16/media-mount.svg
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/16/media-record.svg
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-eject.svg
  icons-dark/actions/22/media-mount.svg
  icons-dark/actions/22/media-mout.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons-dark/actions/22/media-record.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons/actions/16/media-eject.svg
  icons/actions/16/media-mount.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/16/media-record.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-eject.svg
  icons/actions/22/media-mount.svg
  icons/actions/22/media-mout.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg
  icons/actions/22/media-record.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24628

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

ndavis added a dependent revision: D24627: [icons/media.svg] Add 16 & 32px 
icons, update style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24628

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis added a dependency: D24628: Fix incorrect margins in 16/22px media icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For some reason, the margins on these icons were 1 px larger on each side 
than they were supposed to be.

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24628

AFFECTED FILES
  icons-dark/actions/16/media-eject.svg
  icons-dark/actions/16/media-mount.svg
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/16/media-record.svg
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-eject.svg
  icons-dark/actions/22/media-mount.svg
  icons-dark/actions/22/media-mout.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons-dark/actions/22/media-record.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons/actions/16/media-eject.svg
  icons/actions/16/media-mount.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/16/media-record.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-eject.svg
  icons/actions/22/media-mount.svg
  icons/actions/22/media-mout.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg
  icons/actions/22/media-record.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Fixes blurry icons in the desktop shell

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  media-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24627

AFFECTED FILES
  src/desktoptheme/breeze/icons/media.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24625

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The negative space in the middle didn't quite look right

REPOSITORY
  R266 Breeze Icons

BRANCH
  adjust-mmb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24625

AFFECTED FILES
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-middle.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns