D21919: Change joystick settings icon to game controller

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  BUG: 406679
  FIXED-IN: 5.60

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gaming.svg
  icons/preferences/32/preferences-desktop-gaming.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Noah Davis]

ndavis added a comment.


  Hmm. I don't think we should increase the padding on the desktop theme. That 
kind of approach seems like it would work best once we know the contents of 
notifications and OSDs are aligned how we want them to be in the code.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Noah Davis]

ndavis added a comment.


  In D21813#479952 , @ngraham wrote:
  
  > I like the rounder corners! :)
  
  
  I don't, but those aren't meant to be discussed in this RFC anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Noah Davis]

ndavis added a comment.


  Besides the notifications, where does this add padding?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Noah Davis]

ndavis added a comment.


  I just tried the patch on my own computer and I noticed a few more things 
that need to be changed:
  
  - The canvas size is 128x128 px when it should be 48x48
  - Strokes need to be converted to paths ( [Ctrl] + [Alt] + [c] ). Strokes 
don't always look correct in various SVG renderers, including the Qt renderer.
  - I see you added a shadow inside the darker blue rim, but while you can do 
that, there also needs to be a 1px high shadow on the very bottom for it to 
match the HIG.
- There are some exceptions, but they are not common (or the icon creator 
and reviewers just forgot ¯\_(ツ)_/¯ ).
  - The top left and bottom right corners are not aligned to the grid:
  
  F6888034: Screenshot_20190613_182219.png 

  F6888038: Screenshot_20190613_182302.png 

  
  Suggestions regarding the colors:
  
  - I think the icon would be more recognizable if the board had a darker color 
instead of a lighter color. The board itself could use a gradient, but I assume 
you're still planning to add that.
  - For the indentations, I think they would look more natural if their colors 
were based on the board's colors rather than the pieces' colors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Noah Davis]

ndavis added a comment.


  We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen 
thing. How about adding some holes instead to make it look more like the real 
thing? 
https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg
  
  Just some ideas: Use light gray or white circles for the holes and black and 
red for the pieces (like in the actual program). Take a look at the `kiriki` 
icon. The way it does indentations can be inspiration for the holes.
  
  I think the icon is lacking gradients, especially the shadows, which are 
always supposed to be linear gradients.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6227d63efa20: Add edit-select-text, make 16px draw-text 
like 22px (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21632?vs=59283=59287

REVISION DETAIL
  https://phabricator.kde.org/D21632

AFFECTED FILES
  icons-dark/actions/16/draw-text.svg
  icons-dark/actions/16/edit-select-text.svg
  icons-dark/actions/22/edit-select-text.svg
  icons/actions/16/draw-text.svg
  icons/actions/16/edit-select-text.svg
  icons/actions/22/edit-select-text.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

ndavis added a dependent revision: D21633: Change Text Selection icon to 
edit-select-text.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21632

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21632

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Okular uses draw-text for the text selection tool, but it has 2 different 
icons at different sizes. This patch adds a more semantically correct icon for 
Okular (edit-select-text) and fixes the inconsistency between 16 and 22 px 
versions of draw-text.

REPOSITORY
  R266 Breeze Icons

BRANCH
  edit-select-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21632

AFFECTED FILES
  icons-dark/actions/16/draw-text.svg
  icons-dark/actions/16/edit-select-text.svg
  icons-dark/actions/22/edit-select-text.svg
  icons/actions/16/draw-text.svg
  icons/actions/16/edit-select-text.svg
  icons/actions/22/edit-select-text.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis added a comment.


  In D21574#474173 , @ognarb wrote:
  
  > Sorry it arc who also uploaded the png that I created for the review, I 
will fix it.
  
  
  Ah, fair enough. Easy mistake to make.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis added a comment.


  Once you're done with the SVG, make sure you clean it: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis added a comment.


  Wait, is this a PNG? This needs to be an SVG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  There needs to be a copy in breeze dark as well. Nice job though!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21526: Add help-donate-[currency] icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e759724fab78: Add help-donate-[currency] icons (authored 
by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21526?vs=58990=59060

REVISION DETAIL
  https://phabricator.kde.org/D21526

AFFECTED FILES
  icons-dark/actions/16/help-donate-ars.svg
  icons-dark/actions/16/help-donate-aud.svg
  icons-dark/actions/16/help-donate-brl.svg
  icons-dark/actions/16/help-donate-cad.svg
  icons-dark/actions/16/help-donate-chf.svg
  icons-dark/actions/16/help-donate-cny.svg
  icons-dark/actions/16/help-donate-eur.svg
  icons-dark/actions/16/help-donate-gbp.svg
  icons-dark/actions/16/help-donate-inr.svg
  icons-dark/actions/16/help-donate-jpy.svg
  icons-dark/actions/16/help-donate-mxn.svg
  icons-dark/actions/16/help-donate-pln.svg
  icons-dark/actions/16/help-donate-rub.svg
  icons-dark/actions/16/help-donate-sek.svg
  icons-dark/actions/16/help-donate-try.svg
  icons-dark/actions/16/help-donate-uah.svg
  icons-dark/actions/16/help-donate-usd.svg
  icons/actions/16/help-donate-ars.svg
  icons/actions/16/help-donate-aud.svg
  icons/actions/16/help-donate-brl.svg
  icons/actions/16/help-donate-cad.svg
  icons/actions/16/help-donate-chf.svg
  icons/actions/16/help-donate-cny.svg
  icons/actions/16/help-donate-eur.svg
  icons/actions/16/help-donate-gbp.svg
  icons/actions/16/help-donate-inr.svg
  icons/actions/16/help-donate-jpy.svg
  icons/actions/16/help-donate-mxn.svg
  icons/actions/16/help-donate-pln.svg
  icons/actions/16/help-donate-rub.svg
  icons/actions/16/help-donate-sek.svg
  icons/actions/16/help-donate-try.svg
  icons/actions/16/help-donate-uah.svg
  icons/actions/16/help-donate-usd.svg

To: ndavis, #vdg, sitter, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ff72016e444c: Make Breeze Dark use same Kolourpaint icon 
as Breeze (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21521?vs=58977=58998

REVISION DETAIL
  https://phabricator.kde.org/D21521

AFFECTED FILES
  icons-dark/apps/48/kolourpaint.svg
  icons/apps/48/kolourpaint.svg

To: ndavis, #vdg, filipf, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21526: Add help-donate-[currency] icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  donate-currency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21526

To: ndavis, #vdg, sitter, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21523: Add 22px notifications icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:cdd90177d393: Add 22px notifications icons (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21523?vs=58983=58997

REVISION DETAIL
  https://phabricator.kde.org/D21523

AFFECTED FILES
  icons-dark/actions/22/notifications-disabled.svg
  icons-dark/actions/22/notifications.svg
  icons/actions/22/notifications-disabled.svg
  icons/actions/22/notifications.svg

To: ndavis, #vdg, filipf, ngraham
Cc: ngraham, filipf, kde-frameworks-devel, michaelh, bruns

D21523: Add 22px notifications icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  notifications-22px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21523

To: ndavis, #vdg, filipf, ngraham
Cc: ngraham, filipf, kde-frameworks-devel, michaelh, bruns

D21523: Add 22px notifications icons

[Noah Davis]

ndavis added a comment.


  done

REPOSITORY
  R266 Breeze Icons

BRANCH
  notifications-22px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21523

To: ndavis, #vdg, filipf, ngraham
Cc: ngraham, filipf, kde-frameworks-devel, michaelh, bruns

D21526: Add help-donate-[currency] icons

[Noah Davis]

ndavis retitled this revision from "Add more help-donate currencies" to "Add 
help-donate-[currency] icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21526

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21526: Add more help-donate currencies

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21526

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21526: Add more help-donate currencies

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  These are only 16px icons.
  According to the bug report, these will be used in the application menu, 
which shows 16px icons. 
  22px versions can be added later. 
  FEATURE: 407372

REPOSITORY
  R266 Breeze Icons

BRANCH
  donate-currency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21526

AFFECTED FILES
  icons-dark/actions/16/help-donate-ars.svg
  icons-dark/actions/16/help-donate-aud.svg
  icons-dark/actions/16/help-donate-brl.svg
  icons-dark/actions/16/help-donate-cad.svg
  icons-dark/actions/16/help-donate-chf.svg
  icons-dark/actions/16/help-donate-cny.svg
  icons-dark/actions/16/help-donate-eur.svg
  icons-dark/actions/16/help-donate-gbp.svg
  icons-dark/actions/16/help-donate-inr.svg
  icons-dark/actions/16/help-donate-jpy.svg
  icons-dark/actions/16/help-donate-mxn.svg
  icons-dark/actions/16/help-donate-pln.svg
  icons-dark/actions/16/help-donate-rub.svg
  icons-dark/actions/16/help-donate-sek.svg
  icons-dark/actions/16/help-donate-try.svg
  icons-dark/actions/16/help-donate-uah.svg
  icons-dark/actions/16/help-donate-usd.svg
  icons/actions/16/help-donate-ars.svg
  icons/actions/16/help-donate-aud.svg
  icons/actions/16/help-donate-brl.svg
  icons/actions/16/help-donate-cad.svg
  icons/actions/16/help-donate-chf.svg
  icons/actions/16/help-donate-cny.svg
  icons/actions/16/help-donate-eur.svg
  icons/actions/16/help-donate-gbp.svg
  icons/actions/16/help-donate-inr.svg
  icons/actions/16/help-donate-jpy.svg
  icons/actions/16/help-donate-mxn.svg
  icons/actions/16/help-donate-pln.svg
  icons/actions/16/help-donate-rub.svg
  icons/actions/16/help-donate-sek.svg
  icons/actions/16/help-donate-try.svg
  icons/actions/16/help-donate-uah.svg
  icons/actions/16/help-donate-usd.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21523: Add 22px notifications icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  notifications-22px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21523

AFFECTED FILES
  icons-dark/actions/22/notifications-disabled.svg
  icons-dark/actions/22/notifications.svg
  icons/actions/22/notifications-disabled.svg
  icons/actions/22/notifications.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21523: Add 22px notifications icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21523

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21521

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21521

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

ndavis updated this revision to Diff 58977.
ndavis added a comment.


  - Stop top edge of wood from bleeding around the colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21521?vs=58975=58977

BRANCH
  kolourpaint-app (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21521

AFFECTED FILES
  icons-dark/apps/48/kolourpaint.svg
  icons/apps/48/kolourpaint.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21521

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21521

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For a while now, Breeze Dark icons have had a different Kolourpaint icon. I 
think the Breeze version looks better and has better contrast, plus it's good 
to use consistent icons.
  
  Also, reduce size and format code

REPOSITORY
  R266 Breeze Icons

BRANCH
  kolourpaint-app (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21521

AFFECTED FILES
  icons-dark/apps/48/kolourpaint.svg
  icons/apps/48/kolourpaint.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21511: Make falkon icon a real SVG

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ac701bd091cf: Make falkon icon a real SVG (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21511?vs=58944=58948

REVISION DETAIL
  https://phabricator.kde.org/D21511

AFFECTED FILES
  icons-dark/apps/48/falkon.svg
  icons/apps/48/falkon.svg

To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fb8f02de76d5: Make Breeze Light/Dark use more system 
colors (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21378?vs=58575=58880

REVISION DETAIL
  https://phabricator.kde.org/D21378

AFFECTED FILES
  src/desktoptheme/breeze-dark/colors
  src/desktoptheme/breeze-light/colors

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  @mart If you're not opposed to this patch, I'll go ahead and land this.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  In D21378#469607 , @filipf wrote:
  
  > So I have a light widget color scheme, but I want to be using a dark Plasma 
theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't 
respect my colors. So this is a good solution, +1 for the idea.
  >
  > I gave it a quick spin with Breeze Dark however and it's just not picking 
up some color schemes. It remains stuck on the colors of some previous scheme 
that worked. This seems to be random and may be a bug originating elsewhere so 
I'm hitting accept.
  
  
  After changing the system colorscheme, did you try restarting plasmashell or 
switching to a different desktop theme and switching back?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  In D21378#469525 , @lavender wrote:
  
  > In D21378#469517 , @mart wrote:
  >
  > > the idea is kinda nice and with some schemes it will work just perfect...
  > >  however i think it risks a lot of having loss in contrast on certain 
color schems with your patch try for instance breezedark and the honeycomb 
system theme, the current task highlight would probably almost disappear
  >
  >
  > This is bringing it in line with Breeze Light which already has the color 
schemes influencing the taskbar color. I tested with honeycomb and it seemed to 
work fine.
  
  
  Actually, Breeze Light should have had the same problem as Breeze Dark. It's 
Breeze that should have already been adapting to the system colorscheme because 
it didn't have any colors defined.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Requested in T8755 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

AFFECTED FILES
  src/desktoptheme/breeze-dark/colors
  src/desktoptheme/breeze-light/colors

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2847d7c8716c: Symlink arrow-*-double to go-*-skip, add 
24px go-*-skip (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21084?vs=57767=58331

REVISION DETAIL
  https://phabricator.kde.org/D21084

AFFECTED FILES
  icons-dark/actions/16/arrow-down-double.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/arrow-up-double.svg
  icons-dark/actions/22/arrow-down-double.svg
  icons-dark/actions/22/arrow-left-double.svg
  icons-dark/actions/22/arrow-right-double.svg
  icons-dark/actions/22/arrow-up-double.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/go-down-skip.svg
  icons-dark/actions/24/go-next-skip.svg
  icons-dark/actions/24/go-previous-skip.svg
  icons-dark/actions/24/go-up-skip.svg
  icons-dark/actions/32/arrow-down-double.svg
  icons-dark/actions/32/arrow-left-double.svg
  icons-dark/actions/32/arrow-right-double.svg
  icons-dark/actions/32/arrow-up-double.svg
  icons/actions/16/arrow-down-double.svg
  icons/actions/16/arrow-left-double.svg
  icons/actions/16/arrow-right-double.svg
  icons/actions/16/arrow-up-double.svg
  icons/actions/22/arrow-down-double.svg
  icons/actions/22/arrow-left-double.svg
  icons/actions/22/arrow-right-double.svg
  icons/actions/22/arrow-up-double.svg
  icons/actions/24/arrow-down-double.svg
  icons/actions/24/arrow-left-double.svg
  icons/actions/24/arrow-right-double.svg
  icons/actions/24/arrow-up-double.svg
  icons/actions/24/go-down-skip.svg
  icons/actions/24/go-next-skip.svg
  icons/actions/24/go-previous-skip.svg
  icons/actions/24/go-up-skip.svg
  icons/actions/32/arrow-down-double.svg
  icons/actions/32/arrow-left-double.svg
  icons/actions/32/arrow-right-double.svg
  icons/actions/32/arrow-up-double.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21264: Display accurate status message during installation

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

To: ngraham, #vdg, #frameworks, ndavis

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2078a10ea1b0: Change input-* device icon styles, add 16px 
icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20708?vs=58047=58138

REVISION DETAIL
  https://phabricator.kde.org/D20708

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/devices/16/input-keyboard-virtual.svg
  icons-dark/devices/16/input-keyboard.svg
  icons-dark/devices/16/input-mouse.svg
  icons-dark/devices/16/input-touchpad.svg
  icons-dark/devices/22/input-keyboard-virtual.svg
  icons-dark/devices/22/input-keyboard.svg
  icons-dark/devices/22/input-mouse.svg
  icons/actions/16/configure-shortcuts.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/22/dialog-input-devices.svg
  icons/devices/16/input-keyboard-virtual.svg
  icons/devices/16/input-keyboard.svg
  icons/devices/16/input-mouse.svg
  icons/devices/16/input-touchpad.svg
  icons/devices/22/input-keyboard-virtual.svg
  icons/devices/22/input-keyboard.svg
  icons/devices/22/input-mouse.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21218: Create new icon for Knights based on Anjuta's icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Once you've optimized the SVGs, I'll approve this.
  
  
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Noah Davis]

ndavis added a comment.


  In D21218#465340 , @ognarb wrote:
  
  > Why not mirror the Anjuta icon and use the same background color as the 
original Knights icon? So that it looks closer to the original.
  
  
  I think this is probably better and might prevent confusion for existing 
Knights users.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis updated this revision to Diff 58047.
ndavis added a comment.


  Add new dialog-input-devices icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20708?vs=56657=58047

BRANCH
  input-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20708

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/devices/16/input-keyboard-virtual.svg
  icons-dark/devices/16/input-keyboard.svg
  icons-dark/devices/16/input-mouse.svg
  icons-dark/devices/16/input-touchpad.svg
  icons-dark/devices/22/input-keyboard-virtual.svg
  icons-dark/devices/22/input-keyboard.svg
  icons-dark/devices/22/input-mouse.svg
  icons/actions/16/configure-shortcuts.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/22/dialog-input-devices.svg
  icons/devices/16/input-keyboard-virtual.svg
  icons/devices/16/input-keyboard.svg
  icons/devices/16/input-mouse.svg
  icons/devices/16/input-touchpad.svg
  icons/devices/22/input-keyboard-virtual.svg
  icons/devices/22/input-keyboard.svg
  icons/devices/22/input-mouse.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#464824 , @ngraham wrote:
  
  > In practice, the thumbnail delegates are much smaller; is anyone gonna 
notice that (famous last words)?
  
  
  If you and anyone else reviewing this patch thinks it's OK, I'll just remove 
the radius for simplicity and consistency, but you seemed like you didn't want 
small bits of whiteness in the corners:
  
  In D20140#440989 , @ngraham wrote:
  
  > It's probably going to be more noticeable for High DPI users. It seems like 
there must be a way to fix this rather than just removing the thumbnail radius.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis added a comment.


  In D20708#454298 , @ngraham wrote:
  
  > Even if only Inkscape currently uses the icon, as a rule we ignore that 
kind of information for code/content in Frameworks, because //in principle// 
any app could use it. It's more important for the icon to be semantically 
correct for any app that  wants to use it than it is for it to match its 
current sole user.
  >
  > For `dialog-input-devices`, I would accept an icon that //includes// a 
drawing tablet, but not one that has //only// a drawing tablet.
  
  
  How is this? 16px F6819133: Screenshot_20190511_114329.png 

  
  I tried making the mouse bigger, but it didn't work out very well since there 
was never quite enough room to make it feel balanced.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#458379 , @filipf wrote:
  
  > Which still leaves you with fixing the gaps when there's not thumbnail. I'd 
suggest to do:
  >
  > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  >
  > and call it a day :P
  >
  > F6800961: image.png 
  
  
  Unfortuantely, that still leaves small white corners on the thumbnails that 
don't take up the entire area. F6819109: Screenshot_20190511_13.png 

  
  I still don't t

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The arrow-*-double icons were symlinked to the go-top/bottom/first/last 
icons. Those didn't look like double arrows, so the arrow-*-double icons are 
now symlinked to go-*-skip.
  
  A previous commit with this change was reverted because there weren't any 
24px go-*-skip icons, so this patch also includes the missing icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arrows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21084

AFFECTED FILES
  icons-dark/actions/16/arrow-down-double.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/arrow-up-double.svg
  icons-dark/actions/22/arrow-down-double.svg
  icons-dark/actions/22/arrow-left-double.svg
  icons-dark/actions/22/arrow-right-double.svg
  icons-dark/actions/22/arrow-up-double.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/go-down-skip.svg
  icons-dark/actions/24/go-next-skip.svg
  icons-dark/actions/24/go-previous-skip.svg
  icons-dark/actions/24/go-up-skip.svg
  icons-dark/actions/32/arrow-down-double.svg
  icons-dark/actions/32/arrow-left-double.svg
  icons-dark/actions/32/arrow-right-double.svg
  icons-dark/actions/32/arrow-up-double.svg
  icons/actions/16/arrow-down-double.svg
  icons/actions/16/arrow-left-double.svg
  icons/actions/16/arrow-right-double.svg
  icons/actions/16/arrow-up-double.svg
  icons/actions/22/arrow-down-double.svg
  icons/actions/22/arrow-left-double.svg
  icons/actions/22/arrow-right-double.svg
  icons/actions/22/arrow-up-double.svg
  icons/actions/24/arrow-down-double.svg
  icons/actions/24/arrow-left-double.svg
  icons/actions/24/arrow-right-double.svg
  icons/actions/24/arrow-up-double.svg
  icons/actions/24/go-down-skip.svg
  icons/actions/24/go-next-skip.svg
  icons/actions/24/go-previous-skip.svg
  icons/actions/24/go-up-skip.svg
  icons/actions/32/arrow-down-double.svg
  icons/actions/32/arrow-left-double.svg
  icons/actions/32/arrow-right-double.svg
  icons/actions/32/arrow-up-double.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21084

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

[Noah Davis]

ndavis added a comment.


  Whoops. Forgot there were no 24px go-*-skip icons. I'll have to fix that and 
then the patch will work.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21063

To: ndavis, #vdg, ngraham
Cc: jriddell, kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:04be2a08ab1b: Symlink arrow-*-double to go-*-skip 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21063?vs=57700=57723

REVISION DETAIL
  https://phabricator.kde.org/D21063

AFFECTED FILES
  icons-dark/actions/16/arrow-down-double.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/arrow-up-double.svg
  icons-dark/actions/22/arrow-down-double.svg
  icons-dark/actions/22/arrow-left-double.svg
  icons-dark/actions/22/arrow-right-double.svg
  icons-dark/actions/22/arrow-up-double.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/32/arrow-down-double.svg
  icons-dark/actions/32/arrow-left-double.svg
  icons-dark/actions/32/arrow-right-double.svg
  icons-dark/actions/32/arrow-up-double.svg
  icons/actions/16/arrow-down-double.svg
  icons/actions/16/arrow-left-double.svg
  icons/actions/16/arrow-right-double.svg
  icons/actions/16/arrow-up-double.svg
  icons/actions/22/arrow-down-double.svg
  icons/actions/22/arrow-left-double.svg
  icons/actions/22/arrow-right-double.svg
  icons/actions/22/arrow-up-double.svg
  icons/actions/24/arrow-down-double.svg
  icons/actions/24/arrow-left-double.svg
  icons/actions/24/arrow-right-double.svg
  icons/actions/24/arrow-up-double.svg
  icons/actions/32/arrow-down-double.svg
  icons/actions/32/arrow-left-double.svg
  icons/actions/32/arrow-right-double.svg
  icons/actions/32/arrow-up-double.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21063

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Previously, the arrow-*-double icons were symlinked to 
go-top/bottom/first/last icons, which aren't really double arrows. go-*-skip 
icons are real double arrows.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arrows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21063

AFFECTED FILES
  icons-dark/actions/16/arrow-down-double.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/arrow-up-double.svg
  icons-dark/actions/22/arrow-down-double.svg
  icons-dark/actions/22/arrow-left-double.svg
  icons-dark/actions/22/arrow-right-double.svg
  icons-dark/actions/22/arrow-up-double.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/32/arrow-down-double.svg
  icons-dark/actions/32/arrow-left-double.svg
  icons-dark/actions/32/arrow-right-double.svg
  icons-dark/actions/32/arrow-up-double.svg
  icons/actions/16/arrow-down-double.svg
  icons/actions/16/arrow-left-double.svg
  icons/actions/16/arrow-right-double.svg
  icons/actions/16/arrow-up-double.svg
  icons/actions/22/arrow-down-double.svg
  icons/actions/22/arrow-left-double.svg
  icons/actions/22/arrow-right-double.svg
  icons/actions/22/arrow-up-double.svg
  icons/actions/24/arrow-down-double.svg
  icons/actions/24/arrow-left-double.svg
  icons/actions/24/arrow-right-double.svg
  icons/actions/24/arrow-up-double.svg
  icons/actions/32/arrow-down-double.svg
  icons/actions/32/arrow-left-double.svg
  icons/actions/32/arrow-right-double.svg
  icons/actions/32/arrow-up-double.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19812: Add a web page to view and compare icons of different sizes

[Noah Davis]

ndavis added a comment.


  In D19812#455478 , @ngraham wrote:
  
  > TBH I wonder how useful this actually is. Hopefully some of the other folks 
involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on 
whether or not this would be useful for them.
  
  
  If I can link directly to a specific icon on that page, it can be useful for 
showing icons to others rather than only calling the icon by its name (e.g., 
`list-add`).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, 
michaelh, bruns

D20825: Fix wrong group names for 22, 32 px in audio.svg

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:176643f48c84: Fix wrong group names for 22, 32 px in 
audio.svg (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20825?vs=56984=56985

REVISION DETAIL
  https://phabricator.kde.org/D20825

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg

To: ndavis, #vdg, #plasma, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20825: Fix wrong group names for 22, 32 px in audio.svg

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Before this fix, the system tray audio widget would try to use the 32px icons 
where 22px icons should be used.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20825

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Noah Davis]

ndavis added a comment.


  More like center version in this SVG:
  F6788395: paint-none.svg.2019_04_23_05_53_37.0.svg 

  
  F6788396: Screenshot_20190423_055953.png 

  
  Notice how the lines appear to have a thickness more similar to the square 
outline above while the original version on the right appears to be thicker.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20693: Remove pixelated border

[Noah Davis]

ndavis added a comment.


  +1 for the change to the large thumbnail, but I think the smaller thumbnails 
need something to show that they can be clicked.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b5ec56091ed3: Add more icon sizes for audio, configure, 
distribute (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20695?vs=56622=56738

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Noah Davis]

ndavis added a comment.


  The 22px version needs to have 1px thick lines and 3px margins on each side.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20700: Add "edit-remove" icon symlink

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I'll accept this if you also make 22px versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis added a comment.


  Actually, `dialog-input-devices` is used by inkscape for configuring pointing 
devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show 
more types of devices, it would be more accurate to use a tablet. Looking at 
the Input Devices dock in Inkscape, it doesn't seem like it would be used much 
for configuring mice, so it might be better if it was just a symlink to the 
`input-tablet` icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis added a comment.


  In D20708#453690 , @ngraham wrote:
  
  > Overall very nice.
  >
  > Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it 
might make more sense to rename `dialog-input-devices` to be `input-mouse` and 
then change the `dialog-input-devices` so that it depicts more than one input 
device, to reinforce its name. Maybe a mouse + keyboard?
  
  
  I don't think I can fit a whole keyboard, but I can probably fit a numpad.
  
  > While you're thinking about input device icons, we also have a few 
outstanding bugs:
  > 
  > - The colorful version of the mouse icon is hard to see on a dark 
background, and also it maybe should have a more generic appearance rather than 
looking like a Razer mouse: https://bugs.kde.org/show_bug.cgi?id=406453
  
  That will be a lot of work and I don't want to do that in this diff since 
it'll slow the rest of the changes down considerably. The most important change 
in this diff is that this is fixed (22px icon where 16px should be): F6786267: 
Screenshot_20190421_215747.png 
  
  > - We need a joystick icon that actually looks like a joystick: 
https://bugs.kde.org/show_bug.cgi?id=406679
  
  I'll do that with the 64px mouse icon fix when I get around to it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20700: Add "edit-remove" icon symlink

[Noah Davis]

ndavis added a comment.


  In D20700#453565 , @GB_2 wrote:
  
  > `list-remove` is just a minus icon, which has no context and looks weird 
when used alone, without `list-add` next to it. An example where the new icon 
can be used is D20576 .
  
  
  We have a problem where we don't use consistent iconography for "remove". 
Sometimes it's a normal minus, sometimes it's a red minus, sometimes it's a red 
X and sometimes it's a red trash can (the line between "delete" and "remove" 
can be blurry). I think adding an `edit-remove` icon would likely cause more 
confusion, first for developers and then for users. I don't think using a minus 
without a plus is a problem, but perhaps the minus should be made red?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  `devices/16` was missing some `input-*` icons.
  `input-keyboard-virtual` looked more like a wireless keyboard than a virtual 
keyboard. 
  Changed `input-keyboard*` style so that it could appear consistent at 16 and 
22px. It also looks a bit more like a real keyboard. 
  Made `configure-shortcuts` icon look good at 16px.

REPOSITORY
  R266 Breeze Icons

BRANCH
  input-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20708

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/devices/16/input-keyboard-virtual.svg
  icons-dark/devices/16/input-keyboard.svg
  icons-dark/devices/16/input-mouse.svg
  icons-dark/devices/16/input-touchpad.svg
  icons-dark/devices/22/input-keyboard-virtual.svg
  icons-dark/devices/22/input-keyboard.svg
  icons-dark/devices/22/input-mouse.svg
  icons/actions/16/configure-shortcuts.svg
  icons/devices/16/input-keyboard-virtual.svg
  icons/devices/16/input-keyboard.svg
  icons/devices/16/input-mouse.svg
  icons/devices/16/input-touchpad.svg
  icons/devices/22/input-keyboard-virtual.svg
  icons/devices/22/input-keyboard.svg
  icons/devices/22/input-mouse.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink

[Noah Davis]

ndavis added a comment.


  Why does `list-remove` need an alternative?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis updated this revision to Diff 56622.
ndavis added a comment.


  Fix 16-16-audio-volume-muted

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20695?vs=56621=56622

BRANCH
  add-new-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis updated this revision to Diff 56621.
ndavis added a comment.


  Add 16px audio icons

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20695?vs=56619=56621

BRANCH
  add-new-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis planned changes to this revision.
ndavis added a comment.


  Oops, looks like I need 16px audio icons as well for the volume/mute icons 
inside the opened audio widget.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The tooltip for the audio system tray widget and panel edit mode had blurry 
versions of these icons because the icons were being scaled to fit.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  add-new-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20672: Add an icon for Thunderbolt KCM

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis, ngraham
Cc: abetts, ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Actually, one last thing. Can you save it as a plain SVG so that it isn't 
filled with Inkscape metadata?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis, ngraham
Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I like the new top color.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis, ngraham
Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  A few problems:
  
  1. That circle has a diameter of 27.9px instead of 28px
  2. There is no copy of the icon in `icons-dark/preferences/32/`
  3. The top of the gradient is transparent, which leads to issues like this: 
F6781897: Screenshot_20190419_055439.png 
  
  The lightning bolt is not aligned to the pixel grid, but it's really not that 
bad at 100% size. TBH, I don't think it's worth the effort required to align 
it. F6781885: Screenshot_20190419_054910.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis
Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bd8264e92869: Update audio, drive, edit, go, list, media, 
plasmavault icons to match breeze… (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20623?vs=56407=56464

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis added a comment.


  One concern:
  
  Previously, the `go-up` icon in `go.svg` used a completely different style 
from the other `go-*` icons. Does anyone know why that was? I can't find any 
reason for it to use a different style.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0ff81fe4c728: Align zs to pixel grid in system.svg 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20597?vs=56356=56365

REVISION DETAIL
  https://phabricator.kde.org/D20597

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20597

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This does the same thing as D20586 , but 
for the Breeze desktop theme

TEST PLAN
  Looks exactly the same as D20586 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20597

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:db9fdceac1ac: Sharpen Zs in system-suspend* icons 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20586?vs=56331=56355

REVISION DETAIL
  https://phabricator.kde.org/D20586

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  They weren't aligned to the pixel grid before.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sharp-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20586

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#450349 , @GB_2 wrote:
  
  > Ping
  
  
  Sorry, I'm just busy right now and I'm not that familiar with QML, so it 
won't be quick and easy for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20426: Improve "widget-alternatives" icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I can't think of any more suggestions that would be an obvious improvement, 
so I'll accept this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns