D24726: Fix null pointer reference when extraction fails

2019-11-01 Thread Pekka Vuorela 
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:8222caed9367: Fix null pointer reference when extraction 
fails (authored by pvuorela).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24726?vs=69086=69148

REVISION DETAIL
  https://phabricator.kde.org/D24726

AFFECTED FILES
  src/karchive.cpp

To: pvuorela, davidllewellynjones, dfaure, aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

2019-10-31 Thread Pekka Vuorela 
pvuorela added a comment.


  Haven't looked and to be honest a little skeptical if anyone removing a null 
check is likely enough to protect against.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24726

To: pvuorela, davidllewellynjones, dfaure, aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

2019-10-31 Thread Pekka Vuorela 
pvuorela added reviewers: davidllewellynjones, dfaure, aacid.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24726

To: pvuorela, davidllewellynjones, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

2019-10-31 Thread Pekka Vuorela 
pvuorela updated this revision to Diff 69086.
pvuorela added a comment.


  Also remove the empty target file on error

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24726?vs=68119=69086

BRANCH
  upstream_master

REVISION DETAIL
  https://phabricator.kde.org/D24726

AFFECTED FILES
  src/karchive.cpp

To: pvuorela
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

2019-10-17 Thread Pekka Vuorela 
pvuorela created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pvuorela requested review of this revision.

REPOSITORY
  R243 KArchive

BRANCH
  null_check

REVISION DETAIL
  https://phabricator.kde.org/D24726

AFFECTED FILES
  src/karchive.cpp

To: pvuorela
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns