D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-29 Thread Phil Young
phily updated this revision to Diff 44457.
phily added a comment.


  - Added JCL test program as well as fixing recommendations (no hard coded 
colors)
  - Added new highlighting of steps (vs program options)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44454&id=44457

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/input/test.jcl
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-29 Thread Phil Young
phily updated this revision to Diff 44454.
phily added a comment.


  Adding test file for JCL and making removing hard coded colors.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44277&id=44454

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/input/test.jcl
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16416: z/OS CLIST file syntax highlighting

2018-10-29 Thread Phil Young
phily added a comment.


  In D16416#349335 <https://phabricator.kde.org/D16416#349335>, @cullmann wrote:
  
  > To properly push it with you as author, what is your full name + mail 
address?
  
  
  Phil Young
  mainframed...@gmail.com
  
  (I'm assuming you meant email address)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young
phily updated this revision to Diff 44283.
phily added a comment.


  Removed typo in test script

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44282&id=44283

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44282.
phily added a comment.


  Did not include the syntax file itself in my last update, now the diff 
includes both.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44281&id=44282

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44281.
phily added a comment.


  Added test file to autotests/input/test.rexx as well as upgrading the version 
number

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44180&id=44281

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16416: z/OS CLIST file syntax highlighting

2018-10-26 Thread Phil Young
phily added a comment.


  Example CLIST can be viewed here: 
https://gist.githubusercontent.com/mainframed/9e9c85b7a13186e7ca51b5b47d90b575/raw/1e19fede7d203585b213d2f20700ed08baac9e07/protall.clist
  
  Looking at the code repo I wasn't sure exactly where to include the code 
examples.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16416: z/OS CLIST file syntax highlighting

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44278.
phily marked 5 inline comments as done.
phily added a comment.


  Fixing issues noted by reviewer

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16416?vs=44182&id=44278

REVISION DETAIL
  https://phabricator.kde.org/D16416

AFFECTED FILES
  data/syntax/clist.xml

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-26 Thread Phil Young
phily marked an inline comment as done.
phily added a comment.


  Thank you for the feedback. I've gone and updated the syntax file to explain 
what JCL is and remove the `^` from the regex. Thank you for the suggestions.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44277.
phily marked an inline comment as done.
phily added a comment.


  Making changes based on reviewer comments.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44181&id=44277

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16416: z/OS CLIST file syntax highlighting

2018-10-24 Thread Phil Young
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.

REVISION SUMMARY
  There was no support for CLIST syntax highlighting so I decided to create 
this file to add support.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

AFFECTED FILES
  data/syntax/clist.xml

To: phily, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-24 Thread Phil Young
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.

REVISION SUMMARY
  There is currently no support for JCL (Job Control Language) syntax 
highlighting. This XML file adds that support.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-24 Thread Phil Young
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.

REVISION SUMMARY
  The rexx syntax highlighting was incomplete. It was missing keywords, sub 
keywords and control flow keywords.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann