Re: Review Request 128652: Fix wording an -> one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128652/#review98307 --- Ship it! Ship It! - Ragnar Thomsen On Aug. 10, 2016, 8:27 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128652/ > --- > > (Updated Aug. 10, 2016, 8:27 p.m.) > > > Review request for KDE Frameworks, KDE Utils, Ragnar Thomsen, and Valentin > Rusu. > > > Repository: kwallet > > > Description > --- > > Change "Please set-up at least an encryption key" to "Please set-up at least > one encryption key" as requested in RR > https://git.reviewboard.kde.org/r/128378/ > > > Diffs > - > > src/runtime/kwalletd/knewwalletdialog.cpp f0c1b36 > > Diff: https://git.reviewboard.kde.org/r/128652/diff/ > > > Testing > --- > > builds > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97747 --- Ship it! This is much better, thanks :) - Ragnar Thomsen On July 20, 2016, 3:01 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128490/ > --- > > (Updated July 20, 2016, 3:01 p.m.) > > > Review request for KDE Frameworks and KDE Usability. > > > Repository: kio > > > Description > --- > > Follow up of RR [128283](https://git.reviewboard.kde.org/r/128283/) and in > particular [128466](https://git.reviewboard.kde.org/r/128466/). This patch > replaces the "Share" groupbox with a vertical separator. > > Don't forget that there is also RR > [128413](https://git.reviewboard.kde.org/r/128413/) pending ;) > > > Diffs > - > > src/widgets/checksumswidget.ui 03c64db > src/widgets/kpropertiesdialog.cpp 808765c > > Diff: https://git.reviewboard.kde.org/r/128490/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png > > > Thanks, > > Elvis Angelaccio > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128466: Rename Checksums tab to Integrity
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97484 --- Ship it! Ship It! - Ragnar Thomsen On July 16, 2016, 2:35 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128466/ > --- > > (Updated July 16, 2016, 2:35 p.m.) > > > Review request for KDE Frameworks, KDE Usability and Dominik Haumann. > > > Repository: kio > > > Description > --- > > Dominik suggested to rename the `Checksums` tab to `Integrity`, so that we > can "free" the Checksums string and use it as the title of the groupbox below > (in place of the current `Share` string, which can be confusing). > > Preview in the attached screenshot. > > > Diffs > - > > src/widgets/checksumswidget.ui 03c64db > src/widgets/kpropertiesdialog.cpp 808765c > > Diff: https://git.reviewboard.kde.org/r/128466/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/6771ed06-c803-4d18-abe3-91e4f97c8c76__checksums-tab.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/b2cd12c8-6bbf-4123-9e8e-59cb0c29cbdb__Spectacle.TJ7614.png > > > Thanks, > > Elvis Angelaccio > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 15, 2016, 4:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and Elvis Angelaccio. Changes --- Submitted with commit 981585082d2a6a79fc8c9cceb2d8cacb324930b9 by Ragnar Thomsen to branch master. Repository: kwidgetsaddons Description --- We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. To see the crash, clone the newAddDialog branch of Ark and run the autotests. This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer. Diffs - autotests/CMakeLists.txt 4be2eaf autotests/kcollapsiblegroupbox_test.h PRE-CREATION autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 15, 2016, 6:13 p.m.) Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and Elvis Angelaccio. Changes --- Connect to deleteLater() directly, instead of using lambda function. Thanks Broulik :) Repository: kwidgetsaddons Description --- We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. To see the crash, clone the newAddDialog branch of Ark and run the autotests. This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer. Diffs (updated) - autotests/CMakeLists.txt 4be2eaf autotests/kcollapsiblegroupbox_test.h PRE-CREATION autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128283: Add checksums tab to the properties dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review97237 --- Another post-commit suggestion: - The "Share" label is not obvious to me. This was also pointed out by another user on the [blog post](http://www.aelog.org/checksums-made-easy). Something like "Calculated checksums" would make more sense. Also +1 for adding "Copy" buttons right of the checksums. And apologies for not suggesting this before it was committed. - Ragnar Thomsen On July 8, 2016, 3:51 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128283/ > --- > > (Updated July 8, 2016, 3:51 p.m.) > > > Review request for KDE Frameworks, KDE Usability and David Faure. > > > Repository: kio > > > Description > --- > > This patch adds a Checksums tab in the properties dialog, where the user can > retrieve and verify the most popular checksum algorithms (md5, sha1 and > sha256). > > To simplify the implementation, the checksums are computed as soon as the > user opens the dialog. This can take a while if the file is huge (in > particular with sha256), but the computation happens in another thread and in > practice this should not be a performance problem. > > The tab is available only for readable local files (no simlinks) and only > when there is a single selection. > > Please note that some of the labels in the screenshots are clipped due to a > bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426 > > > Diffs > - > > src/widgets/CMakeLists.txt f906577 > src/widgets/checksumswidget.ui PRE-CREATION > src/widgets/kpropertiesdialog.cpp d0a2faa > src/widgets/kpropertiesdialog_p.h c01554e > > Diff: https://git.reviewboard.kde.org/r/128283/diff/ > > > Testing > --- > > * Check whether the computed values match the values from md5sum, sha1sum, > sha256sum. > * Check whether the line edits get a green background if the computed and > expected values match. > * Check whether the line edits get a red background if the computed and > expected values differ. > > > File Attachments > > > MD5 ready to be shared > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png > Default dialog > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png > Mismatch > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png > Match > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/519fa28f-7c7d-4bb4-bd24-622d18d7f2e2__Spectacle.v13222.png > Invalid checksum > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/a243c830-2dc0-4cbd-95e9-8f1684bc86a4__Spectacle.J13336.png > > > Thanks, > > Elvis Angelaccio > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 9, 2016, 1:55 p.m.) Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio. Changes --- Remove tabs from code and add some further comments in unittest. Repository: kwidgetsaddons Description --- We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. To see the crash, clone the newAddDialog branch of Ark and run the autotests. This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer. Diffs (updated) - autotests/CMakeLists.txt 4be2eaf autotests/kcollapsiblegroupbox_test.h PRE-CREATION autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 9, 2016, 1:47 p.m.) Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio. Changes --- Add a unittest which provokes the crash. Repository: kwidgetsaddons Description --- We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. To see the crash, clone the newAddDialog branch of Ark and run the autotests. This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer. Diffs (updated) - autotests/CMakeLists.txt 4be2eaf autotests/kcollapsiblegroupbox_test.h PRE-CREATION autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
> On July 8, 2016, 9:32 p.m., David Faure wrote: > > Can you try to adapt the failing unittest into a new kwidgetsaddons > > unittest, so that this change is unittested here too? Sure :) - Ragnar --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97224 --- On July 8, 2016, 9:29 p.m., Ragnar Thomsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128406/ > --- > > (Updated July 8, 2016, 9:29 p.m.) > > > Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio. > > > Repository: kwidgetsaddons > > > Description > --- > > We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an > autotest involving this widget (see backtrace > [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() > gets called after KCollapsibleGroupBox is deleted. This causes > QTimeLine::stateChanged to get emitted which then calls > KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. > > To see the crash, clone the newAddDialog branch of Ark and run the autotests. > > This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is > running, before deleting the d pointer. > > > Diffs > - > > src/kcollapsiblegroupbox.cpp 0c3f866 > > Diff: https://git.reviewboard.kde.org/r/128406/diff/ > > > Testing > --- > > The autotests in newAddDialog branch of Ark pass with this diff. > > > Thanks, > > Ragnar Thomsen > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 8, 2016, 9:29 p.m.) Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio. Changes --- Fix the link. Repository: kwidgetsaddons Description (updated) --- We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. To see the crash, clone the newAddDialog branch of Ark and run the autotests. This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer. Diffs - src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio. Repository: kwidgetsaddons Description --- We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [https://paste.kde.org/pwcohd64z](here)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. To see the crash, clone the newAddDialog branch of Ark and run the autotests. This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer. Diffs - src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127572: KNewPasswordWidget: override sizeHint()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/#review94244 --- Ship it! Works for me :) - Ragnar Thomsen On April 4, 2016, 3:48 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127572/ > --- > > (Updated April 4, 2016, 3:48 p.m.) > > > Review request for KDE Frameworks, Christoph Feck, David Edmundson, and > Ragnar Thomsen. > > > Repository: kwidgetsaddons > > > Description > --- > > We have an use-case in Ark where the password widget belongs to a vertical > layout within a KCollapsibleGroupBox. > Without this patch, the strength meter bar takes room even if not visible, > resulting in a wasted empty space (see screenshots). > > > Diffs > - > > src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 > src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd > > Diff: https://git.reviewboard.kde.org/r/127572/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png > > > Thanks, > > Elvis Angelaccio > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127548: Take content margins into account when calcuating size hints
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127548/#review94187 --- Ship it! Yes, works perfectly :) - Ragnar Thomsen On April 1, 2016, 5:04 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127548/ > --- > > (Updated April 1, 2016, 5:04 p.m.) > > > Review request for KDE Frameworks and Ragnar Thomsen. > > > Repository: kwidgetsaddons > > > Description > --- > > We set the contentsMargins to be the size of the header ">" arrow. However as > we didn't take this into account with the sizeHint items were slightly > smaller than they should be which led to them being truncated early. > > The test has also been updated to include an example of a case which failed. > > > Diffs > - > > src/kcollapsiblegroupbox.cpp edda7af15af1a91d9af8ba4d7dc807a3f2ee9f28 > tests/kcollapsiblegroupboxtest.cpp ffd7bd0bf6fe02075047d68264aa1c18b948bd46 > > Diff: https://git.reviewboard.kde.org/r/127548/diff/ > > > Testing > --- > > Updated test. > > Rthomsen has a use case in Ark which exhibited this bug, so hopefully he can > test and report back. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: date + releaseinfo in frameworks docbooks
On Thu, Jul 30, 2015 at 12:03 PM, Burkhard Lück lu...@hube-lueck.de wrote: Am Donnerstag, 30. Juli 2015, 11:18:49 schrieb Luigi Toscano: We need to be some rule for that, as I've seen the removal of releaseinfo, which I think is incorrect: http://quickgit.kde.org/?p=ark.gita=commith=fbead443a61b4549c05f49b70d7ee0 1c7345d42b Yes, should be reverted releaseinfo was re-introduced to the man page in this commit: http://quickgit.kde.org/?p=ark.gita=commith=fbadff45df3b3d24c546312ea51c28fd43e4d1d1 B.R. Ragnar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/ --- (Updated May 31, 2015, 12:49 p.m.) Status -- This change has been marked as submitted. Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald Hvaal. Changes --- Submitted with commit 07ea88471e5c610e3239c284875f544bef5059f8 by Ragnar Thomsen to branch master. Repository: kio Description --- This patch fixes an error when loading the DndPopupMenuPlugin of Ark (frameworks branch). DndPopupMenuPlugins use the K_PLUGIN_FACTORY_WITH_JSON macro, and therefore KPluginLoader::factory() should be used instead of KPluginLoader::instance() which is used by KPluginMetaData::instantiate(). The DndPopupMenuPlugin is used by Ark to enable the Extract here menu option when dragging an archive in Dolphin. Diffs - src/widgets/dropjob.cpp 63beb0a Diff: https://git.reviewboard.kde.org/r/123940/diff/ Testing --- The Extract here option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/ --- (Updated May 30, 2015, 2:39 p.m.) Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald Hvaal. Changes --- Check that KPluginFactory-create() returns a valid object. Repository: kio Description --- This patch fixes an error when loading the DndPopupMenuPlugin of Ark (frameworks branch). DndPopupMenuPlugins use the K_PLUGIN_FACTORY_WITH_JSON macro, and therefore KPluginLoader::factory() should be used instead of KPluginLoader::instance() which is used by KPluginMetaData::instantiate(). The DndPopupMenuPlugin is used by Ark to enable the Extract here menu option when dragging an archive in Dolphin. Diffs (updated) - src/widgets/dropjob.cpp 63beb0a Diff: https://git.reviewboard.kde.org/r/123940/diff/ Testing --- The Extract here option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/ --- Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald Hvaal. Repository: kio Description --- This patch fixes an error when loading the DndPopupMenuPlugin of Ark (frameworks branch). DndPopupMenuPlugins use the K_PLUGIN_FACTORY_WITH_JSON macro, and therefore KPluginLoader::factory() should be used instead of KPluginLoader::instance() which is used by KPluginMetaData::instantiate(). The DndPopupMenuPlugin is used by Ark to enable the Extract here menu option when dragging an archive in Dolphin. Diffs - src/widgets/dropjob.cpp 63beb0a Diff: https://git.reviewboard.kde.org/r/123940/diff/ Testing --- The Extract here option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
