D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  Yes, tested and it works.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, 
#ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns, demsking, 
cullmann, sars

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  Would someone please land this for me? Thanks.

REPOSITORY
  R39 KTextEditor

BRANCH
  Bug372503 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks, 
michaelh, kevinapavew, bruns, demsking, cullmann, sars

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron marked 4 inline comments as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: rkron, mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, 
michaelh, kevinapavew, bruns, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron edited the summary of this revision.
rkron edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron updated this revision to Diff 31505.
rkron added a comment.


  - Revise patch per review comments.
  
  Added comments and removed code to fix view scrolling inconsistancy
  when dragging over line numbers.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11685?vs=31182=31505

BRANCH
  Bug372503 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11685

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron updated this revision to Diff 31182.
rkron added a comment.


  - Removed two unnecessary lines in patch.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11685?vs=30560=31182

BRANCH
  Bug372503 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11685

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a reviewer: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron edited the summary of this revision.
rkron edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron updated this revision to Diff 30560.
rkron added a comment.


  - Update revision per review comments.
  
  Removed the config option to enable and disable the single-click behavior.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11685?vs=30517=30560

BRANCH
  Bug372503 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11685

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  @ngraham Qt Designer made those changes when I added the checkbox. They will 
be gone with the update. The four files concerning the config option will be as 
they were before this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  And actually, if you have the line modification marker border turned on, 
clicking in it will just move the cursor without selecting the line.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  @ngraham I agree. Single-click is pretty much standard.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  OK. I will remove the option and update the revision. Thanks for the input!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, 
cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  If you think it should be on by default, that's easily done. I know what you 
mean, that nobody would ever find it.
  
  When I first started using Kate, I thought the triple-clicking was very 
annoying. But I got used to it and now it's automatic for me. It also became 
automatic for me to move the cursor to the start of a line by clicking the line 
number. When I started using this patch, I found I was always selecting a line 
when I just wanted to move the cursor. That's why I hesitated to make such a 
big change to this workflow without making it optional.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, 
cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, 
cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron created this revision.
rkron added reviewers: Frameworks, Kate, KTextEditor, ngraham.
Restricted Application added projects: Kate, Frameworks.
rkron requested review of this revision.

REVISION SUMMARY
  Implements selecting entire line of text with a single click on line number.
  
  Introduce a new config setting on the 'Text Navigation' editor config page
  to enable this, disabled by default to retain old behavior.
  
  Also fixes inconsistancy when dragging on line numbers to select multiple
  lines. When dragging in text editor, view would scroll down when you get
  to the top, but view did not scroll when dragging on line numbers.
  
  FEATURE: 372503

TEST PLAN
  With option enabled, check that single click on line number selects line
  the save way that triple-clicking does by default. Check that dragging
  over line numbers selects multiple lines and view scrolls down when
  you get to the top. Check that selecting a line and then Shift+Click
  another line selects all intervening lines. Check that the single click
  behavior can be turned off with the config setting.

REPOSITORY
  R39 KTextEditor

BRANCH
  Bug372503 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11685

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/navigationconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, 
cullmann, sars, dhaumann

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron added a comment.


  @davidedmundson Thanks for the commit!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron added a comment.


  I'm new to phabricator and do not have commit access. Does someone need to 
commit this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron updated this revision to Diff 25540.
rkron added a comment.


  After reviewing the kio commit where similar changes were made, I changed 
QFile::exists to QFileInfo::exists as was done in kio and have updated my 
patch. I should have looked at kio before my first submission. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9928?vs=25487=25540

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron created this revision.
rkron added a reviewer: Frameworks.
rkron added a project: Frameworks.
rkron requested review of this revision.

REVISION SUMMARY
  I found two places in plasma-framework svg.cpp (Plasma::Svg) that were 
triggering this message.
  
  path variable was not being checked for empty before passing to 
QFile::exists().
  
  This seems to be one source of the issue reported in Bug 388389 


TEST PLAN
  Found that kicker was triggering this message and also plasmashell tooltips.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks
Cc: #frameworks