D13128: Make sure ungrab keyboard request is processed before emitting shortcut
sontolbonggol added a comment. @elvisangelaccio you can put my email sonbong...@gmail.com. Thanks! REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: elvisangelaccio, davidedmundson, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns
D13128: Make sure ungrab keyboard request is processed before emitting shortcut
sontolbonggol added a comment. @fvogt I don't have push access. Will appreciate if someone does it for me. Thanks! REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: davidedmundson, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns
D13128: Make sure ungrab keyboard request is processed before emitting shortcut
sontolbonggol added a reviewer: mck182. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182 Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13128: Make sure ungrab keyboard request is processed before emitting shortcut
sontolbonggol edited the summary of this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13128: Make sure ungrab keyboard request is processed before emitting shortcut
sontolbonggol created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. sontolbonggol requested review of this revision. REVISION SUMMARY In some rare cases, the ungrab keyboard request is processed later than the action of the key shortcut. This can make the application that try to grab the keyboard (e.g. in kwin) fail to do so. The solution is to use ungrab_keyboard_checked() and xcb_request_check() before emitting the shortcut signal. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 AFFECTED FILES src/runtime/plugins/xcb/kglobalaccel_x11.cpp To: sontolbonggol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
