D29372: Taiwan: Use "zh_TW" language code

[Weisi Dai]

weisi abandoned this revision.
weisi added a comment.


  Closing this revision. Let's get D29223  
in.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

To: weisi, winterz
Cc: nhiga, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

[Weisi Dai]

weisi abandoned this revision.
weisi added a comment.


  Closing this revision. Let's get D29223  
in.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29373

To: weisi, winterz, cgiboudeaux
Cc: nhiga, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29223: Update Taiwanese holidays

[Weisi Dai]

weisi added a comment.


  Thanks! Looks good :)

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

[Weisi Dai]

weisi added a comment.


  I agree with the general idea in D29223  
and feel D29223  is in a better shape than 
this diff. However, I think some festivals referred to in this diff (not 
mentioned in the law -  紀念日及節日實施辦法 
 - but are still 
special days of interest that many people celebrate) can be adapted into D29223 
.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29373

To: weisi, winterz, cgiboudeaux
Cc: nhiga, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29223: Update Taiwanese holidays

[Weisi Dai]

weisi added a comment.


  I prefer this diff to the changes I took in D29373 
. I wish I had seen this diff earlier.
  
  Would you also indicate the plan for the festivals specified as "2020" in 
this diff for future years? For example, could you add the 2021 dates to this 
diff and show the suggested layout of the code? I plan to replicate this in the 
`cn_zh-cn` file once we agree on how to best handle those.
  
  I like the idea of referring to the law as the source, instead of potential 
unreliable third-party websites. But I wonder if this criteria might be too 
restrictive here:
  
  - On the Spring festival 春節 of 2020, the publicholidays.tw page 
 and the official source listed on 
that page  both showed Jan 
23 to 29 as the days off. Or maybe you just meant to use `length 3 days` 
(instead of `length 5 days`) which is what the law says 
? For the future 
years I only put in the day of the Spring festival in D29373 
 but maybe I should have marked `length 3 
days`.
  - 紀念日及節日實施辦法  as 
a law, may not be able to include many interesting dates - you don't really 
expect a law to change too frequently. So I think some festivals can still be 
put in this file - they are still "//day[s] that may have special significance 
to a fairly large number of people//" (quote from the `/DESIGN` file) after 
all. For example, in my opinion, Freedom of Expression Day 言論自由日 and Double 
Ninth Day 重陽節 (and maybe more) deserve to be put in this list.

INLINE COMMENTS

> holiday_tw_zh-tw:17
> +:name"可選 - 預設為國家名"
> +description "中華民國（臺灣）紀念日及節日"
> +

One more space here.

> holiday_tw_zh-tw:37
> +"農曆除夕"  public cultural on 24 January 2020
> +: Spring festival
> +"春節"  public cultural on 25 January 2020 length 
> 5 days

Uppercase `F`.

> holiday_tw_zh-tw:38
> +: Spring festival
> +"春節"  public cultural on 25 January 2020 length 
> 5 days
> +: Tomb Sweeping Day

Do you intend to use 3 days here?

According to 紀念日及節日實施辦法 
:

> 下列民俗節日，除春節放假三日外，其餘均放假一日... (3 days off for the Spring festival, 1 day off 
> otherwise, for the following...)

> holiday_tw_zh-tw:62
> +
> +"佛陀誕辰紀念日"commemorative on 30 April 2020
> +

I think this one is more religious than commemorative.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29372: Taiwan: Use "zh_TW" language code

[Weisi Dai]

weisi added a comment.


  I think the approach in D29223  (renaming 
the file also) is more preferred.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

To: weisi, winterz
Cc: nhiga, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

[Weisi Dai]

weisi created this revision.
weisi added a reviewer: winterz.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
weisi requested review of this revision.

REVISION SUMMARY
  It's a trivial fix, but this syntax error poped up when I was doing another 
holiday change on KHolidays.
  
  According to Early May Bank Holiday in the United Kingdom 
, this is a 
public holiday, so I'm marking this `public`.

TEST PLAN
  Tested with
  
QT_LOGGING_RULES="*.debug=true" ./bin/testholidayregion -maxwarnings 0 | 
grep 'syntax error'
  
  Seeing no output.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29374

AFFECTED FILES
  holidays/plan2/holiday_gb-sct_en-gb

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

[Weisi Dai]

weisi updated this revision to Diff 81772.
weisi added a comment.


  Renamed "農曆除夕" (//Lunar New Year's eve on Lunar calendar//) to "除夕" (//Lunar 
New Year's eve//). There's no need to specify "lunar calendar" here.

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29373?vs=81770=81772

REVISION DETAIL
  https://phabricator.kde.org/D29373

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

[Weisi Dai]

weisi created this revision.
weisi added a reviewer: winterz.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
weisi requested review of this revision.

REVISION SUMMARY
  The previous revision put in fixed dates (month/day) for many holidays which 
are actually based on the Lunar calendar, instead of the Georgian calendar. 
They are not observed on a fixed date each year.
  
  As a workaround, I put in the dates for the holidays over years 2020 to 2024:
  
  - Chinese New Year's Eve 除夕 *
  - Spring Festival 春節 *
  - Lantern Festival 元宵節 *
  - Matsu's Birthday 媽祖聖誕 *#
  - Buddha's Birthday 佛誕日 *#
  - Chinese Valentine's Day 七夕節 *
  - Double Ninth Day 重陽節 *
  - Dragon Boat Festival 端午節
  - Mid-Autumn Festival 中秋節
  
  The //star *// ones are specified using the "lunar new year date" minus/plus 
some days, hoping to make it easier to adapt to additional years in the future.
  
  There are holidays entries regarding specific arrangements (an extra day is 
observed in lieu of an extra working day) that can't be calculated in advance - 
usually they published early that year. I removed these from future years since 
the arrangement has not been published and I don't want to include holiday 
entries that are too speculative.
  
  I also removed a few religious holidays from the holidays list, simply 
because I think they are not on a fixed date of each Georgian year. 2 of these 
are converted to the format above, as marked with the # sign.
  
  I also specified the start year of Peace Memorial Day 228和平紀念日, and added 
Freedom of Expression Day 言論自由日.
  
  I think there are still issues with the 4 season dates (March Equinox 春分, Jun 
Solstice 夏至, September Equinox 秋分, December Solstice 冬至) but maybe there's some 
better solution for this.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29373

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29372: Taiwan: Use "zh_TW" language code

[Weisi Dai]

weisi added a reviewer: winterz.
weisi added a comment.


  Adding a reviewer to this diff. Thanks!

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29372: Taiwan: Use "zh_TW" language code

[Weisi Dai]

weisi created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
weisi requested review of this revision.

REVISION SUMMARY
  It was set to `tw_zh` which I think is a typo. According to Wikipedia,
  
  > `zh-TW` is the IETF language tag for the Chinese language as used in Taiwan
  
  Also note that HK uses `zh_HK` and CN uses `zh_CN`.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: weisi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns