[Differential] [Commented On] D3830: Add a new FindGperf module
pino added a comment. In https://phabricator.kde.org/D3830#72696, @rjvbb wrote: > In https://phabricator.kde.org/D3830#72508, @pino wrote: > > > For the input file? Yes. > > > I did mean the gperf executable...! I don't get what you mean, sorry :/ The full path of gperf is determined using `find_program`, which looks in `$PATH` -- you can always specify the variable with the full path to force a custom location. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem, #windows, kde-mac Cc: kfunk, rjvbb, adridg
[Differential] [Request, 862 lines] D3883: Generate gperf output at build time
pino created this revision. pino added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Look for gperf, and use it to generate the hash-based lookup for the entities; this replaces the static generated file in the sources, adding a build time only dependency on gperf. This uses the newly added FindGperf.cmake in ECM, see [1]. [1] https://phabricator.kde.org/D3830 TEST PLAN Builds fine as before, and the gperf output in the build directory matches the removed generated source. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D3883 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kcharsets.cpp src/kentities.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks
[Differential] [Commented On] D3830: Add a new FindGperf module
pino added a comment. In https://phabricator.kde.org/D3830#72502, @rjvbb wrote: > You're still determining the location from the path with this new revision, right? For the input file? Yes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem, #windows, kde-mac Cc: kfunk, rjvbb, adridg
[Differential] [Updated, 125 lines] D3830: Add a new FindGperf module
pino updated this revision to Diff 9502. pino added a comment. Typo fix in previous revision. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3830?vs=9499=9502 BRANCH pino-gperf REVISION DETAIL https://phabricator.kde.org/D3830 AFFECTED FILES find-modules/FindGperf.cmake EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem, #windows, kde-mac Cc: kfunk, rjvbb, adridg
[Differential] [Updated, 125 lines] D3830: Add a new FindGperf module
pino updated this revision to Diff 9499. pino added a comment. Restricted Application added projects: Frameworks, Buildsystem. Use a full path for the output location. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3830?vs=9408=9499 BRANCH pino-gperf REVISION DETAIL https://phabricator.kde.org/D3830 AFFECTED FILES find-modules/FindGperf.cmake EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem, #windows, kde-mac Cc: kfunk, rjvbb, adridg
[Differential] [Commented On] D3830: Add a new FindGperf module
pino added a comment. Cool -- thanks guys for the feedback on FreeBSD/Mac/Windows! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem, #windows, kde-mac Cc: kfunk, rjvbb, adridg
[Differential] [Commented On] D3830: Add a new FindGperf module
pino added a comment. Windows and Mac people: at least from a quick glance, GNU gperf should be already available on Windows and Mac; can you please confirm the new (build time only) dependency could be acceptable? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #kde_buildsystem, #windows, kde-mac
[Differential] [Updated] D3830: Add a new FindGperf module
pino added reviewers: Windows, kde-mac. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #kde_buildsystem, #windows, kde-mac
[Differential] [Request, 126 lines] D3830: Add a new FindGperf module
pino created this revision. pino added a reviewer: Frameworks. REVISION SUMMARY Add a simple module to look for GNU gperf at build time, providing an helper macro for adding generations to a list of sources. gperf will be used to generate the C/C++ sources at build time, instead of using static versions in VCS; at least kcodecs, khtml, and kio-extras will be switched to this method. REPOSITORY R240 Extra CMake Modules BRANCH pino-gperf REVISION DETAIL https://phabricator.kde.org/D3830 AFFECTED FILES find-modules/FindGperf.cmake EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks
