[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-31 Thread René J.V. Bertin 
rjvbb added a comment.


  In https://phabricator.kde.org/D3830#72701, @pino wrote:
  
  > The full path of gperf is determined using `find_program`, which looks in 
`$PATH` -- you can always specify the variable with the full path to force a 
custom location.
  
  
  great, that's exactly what I thought but wanted to see confirmed! :)
  (your remark of "using the full path for the output location" confused me a 
bit, sorry about that)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-31 Thread pino (Pino Toscano) 
pino added a comment.


  In https://phabricator.kde.org/D3830#72696, @rjvbb wrote:
  
  > In https://phabricator.kde.org/D3830#72508, @pino wrote:
  >
  > > For the input file? Yes.
  >
  >
  > I did mean the gperf executable...!
  
  
  I don't get what you mean, sorry :/ The full path of gperf is determined 
using `find_program`, which looks in `$PATH` -- you can always specify the 
variable with the full path to force a custom location.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-31 Thread René J.V. Bertin 
rjvbb added a comment.


  In https://phabricator.kde.org/D3830#72508, @pino wrote:
  
  > For the input file? Yes.
  
  
  I did mean the gperf executable...!

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano) 
pino added a comment.


  In https://phabricator.kde.org/D3830#72502, @rjvbb wrote:
  
  > You're still determining the location from the path with this new revision, 
right?
  
  
  For the input file? Yes.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-30 Thread René J.V. Bertin 
rjvbb added a comment.


  You're still determining the location from the path with this new revision, 
right?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano) 
pino added a comment.


  Cool -- thanks guys for the feedback on FreeBSD/Mac/Windows!

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread kfunk (Kevin Funk) 
kfunk added a comment.


  Windows: We have working gperf recipe in Craft => we're fine.
  
  QtWebKit already had an (optional) dependency on gperf.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread René J.V. Bertin 
rjvbb added a comment.


  In https://phabricator.kde.org/D3830#71722, @pino wrote:
  
  > Windows and Mac people: at least from a quick glance, GNU gperf should be 
already available on Windows and Mac
  
  
  I can only speak for 10.9 but indeed, gperf is available in /usr/bin .

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread adridg (Adriaan de Groot) 
adridg added a comment.


  gperf is also available in the base system for FreeBSD, so this doesn't have 
any effects on the build there, either.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #buildsystem, #windows, kde-mac
Cc: adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano) 
pino added a comment.


  Windows and Mac people: at least from a quick glance, GNU gperf should be 
already available on Windows and Mac; can you please confirm the new (build 
time only) dependency could be acceptable?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pino, #frameworks, #kde_buildsystem, #windows, kde-mac