D10211: Suggestion for emacs icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ab9cca7a8815: Suggestion for emacs icon (authored by 
lshoravi, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10211?vs=26286=26349

REVISION DETAIL
  https://phabricator.kde.org/D10211

AFFECTED FILES
  icons-dark/apps/48/emacs.svg
  icons/apps/48/emacs.svg

To: lshoravi, #breeze, #vdg, ngraham, andreaska
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Andreas Kainz]

andreaska accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham, andreaska
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Elvis Angelaccio]

elvisangelaccio added a reviewer: andreaska.

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham, andreaska
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Alright, should I submit in some kind of form or just in a plain comment?
  
  name: Linus Shoravi
  
  @: linusshor...@gmail.com

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  That's fine for now. Since this patch wasn't created using arcanist, I'll 
have to manually apply the name and email anyway. Once we get you set up with 
arcanist, neither of us will have to do this anymore!

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  The diff for this one applies sanely, so I think it's ready to land unless 
other folks would like changes (I'll wait for a while to give them time to take 
a look). In order to land the patch, we need a real name and email address. If 
Linus Shoravi is your real name, all we need is an email address and we're all 
set!

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Done and done!

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  Great! Would you mind updating the images in the Summary section to reflect 
your most recent changes?

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi updated this revision to Diff 26286.
lshoravi added a comment.


  Alright, this one looks like the right one.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10211?vs=26280=26286

REVISION DETAIL
  https://phabricator.kde.org/D10211

AFFECTED FILES
  icons-dark/apps/48/emacs.svg
  icons/apps/48/emacs.svg

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  No worries! We've all been there. :)

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  I'm still figuring things out, haha  Give me a minute and I'll figure it out

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  In general, arcanist makes this process much easier, FWIW. 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  Oops, is this the right diff? You want to generate a diff against the 
existing icon, not against your previous commit.`git diff HEAD^^ will generate 
a diff from what you have (HEAD) to two commits back (^^)

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi updated this revision to Diff 26280.
lshoravi added a comment.


  Here's the new diff for these changes. I also cleaned up some nodes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10211?vs=26272=26280

REVISION DETAIL
  https://phabricator.kde.org/D10211

AFFECTED FILES
  icons-dark/apps/48/emacs.svg
  icons/apps/48/emacs.svg

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  Beautiful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[David C]

davidc added a comment.


  Here is a 16px version. I think the fact that it's an E is much clearer at 
this size.
  
  F5685662: emacs16.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Here's a slightly altered version that should be more "E for Emacs"
  
  As for a 16px version; It didnt cross my mind. Should I make one?F5685659: 
Emacs.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Michael Heidelbach]

michaelh added a comment.


  I like it too. How does the 16px version look?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  Yeah, @abetts is right. Maybe reduce the size of the little flourishes on the 
top and bottom a bit?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: abetts, ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Andres Betts]

abetts added a comment.


  I like it! Maybe a way to accentuate that this is an "E" a little more. As a 
first impression, it didn't strike me as an E for emacs. Overall, the colors 
are great and the circle shape fits well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: abetts, ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  I'll look at it!
  
  I just need to figure out how to diff between to commits first.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Thanks Graham! I'll get the hang of this soon enough.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  This looks great to me. I'll let others have a look too before we land it, 
just to make sure everything A-OK.
  
  And if you're up for more icon work, wanna have a go at Virtualbox? The 
existing Breeze icon for it needs total replacement: 
https://bugs.kde.org/show_bug.cgi?id=384357

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  I did it for you this time. The "Add Action..." combobox above the comments 
field is used to do things like that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Or you can do it for me! Thanks :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Done!
  
  Sure!
  
  .. Let me just figure that out first 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added reviewers: Breeze, VDG.
ngraham added a comment.


  No worries! I like that icon, looks great. Could you maybe also attach 
another screenshot that shows it a bit larger, all on its own?
  
  Also, let's add some reviewers! Breeze is the theme you're submitting this 
for, and VDG is our Visual Design Group, whose members tend to be interested in 
this sort of thing.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi added a comment.


  Sorry! Just created an account to submit this, still figuring things out. 
Here's a screen, with some context! F5685571: Screenshot_20180131_190553.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Nathaniel Graham]

ngraham added a comment.


  What, no screenshot!? :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi
Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

[Linus Shoravi]

lshoravi created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
lshoravi requested review of this revision.

REVISION SUMMARY
  Here's a suggestion for an emacs icon
  
  I tried to follow the breeze icon guidelines to my best extent.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10211

AFFECTED FILES
  icons-dark/apps/48/emacs.svg
  icons/apps/48/emacs.svg

To: lshoravi
Cc: #frameworks, michaelh, ngraham