D10233: [KIO] Remove PrivilegeExecution job flag

2018-02-03 Thread David Faure 
dfaure added a comment.


  In https://phabricator.kde.org/D10233#199851, @chinmoyr wrote:
  
  > Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It 
worked for me.
  
  
  Ah, systemd stuff, not dbus stuff (which finds files in my custom prefix). 
Thanks, that worked, I was able to copy a file to '/'.
  The context menu for that file crashes kded5 (kdesvnd), I'm debugging that 
now...
  
  > On a completely different note, do all jobs have a uidelgate or does 
passing HideProgressInfo flag prevent it from being created?
  
  Neither ;)
  Some jobs don't have a uidelegate, those where we call setUiDelegate(0) (as 
is often done in unittests, to prevent any interaction with the user, like 
"file exists, do you want to overwrite or skip").
  HideProgressInfo doesn't remove such interaction, so the delegate still 
exists when setting HideProgressInfo.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10233

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

D10233: [KIO] Remove PrivilegeExecution job flag

2018-02-02 Thread Chinmoy Ranjan Pradhan 
chinmoyr added a comment.


  Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It 
worked for me.
  
  On a completely different note, do all jobs have a uidelgate or does passing 
HideProgressInfo flag prevent it from being created?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10233

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

D10233: [KIO] Remove PrivilegeExecution job flag

2018-02-02 Thread Chinmoy Ranjan Pradhan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ecaf513ed3cd: [KIO] Remove PrivilegeExecution job flag 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10233?vs=26326&id=26404

REVISION DETAIL
  https://phabricator.kde.org/D10233

AFFECTED FILES
  src/core/job_base.h

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

D10233: [KIO] Remove PrivilegeExecution job flag

2018-02-02 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for remembering to clean this up in time.
  
  Indeed not many people tested it, since it's still disabled...
  
  I tried to revert 
https://phabricator.kde.org/R241:5a1ea84476e63a97313d2201fc3d1f7033ea56af, 
restart kdeinit5 and kill kio_file instances, and copying a file to '/' indeed 
offers to do it as root, but then fails (no password prompt is shown). Either 
it's broken or I'm not testing it right (I'm installing everything into a 
custom prefix, so I copied the polkit file to 
/usr/share/polkit-1/actions/org.kde.kio.file.policy but maybe there are other 
files I need to copy?)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10233

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

D10233: [KIO] Remove PrivilegeExecution job flag

2018-02-01 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Same as title.

TEST PLAN
  Unfortunately, it seems no one beside me (and few others?) has tested 
privilege execution feature yet. 
  In this situation it's unclear which flag is more suitable. So I am removing 
PrivilegeExecution flag 
  based on the tests I have done on my local setup and little bit of instinct.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10233

AFFECTED FILES
  src/core/job_base.h

To: chinmoyr, #frameworks, dfaure
Cc: michaelh, ngraham