D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b6bd28ab0492: [server] Add support for the frame 
semantics of Pointer version 5 (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10235?vs=26336=28563#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10235?vs=26336=28563

REVISION DETAIL
  https://phabricator.kde.org/D10235

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/client/registry.cpp
  src/server/pointer_interface.cpp
  src/server/pointer_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, schernikov, michaelh, ZrenBot, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Ben Cooksley]

bcooksley edited projects, added Plasma; removed Plasma on Wayland.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, schernikov, michaelh, ZrenBot, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

Restricted Application edited projects, added Plasma on Wayland; removed Plasma.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, schernikov, michaelh, kmorwinski, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

romangg edited projects, added Plasma on Wayland; removed Plasma.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, 
eliasp, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  In D10235#213009 , @romangg wrote:
  
  > Shouldn't the sendFrame event sent by the compositor explicitly? The way 
it's currently send after each event compositors are not able to group these.
  
  
  Yes and no. For all the events we currently support, there is no grouping. 
For new event types, which we do not yet support, we need to add API to allow 
the compositer to send the frame.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks
Cc: romangg, plasma-devel, schernikov, michaelh, kmorwinski, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

romangg added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  Shouldn't the sendFrame event sent by the compositor explicitly? The way it's 
currently send after each event compositors are not able to group these.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks
Cc: romangg, plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, 
eliasp, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  ping

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks
Cc: plasma-devel, schernikov, michaelh, ZrenBot, alexeymin, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, Frameworks.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REVISION SUMMARY
  This change implements the required changes for wl_seat version 5.
  There seem to be applications which require version 5 and refuse to
  start if the server doesn't provide it. Thus we need to provide it.
  
  The main difference with version 5 is that pointer need to send a
  frame event after each logical group of events. As we don't support the
  new events from version 5 yet, we just emit the frame after each event
  and implement the suggested semantics for the enter/leave behavior.
  
  To really make use of this, we will have to implement additions in the
  API and then in KWin to expose the new API elements. But to just support
  the semantics we don't need it.
  
  BUG: 389189

TEST PLAN
  Extended autotest

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/client/registry.cpp
  src/server/pointer_interface.cpp
  src/server/pointer_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #kwin, #plasma, #frameworks
Cc: plasma-devel, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart