D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

2018-02-03 Thread Mark Gaiser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:32b3bbcd16fd: Use the KFileItemListProperties copy 
constructor instead of the conversion from… (authored by markg).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10261?vs=26401=26428

REVISION DETAIL
  https://phabricator.kde.org/D10261

AFFECTED FILES
  src/widgets/dropjob.cpp

To: markg, dfaure, jtamate
Cc: #frameworks, michaelh, ngraham

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

2018-02-03 Thread Jaime Torres Amate 
jtamate accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_stage2

REVISION DETAIL
  https://phabricator.kde.org/D10261

To: markg, dfaure, jtamate
Cc: #frameworks, michaelh, ngraham

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

2018-02-02 Thread Mark Gaiser 
markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.

REVISION SUMMARY
  As the title says. Minor optimization.

TEST PLAN
  Ran the testcases, all pass just fine.
  Also in callgrind it's one less call to the KFileItemListProperties 
constructor that takes a KFileItemList. A small win :)

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_stage2

REVISION DETAIL
  https://phabricator.kde.org/D10261

AFFECTED FILES
  src/widgets/dropjob.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham