D10719: Highlighting for OpenSCAD

2018-05-27 Thread Dominik Haumann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:849aea294446: Highlighting for OpenSCAD (authored by 
dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10719?vs=28190=34985#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10719?vs=28190=34985

REVISION DETAIL
  https://phabricator.kde.org/D10719

AFFECTED FILES
  autotests/folding/highlight.scad.fold
  autotests/html/highlight.scad.html
  autotests/input/highlight.scad
  autotests/reference/highlight.scad.ref
  data/syntax/openscad.xml

To: julianstirling, dhaumann
Cc: kde-frameworks-devel, dhaumann, ngraham, michaelh, bruns

D10719: Highlighting for OpenSCAD

2018-05-27 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Looks good, will integrate!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: kde-frameworks-devel, dhaumann, ngraham, michaelh, bruns, #frameworks

D10719: Highlighting for OpenSCAD

2018-04-12 Thread Julian Stirling 
julianstirling added a comment.


  Hi,
  This has been sitting idle for about 6 weeks. @dhaumann is everything OK with 
the current patch for integration
  Cheers
  Julian

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh, bruns

D10719: Highlighting for OpenSCAD

2018-02-27 Thread Julian Stirling 
julianstirling added a comment.


  `git diff HEAD^^ HEAD > ../PatchCombined.patch` has hopefully done the trick.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-27 Thread Julian Stirling 
julianstirling updated this revision to Diff 28190.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10719?vs=27770=28190

REVISION DETAIL
  https://phabricator.kde.org/D10719

AFFECTED FILES
  autotests/input/highlight.scad
  data/syntax/openscad.xml

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-26 Thread Julian Stirling 
julianstirling added a comment.


  `git format-patch HEAD^^` creates two separate patch files...

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-26 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, all commits need to be in a single patch here.Try doing `git 
format-patch HEAD^^`, which will include the last two commits.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-26 Thread Julian Stirling 
julianstirling added a comment.


  Oh, I was following the guide here 
https://community.kde.org/Infrastructure/Github_Mirror
  So everything I uploaded was a git format-patch, which makes a patch file for 
each commit I made. I shall look into arc when I get a chance.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-25 Thread Dominik Haumann 
dhaumann added a comment.


  Hm, did you update with `arc diff`, or did you do this differently?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh, kmorwinski

D10719: Highlighting for OpenSCAD

2018-02-24 Thread Julian Stirling 
julianstirling planned changes to this revision.
julianstirling added a comment.


  I am confused. If I look in the commit history of this revision there are two 
diffs, the first commit, and then the subsequent commit. Can phabricator not 
handle both of them sequentially?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh, kmorwinski

D10719: Highlighting for OpenSCAD

2018-02-24 Thread Dominik Haumann 
dhaumann added a comment.


  @julianstirling Can you profile the full xml file again? This patch does not 
contain the .xml file anymore, so in the current form I cannot commit this as 
is.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh, kmorwinski

D10719: Highlighting for OpenSCAD

2018-02-24 Thread Nathaniel Graham 
ngraham added a comment.


  Oops, looks like your last update replaced the original change.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-22 Thread Nathaniel Graham 
ngraham added a comment.


  In case anyone wants a more complex test file, I'm attaching one (written by 
me, MIT license):
  
  F5725381: X-carriagestruder.scad 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-22 Thread Julian Stirling 
julianstirling updated this revision to Diff 27770.
julianstirling added a comment.


  Added the test file as requested and updated the license to MIT.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10719?vs=27698=27770

REVISION DETAIL
  https://phabricator.kde.org/D10719

AFFECTED FILES
  autotests/input/highlight.scad
  data/syntax/openscad.xml

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-21 Thread Dominik Haumann 
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Thanks for the contribution. Before we integrate this, would you agree to 
change the license to MIT? This license is preferred for new highlighting files.
  
  Also, could you please also provide a test file we can add to Autotest/input 
for unit testing? This file should preferably also use the MIT license.
  
  Would be nice if you provide another iteration before we commit this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

2018-02-21 Thread Julian Stirling 
julianstirling created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
julianstirling requested review of this revision.

REVISION SUMMARY
  Added XML file to highlight OpenSCAD .scad files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

AFFECTED FILES
  data/syntax/openscad.xml

To: julianstirling
Cc: #frameworks, michaelh