D10902: Don't make Titles 20% transparent either

2018-02-28 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  opaque-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh


D10902: Don't make Titles 20% transparent either

2018-02-27 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  If it didn't make sense to have Headings be 20% opaque because nearby or 
child textual content would be darker, then it //really// doesn't make sense to 
have Titles be 20% transparent, because then **everything** is darker than the 
titles, which is really odd.

TEST PLAN
  Widget Explorer title, before:
  
  Widget Explorer title, after:

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  opaque-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10902

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/Title.qml

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh