D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: kde-frameworks-devel, ngraham, LeGast00n, cblack, michaelh, ahmadsamir, 
bruns, vkrause

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  I opened a bug  but I didn’t 
have any answer so far.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: kde-frameworks-devel, ngraham, michaelh, bruns, #frameworks

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Nathaniel Graham]

ngraham added a comment.


  Yeah, if you abandon this patch, requesting that the feature be natively 
added would probably be sane.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel added a comment.


  To add an option to use the fallback of a Plasma theme (i.e. to disable 
shadows and transparency).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Nathaniel Graham]

ngraham added a comment.


  What bug would you be reporting?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel added a comment.


  Should I open a bug report on https://bugs.kde.org?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel added a comment.


  > FWIW, Breeze shadows can now be turned off entirely (System Settings > 
Application Style > Window Decorations > Breeze > Click on the little Settings 
button in the corner > Shadows > Size: None), so the only thing this really 
adds is opaque backgrounds.
  
  You’re mistaken: this disable shadows only for window decorations. My themes 
disable shadows for panel (and widgets), Krunner and Kwin’s task switcher.
  
  > Not sure it's worth it IMHO. Maybe instead we should let people turn it off 
in Breeze without modifications.
  
  Sure, you can add an option to use fallback resources; my solution is dead 
simple but a generic solution is better. I just don’t happen to have the time 
or knowledge to do it.
  
  Also note that I use `kquitapp5 plasmashell && plasmashell` after applying my 
theme in order to make shadows disapear for Plasma; it works instantly for KWin.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Nathaniel Graham]

ngraham added a comment.


  FWIW, Breeze shadows can now be turned off entirely (System Settings > 
Application Style > Window Decorations > Breeze > Click on the little Settings 
button in the corner > Shadows > Size: None), so the only thing this really 
adds is opaque backgrounds. Not sure it's worth it IMHO. Maybe instead we 
should let people turn it off in Breeze without modifications.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
achauvel requested review of this revision.

REVISION SUMMARY
  It seems to be quite popular since it got more than 1000 downloads on 
kde.store.org in a week, and each consists on a metadata.desktop file and a few 
symlinks.
  
  See here for technical details: https://framagit.org/ariasuni/breeze-flat

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

AFFECTED FILES
  src/desktoptheme/breeze-dark-flat/colors
  src/desktoptheme/breeze-dark-flat/dialogs
  src/desktoptheme/breeze-dark-flat/metadata.desktop
  src/desktoptheme/breeze-dark-flat/widgets
  src/desktoptheme/breeze-light-flat/colors
  src/desktoptheme/breeze-light-flat/dialogs
  src/desktoptheme/breeze-light-flat/metadata.desktop
  src/desktoptheme/breeze-light-flat/widgets

To: achauvel
Cc: #frameworks, michaelh