D11049: Remove frame around media action icons
This revision was automatically updated to reflect the committed changes. Closed by commit R266:106b27347125: Remove frame around media action icons (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11049?vs=28689=28898#toc REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11049?vs=28689=28898 REVISION DETAIL https://phabricator.kde.org/D11049 AFFECTED FILES icons-dark/actions/16/media-playback-pause.svg icons-dark/actions/16/media-playback-start.svg icons-dark/actions/16/media-playback-stop.svg icons-dark/actions/16/media-record.svg icons-dark/actions/16/media-seek-backward.svg icons-dark/actions/16/media-seek-forward.svg icons-dark/actions/16/media-skip-backward.svg icons-dark/actions/16/media-skip-forward.svg icons-dark/actions/22/media-playback-pause.svg icons-dark/actions/22/media-playback-start.svg icons-dark/actions/22/media-playback-stop.svg icons-dark/actions/22/media-seek-backward.svg icons-dark/actions/22/media-seek-forward.svg icons-dark/actions/22/media-skip-backward.svg icons-dark/actions/22/media-skip-forward.svg icons-dark/actions/24/media-playback-pause.svg icons-dark/actions/24/media-playback-start.svg icons-dark/actions/24/media-playback-stop.svg icons-dark/actions/24/media-record.svg icons-dark/actions/24/media-seek-backward.svg icons-dark/actions/24/media-seek-forward.svg icons-dark/actions/24/media-skip-backward.svg icons-dark/actions/24/media-skip-forward.svg icons-dark/actions/32/media-playback-pause.svg icons-dark/actions/32/media-playback-start.svg icons-dark/actions/32/media-playback-stop.svg icons-dark/actions/32/media-record.svg icons-dark/actions/32/media-seek-backward.svg icons-dark/actions/32/media-seek-forward.svg icons-dark/actions/32/media-skip-backward.svg icons-dark/actions/32/media-skip-forward.svg icons/actions/16/media-playback-pause.svg icons/actions/16/media-playback-start.svg icons/actions/16/media-playback-stop.svg icons/actions/16/media-record.svg icons/actions/16/media-seek-backward.svg icons/actions/16/media-seek-forward.svg icons/actions/16/media-skip-backward.svg icons/actions/16/media-skip-forward.svg icons/actions/22/media-playback-pause.svg icons/actions/22/media-playback-start.svg icons/actions/22/media-playback-stop.svg icons/actions/22/media-seek-backward.svg icons/actions/22/media-seek-forward.svg icons/actions/22/media-skip-backward.svg icons/actions/22/media-skip-forward.svg icons/actions/24/media-playback-pause.svg icons/actions/24/media-playback-start.svg icons/actions/24/media-playback-stop.svg icons/actions/24/media-record.svg icons/actions/24/media-seek-backward.svg icons/actions/24/media-seek-forward.svg icons/actions/24/media-skip-backward.svg icons/actions/24/media-skip-forward.svg icons/actions/32/media-playback-pause.svg icons/actions/32/media-playback-start.svg icons/actions/32/media-playback-stop.svg icons/actions/32/media-record.svg icons/actions/32/media-seek-backward.svg icons/actions/32/media-seek-forward.svg icons/actions/32/media-skip-backward.svg icons/actions/32/media-skip-forward.svg To: romangg, #breeze, #vdg, andreask, ngraham Cc: ngraham, mart, #frameworks, michaelh
D11049: Remove frame around media action icons
ngraham accepted this revision. ngraham added a comment. Looks good to me too! REPOSITORY R266 Breeze Icons BRANCH reworkMediaActions REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg, andreask, ngraham Cc: ngraham, mart, #frameworks, michaelh
D11049: Remove frame around media action icons
andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH reworkMediaActions REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg, andreask Cc: mart, #frameworks, michaelh
D11049: Remove frame around media action icons
romangg added a dependent revision: D11054: Add media status icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: mart, #frameworks, michaelh
D11049: Remove frame around media action icons
mart added a comment. as a pure code review, +1 from me as i see style="fill:currentColor;fill-opacity:1;stroke:none" remained inalterated so you did fix the mess inkscape likes to do with it :) as style, i definitely like it more without circles around, final approval is by Andreas. (maybe add a couple of screenshots?) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: mart, #frameworks, michaelh
D11049: Remove frame around media action icons
romangg added a dependent revision: D11050: Remove frames around media buttons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: #frameworks, michaelh
D11049: Remove frame around media action icons
romangg added reviewers: Breeze, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: #frameworks, michaelh
D11049: Remove frame around media action icons
romangg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. romangg requested review of this revision. REVISION SUMMARY We were inconsistent on that and it can get in way with placement on buttons. Also Research showed that many established media players do not per se feature a frame around their media control buttons. REPOSITORY R266 Breeze Icons BRANCH reworkMediaActions REVISION DETAIL https://phabricator.kde.org/D11049 AFFECTED FILES icons-dark/actions/16/media-playback-pause.svg icons-dark/actions/16/media-playback-start.svg icons-dark/actions/16/media-playback-stop.svg icons-dark/actions/16/media-record.svg icons-dark/actions/16/media-seek-backward.svg icons-dark/actions/16/media-seek-forward.svg icons-dark/actions/16/media-skip-backward.svg icons-dark/actions/16/media-skip-forward.svg icons-dark/actions/22/media-playback-pause.svg icons-dark/actions/22/media-playback-start.svg icons-dark/actions/22/media-playback-stop.svg icons-dark/actions/22/media-seek-backward.svg icons-dark/actions/22/media-seek-forward.svg icons-dark/actions/22/media-skip-backward.svg icons-dark/actions/22/media-skip-forward.svg icons-dark/actions/24/media-playback-pause.svg icons-dark/actions/24/media-playback-start.svg icons-dark/actions/24/media-playback-stop.svg icons-dark/actions/24/media-record.svg icons-dark/actions/24/media-seek-backward.svg icons-dark/actions/24/media-seek-forward.svg icons-dark/actions/24/media-skip-backward.svg icons-dark/actions/24/media-skip-forward.svg icons-dark/actions/32/media-playback-pause.svg icons-dark/actions/32/media-playback-start.svg icons-dark/actions/32/media-playback-stop.svg icons-dark/actions/32/media-record.svg icons-dark/actions/32/media-seek-backward.svg icons-dark/actions/32/media-seek-forward.svg icons-dark/actions/32/media-skip-backward.svg icons-dark/actions/32/media-skip-forward.svg icons/actions/16/media-playback-pause.svg icons/actions/16/media-playback-start.svg icons/actions/16/media-playback-stop.svg icons/actions/16/media-record.svg icons/actions/16/media-seek-backward.svg icons/actions/16/media-seek-forward.svg icons/actions/16/media-skip-backward.svg icons/actions/16/media-skip-forward.svg icons/actions/22/media-playback-pause.svg icons/actions/22/media-playback-start.svg icons/actions/22/media-playback-stop.svg icons/actions/22/media-seek-backward.svg icons/actions/22/media-seek-forward.svg icons/actions/22/media-skip-backward.svg icons/actions/22/media-skip-forward.svg icons/actions/24/media-playback-pause.svg icons/actions/24/media-playback-start.svg icons/actions/24/media-playback-stop.svg icons/actions/24/media-record.svg icons/actions/24/media-seek-backward.svg icons/actions/24/media-seek-forward.svg icons/actions/24/media-skip-backward.svg icons/actions/24/media-skip-forward.svg icons/actions/32/media-playback-pause.svg icons/actions/32/media-playback-start.svg icons/actions/32/media-playback-stop.svg icons/actions/32/media-record.svg icons/actions/32/media-seek-backward.svg icons/actions/32/media-seek-forward.svg icons/actions/32/media-skip-backward.svg icons/actions/32/media-skip-forward.svg To: romangg Cc: #frameworks, michaelh
