D11055: Pack python bindings into right dirs

2018-09-11 Thread Oleg Solovyov 
McPain abandoned this revision.
Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; 
removed: Frameworks, Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, arojas, apol, michaelh, ngraham, 
bruns, #frameworks, #build_system

D11055: Pack python bindings into right dirs

2018-03-05 Thread Antonio Rojas 
arojas added a comment.


  The sip part is distro-specific. At least in Arch we don't have separate 
sip/sip3 directories (what's the point? sip files are independent of the python 
version)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: arojas, apol, #frameworks, #build_system, michaelh

D11055: Pack python bindings into right dirs

2018-03-05 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> FindPythonModuleGeneration.cmake:448
>  if (GPB_SIP_DEPENDS MATCHES PyKF5)
> -  set(_kf5_python_prefix 
> ${CMAKE_INSTALL_PREFIX}/lib/python${pyversion${pyversion}_maj_min}/${GPB_INSTALL_DIR_SUFFIX})
> +  set(_kf5_python_prefix 
> ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX}/python${pyversion${pyversion}_maj_min}/${GPB_INSTALL_DIR_SUFFIX})
>  else()

Maybe use KDE_INSTALL_FULL_LIBDIR?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: apol, #frameworks, #build_system, michaelh

D11055: Pack python bindings into right dirs

2018-03-05 Thread Oleg Solovyov 
McPain created this revision.
McPain added a reviewer: vkrause.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
McPain requested review of this revision.

REVISION SUMMARY
  1. Python modules are packed into /usr/lib/ for both x86 and x86_64 
architectures
  
  Should be:
  /usr/lib/ for x86
  /usr/lib64/ for x86_63
  
  2. sip modules are packed into /usr/share/sip for both python2 and python3
  
  Should be:
  /usr/share/sip/ for python2
  /usr/share/sip3/ for python3

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: McPain, vkrause
Cc: #frameworks, #build_system, michaelh