D11193: Sonnet : use current hunspell API

[Kevin Funk]

kfunk added a comment.


  Please see concerns on 
https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kfunk, kde-frameworks-devel, michaelh, ngraham, bruns

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:0a96acf251ba: Use the current hunspell API (authored by 
rjvbb).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11193?vs=29246=37434

REVISION DETAIL
  https://phabricator.kde.org/D11193

AFFECTED FILES
  src/plugins/hunspell/hunspelldict.cpp

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb added a comment.


  No problem if there's a good reason to wait!
  
  Surprising that OpenSuSE has such an old hunspell but apparently a new enough 
Qt and other dependencies required for building Plasma5 desktops!
  (My Ubuntu 14.04 also has hunspell 1.3.2 but is stuck on Qt 5.2 so I'm 
building most KF5 dependencies myself.)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11193: Sonnet : use current hunspell API

[David Faure]

dfaure added a comment.


  OpenSuSE Leap 42.3 (whose core packages are starting to get really old...) 
has hunspell-1.3.2-7.4.x86_64
  
  Can you wait for a few months? OpenSuSE 15 should be released end of May.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb added a comment.


  >   Which version of hunspell does this raise the requirement to?
  
  1.5.1 it seems: 
https://github.com/hunspell/hunspell/commit/f90e69759203a945128b704a1b7037697a5113dd
  
  Is that acceptable (that release is almost 2 years old by now)?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11193: Sonnet : use current hunspell API

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Which version of hunspell does this raise the requirement to?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb added a comment.


  Any objections if I commit this by the end of the week?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

Re: D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

> You should probably add the sonnet maintainer (or whoever committed
> the most to the repository in recent months) as the reviewer.

Possibly, but they're all supposed to be notified of this via the frameworks-
devel ML already.

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb added reviewers: dfaure, mlaurent, vkrause.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

Re: D11193: Sonnet : use current hunspell API

[Ivan Čukić]

You should probably add the sonnet maintainer (or whoever committed
the most to the repository in recent months) as the reviewer.

Cheers,
Ivan

On Tue, Mar 13, 2018 at 10:26 AM, René J. V.  Bertin
 wrote:
> Silence means acceptance?
>



-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A

Re: D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

Silence means acceptance?

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb updated this revision to Diff 29246.
rjvbb added a comment.


  add missing context (patch unchanged)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11193?vs=29116=29246

REVISION DETAIL
  https://phabricator.kde.org/D11193

AFFECTED FILES
  src/plugins/hunspell/hunspelldict.cpp

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, michaelh

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb set the repository for this revision to R246 Sonnet.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, michaelh

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb created this revision.
rjvbb added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
rjvbb requested review of this revision.

REVISION SUMMARY
  The hunspell backend uses three deprecated hunspell API functions; this patch 
fixes that.

TEST PLAN
  Works as expected as far as I can tell.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

AFFECTED FILES
  src/plugins/hunspell/hunspelldict.cpp

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, michaelh