D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:05fe10da0034: Highlight selected items when showing 
parent folder from the open/save dialog (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11705?vs=30622=30668

REVISION DETAIL
  https://phabricator.kde.org/D11705

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks, broulik
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11705

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks, broulik
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham added a comment.


  Also, we have a request to add an Open action to the menu 
(https://bugs.kde.org/show_bug.cgi?id=392329), which would take care of the use 
case of wanting to directly open the folder. I plan to submit a patch for that, 
too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham added a comment.


  In D11705#234324 , @broulik wrote:
  
  > Good idea.
  >
  > How about folders? Perhaps we should use a different behavior for folders 
as you're imho more likely to want to open a folder in the file manager than 
look "where it is"
  
  
  I kind of like the consistency here; you always know what "Open Containing 
Folder" will do: open the containing folder, no matter what the selected item 
may be. Since it's pre-selected in the window that opens, it's really easy to 
open it if it's a folder and view the contents; just hit the [Return] key 
immediately.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham updated this revision to Diff 30622.
ngraham added a comment.


  Fix the case where nothing is selected (i.e. when the user right-clicks on 
the background)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11705?vs=30582=30622

BRANCH
  arcpatch-D11705

REVISION DETAIL
  https://phabricator.kde.org/D11705

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Kai Uwe Broulik]

broulik added a comment.


  Good idea.
  
  How about folders? Perhaps we should use a different behavior for folders as 
you're imho more likely to want to open a folder in the file manager than look 
"where it is"

INLINE COMMENTS

> kdiroperator.cpp:666
>  {
> -new KRun(currUrl, parent);
> +KIO::highlightInFileManager(parent->selectedItems().urlList());
>  }

When no folder is selected, this does nothing. It should open the current 
folder instead, or change labels accordingly. "Open With $filemanager" vs "Open 
Containing Folder"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  For the open/save dialogs' Open File Manager context menu item, this patch 
adopts `KIO::highlightInFileManager()` and modernizes the name to match current 
convention ("Open Containing Folder").
  
  BUG: 392330

TEST PLAN
  Deployed change, invoke the open dialog from Kate, right-click on one or more 
items and select Open Containing Folder. See that items are highlighted.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11705

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks
Cc: michaelh, ngraham