D11717: regenerate qrc on every build

2018-03-26 Thread Bhushan Shah 
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:f3619363ed63: regenerate qrc on every build (authored by 
bshah).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11717?vs=30628=30631

REVISION DETAIL
  https://phabricator.kde.org/D11717

AFFECTED FILES
  KF5PackageMacros.cmake
  qrc.cmake

To: bshah, mart, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11717: regenerate qrc on every build

2018-03-26 Thread David Edmundson 
davidedmundson accepted this revision.

REPOSITORY
  R290 KPackage

BRANCH
  regenerateqrc

REVISION DETAIL
  https://phabricator.kde.org/D11717

To: bshah, mart, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11717: regenerate qrc on every build

2018-03-26 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  regenerateqrc

REVISION DETAIL
  https://phabricator.kde.org/D11717

To: bshah, mart
Cc: #frameworks, michaelh, ngraham

D11717: regenerate qrc on every build

2018-03-26 Thread Bhushan Shah 
bshah created this revision.
bshah added a reviewer: mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
bshah requested review of this revision.

REVISION SUMMARY
  this will ensure that file deletion and inclusion are taken care of when
  running build

TEST PLAN
  - kdeplasma-addons
  - clean build works
  - Add a file in comic applet
  - run make
  - ensure qrc file contains new file
  - install
  - run applet ensure new file is there
  - remove new qml file
  - install
  - ensure that file is removed from qrc and rcc

REPOSITORY
  R290 KPackage

BRANCH
  regenerateqrc

REVISION DETAIL
  https://phabricator.kde.org/D11717

AFFECTED FILES
  KF5PackageMacros.cmake
  qrc.cmake

To: bshah, mart
Cc: #frameworks, michaelh, ngraham