D12192: Decode more documentUrls

[Michael Heidelbach]

michaelh added a comment.


  In D12192#246449 , @bruns wrote:
  
  > Can you add a little bit more info to the commit message, e.g. an example 
how the output looks before and after?
  
  
  I don't know... 
  I realized the necessity to `QFile::decodeName()` while working on `baloodb`. 
It could not find a file "**I´m** Haunted.txt" without it. The rest was find 
and replace over the code in `src/**`.   In most cases `QFile::decodeName()` 
was used, so I thought it was just forgotten here. `src/file/indexcleaner.cpp` 
is dead code, btw.
  Feel free to edit the description if you have a better wording in mind.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12192

To: michaelh, #baloo, bruns
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D12192: Decode more documentUrls

[Michael Heidelbach]

michaelh edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12192

To: michaelh, #baloo, bruns
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D12192: Decode more documentUrls

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Can you add a little bit more info to the commit message, e.g. an example how 
the output looks before and after?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12192

To: michaelh, #baloo, bruns
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D12192: Decode more documentUrls

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> transaction.cpp:469
>  for (quint64 id: allIds) {
>  QByteArray url = docUrlDb.get(id);
>  if (url.isEmpty()) {

For your convenience

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12192

To: michaelh, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12192: Decode more documentUrls

[Michael Heidelbach]

michaelh created this revision.
michaelh added a reviewer: Baloo.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

TEST PLAN
  make test

REPOSITORY
  R293 Baloo

BRANCH
  file-encoding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12192

AFFECTED FILES
  src/engine/transaction.cpp
  src/file/indexcleaner.cpp
  src/file/unindexedfileindexer.cpp
  src/lib/searchstore.cpp

To: michaelh, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin