D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

This revision was automatically updated to reflect the committed changes.
Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; 
reduce overall size of dialog (authored by sharvey).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32758=40505

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  Are you going to land this?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Go for it then!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  I believe it's done.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  Can we commit this?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  In D12311#252212 , @stikonas wrote:
  
  > In D12311#252165 , @bruns wrote:
  >
  > > Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize
  >
  >
  > Does not work well yet, just a few errors where KPM succeeds:
  >
  > - Cannot resize btrfs filesystem on /dev/sdb1: (null) filesystem 'btrfs' is 
not supported.
  
  
  Wrong, tested, works. You have to use 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Filesystem.BTRFS.html

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#252165 , @bruns wrote:
  
  > Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize
  
  
  Does not work well yet, just a few errors where KPM succeeds:
  
  - Cannot resize btrfs filesystem on /dev/sdb1: (null) filesystem 'btrfs' is 
not supported.
  - LUKS encrypted ext4: looks like I can resize internal file system but no 
way to resize outer LUKS container (i.e. what cryptsetup resize does)
  - Does not recognize LVM PVs, no way to resize them.
  
  On the other hand, it might be useful in certain cases. E.g. to resize FAT 
and maybe HPFS (not all distros ship fatresize).
  
  In any case, resizing is not the only thing. No way to copy/move file systems.
  
  I'm not opposed to UDisks in principle, I am just saying it's not there yet.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  In D12311#250731 , @stikonas wrote:
  
  > In D12311#250688 , @bruns wrote:
  >
  > > Gnome-disks does, and so do other programs.
  >
  >
  > Gnome-disks uses UDisks to do everything and can't do anything on its own. 
So available features are very limited (not even resizing partitions).
  >  I suspect it is significantly less portable (e.g. to FreeBSD).
  >  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing) and it wasn't the case of somebody 
porting gparted to udisks .
  
  
  Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  FYI: I undid the wonky manual UI sizing that @broulik objected to. In 
hindsight, not the best approach.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Okay, this patch is back to where we started, with nothing changed except 
centering the icon. Hopefully we can commit it now. I'll move the discussion 
over how to redesign the dialog itself to a separate task.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey updated this revision to Diff 32758.
sharvey added a comment.


  - Merge branch 'master' into align-lock-icon
  - Undo manual resizing of ser combo box & password error box

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32498=32758

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250688 , @bruns wrote:
  
  > Gnome-disks does, and so do other programs.
  
  
  Gnome-disks uses UDisks to do everything and can't do anything on its own. So 
available features are very limited (not even resizing partitions).
  I suspect it is significantly less portable (e.g. to FreeBSD).
  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Gnome-disks does, and so do other programs.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  Partition Manager wouldn't be able to show such specific text anyway (what is 
being formatted). It just starts a helper that can execute any command it asks. 
You can't make it work otherwise.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Its not available otherwise ...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Luigi Toscano]

ltoscano added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  As long as you keep the detailed information available, that's fine. You can 
always end up having a non useful name for your USB stick...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  No, thats completely off, as thats the action you are authorizing.
  
  > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  
  I want it to show what it is asking permission for, and to be specific - does 
it want to format the USB stick I just inserted, or my home partition.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Hmm, I was actually leaning the other way. Ditch the generic boilerplate and 
keep the app-specific text. I think it's helpful when the dialog tells you why 
it appeared and what app/function is requesting your password.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  So right now, we have two strings of text:
  
  - The top bold string comes from the app and differs on a per-app basis
  - The bottom long boilerplate string is from us, and shown all the time
  
  I  like @abetts' idea: we should remove the app-specific text and make the 
always-shown boilerplate text short and to the point.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a subscriber: stikonas.
sharvey added a comment.


  Semi-related bug from @stikonas, while I'm on dialog duty: 
https://bugs.kde.org/show_bug.cgi?id=393355

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  The small-text boilerplate is definitely on the chopping block. @ltoscano 
makes a fine case for keeping the Details section.
  
  @bruns - Thanks for helping me find the source of the incoming messages. I 
hadn't gotten around to searching for them yet, but you saved me some work. 
Thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Btw, an easy way to trigger the dialog is e.g.
  
$> pkcheck -u -p $$ -a org.freedesktop.udisks2.eject-media-system
  
  $$ is the PID of the shell.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  The "Authentication is required to ..." header line is directly sourced from 
the action definition below `/usr/share/polkit-1/actions/*`
  
  "Administrator password" is insufficient/wrong, as you can also (dependent on 
system configuration) authorize the actions as another priviledged user, see 
the screenshots.
  
  Password is redundant (label on the textfield), and wrong, as you can 
potentially use something like a fingerprint to authenticate.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andres Betts]

abetts added a comment.


  In D12311#250637 , @bruns wrote:
  
  > If you really want to save some space (and probably make it easier for 
users to understand the dialog without getting lost), I think the whole
  >
  > > An application is attempting to perform an action that requires 
privileges.
  > >  Authentication is required to perform this action.
  >
  > boilerplate can be removed. It is some lenghty, generic text, which does 
not add any useful information.
  >
  > If the Action in the Details tab is showing the raw id of the action, its 
the fault of the action definition, lacking a `` tag.
  
  
  What about something like:
  
  "Authentication is required to perform this action. Please enter your 
administrator password"
  
  And nothing else. No 3 lines but just one.
  
  ??

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  If you really want to save some space (and probably make it easier for users 
to understand the dialog without getting lost), I think the whole
  
  > An application is attempting to perform an action that requires privileges.
  >  Authentication is required to perform this action.
  
  boilerplate can be removed. It is some lenghty, generic text, which does not 
add any useful information.
  
  If the Action in the Details tab is showing the raw id of the action, its the 
fault of the action definition, lacking a `` tag.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Luigi Toscano]

ltoscano added a comment.


  Do you really want to remove the proper source of information in security 
dialog that asks you some additional credentials?
  Please keep it there.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  In general it's okay to display nerdy technical information hidden away like 
this--as long as it's actually useful information! That's the real question. If 
it's of no real value to anyone for any use case that we can imaging, we can 
probably safely remove it. Otherwise, it should probably stay in.
  
  Personally I have no use for it, but let's collect more perspectives.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Reviewers: as part of my task to redesign and tidy up this dialog box, I'm 
considering removing the Details button in the bottom left corner, along with 
the small pop-open panel that shows additional information. My argument is that 
the info in the Details panel is quite technical (PID's of calling process and 
polkit process) and - in some circumstances - lucid information about the 
program needing authorization. Most of the time, what's coming through is in 
raw form, such as `com.canonical.ubuntu.synaptic` (more or less) instead of 
`Synaptic Package Manager`.
  
  I know carving out UI elements can be controversial, so please give a few +/- 
1's so I know what others think. Maybe some people use it. I don't. But that's 
not a good enough reason to remove it.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  In D12311#249270 , @sharvey wrote:
  
  > F5812033: Screenshot_20180418_161500.png 

  >  The good news is that it still behaves properly with a scaled display.
  >
  > The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!
  
  
  Ouch, that's pretty bad. Perhaps we should move the button up higher in the 
window so you'll always be able to reach it no matter what weird state you find 
yourself in.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812033: Screenshot_20180418_161500.png 

  The good news is that it still behaves properly with a scaled display.
  
  The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  I think it would be worth it! It's definitely not a crown jewel of polished 
UI design, that's for sure.
  
  To test scaling, try setting a systemwide scale factor in System Settings > 
Display and Monitor > Displays > Scale Display, then logging out and back in, 
then doing it again,

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812014: Screenshot_20180418_155156.png 

  The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a 
separate process?). I don't have a HiDPI display to test on.
  
  I tried different fonts up to 15pt and all is okay. I even tried the nasty 
Windows-style widgets and it's still okay.
  
  I agree the layout is kind of a mess. I can take a shot at reworking it if 
the reviewers think it's worth the effort.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Kai Uwe Broulik]

broulik added a comment.


  I think there's something severly wrong with the dialog's size hints if we 
need to add arbitrary numbers all over the place. Can you make sure this 
doesn't break with
  
  - different font
  - larger font
  - screen scaling
  - different widget style
  - ...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham accepted this revision.
ngraham added a comment.


  Much better! I'd still prefer less whitespace, but this is already an 
improvement. But now that I'm staring at this dialog over and over again, I'm 
wondering if we even need the non-bold caption text at all. It just repeats the 
bold text in a slightly more awkward and more wordy fashion. What do you think?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart