D12392: Fix the "Default" color scheme to match Breeze again
This revision was automatically updated to reflect the committed changes. Closed by commit R265:ebdb8424cd12: Fix the Default color scheme to match Breeze again (authored by ngraham). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12392?vs=32683=34085 REVISION DETAIL https://phabricator.kde.org/D12392 AFFECTED FILES src/kcolorscheme.cpp To: ngraham, #breeze, #plasma, hein Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham added a comment. Thanks! I didn't find anything in kdelibs or the color KCM code, actually. The Colors KCM has several other color schemes listed in there, but not a copy of Breeze. REPOSITORY R265 KConfigWidgets BRANCH fix-default-color-scheme (branched from master) REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns
D12392: Fix the "Default" color scheme to match Breeze again
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This looks good, but I think there might be additional copies of these values in (a) the color KCM code and (b) the kdeglobals code in kdelibs4support, did you have a chance to look into those? REPOSITORY R265 KConfigWidgets BRANCH fix-default-color-scheme (branched from master) REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Ping? Shell I take silence to mean tacit acceptance? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns, #frameworks
D12392: Fix the "Default" color scheme to match Breeze again
ngraham added a comment. The user already has to create a named color scheme if he wants to actually //save and use// his modifications. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: cfeck, abetts, #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
cfeck added a comment. "Current" could be named "Unnamed" or "Unsaved". It cannot be removed, unless you want to force the user to always create a named color scheme when he does modifications. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: cfeck, abetts, #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham added a comment. "Current" is whatever the current theme is and can be ignored (and hopefully gotten rid of in the future). The issue here is that "Default" is //supposed to// be identical to "Breeze", but it's currently not. This patch fixes that. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: abetts, #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
abetts added a comment. Just trying to understand. What is happening here is that we have 3 color schemes that are all theoretically the same as Breeze. However, the "default" and "Breeze" scheme are currently not the same. Therefore, we have to make sure that they are. If that's the case +1 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: abetts, #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham added a comment. Friendly ping! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns
D12392: Fix the "Default" color scheme to match Breeze again
ngraham created this revision. ngraham added reviewers: Breeze, Plasma, hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Over the years, the "Default" color scheem seems to have drifted out of alignment with Breeze. Part of this was my doing, in https://cgit.kde.org/breeze.git/commit/?id=04dac01c2a3268f7f6189b2d5c404cb2b7aaf51f, but there were other changes too. This patch fixes it to match breeze again. There may be more patches required in other repos, which will be forth coming as I discover more definitions of the default color scheme (this is the only once I;ve found so far). TEST PLAN [video goes here] REPOSITORY R265 KConfigWidgets BRANCH fix-default-color-scheme (branched from master) REVISION DETAIL https://phabricator.kde.org/D12392 AFFECTED FILES src/kcolorscheme.cpp To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns
