D12521: KFileWidget use hidpi icons

[Alex Nemeth]

anemeth abandoned this revision.
anemeth added a comment.


  In D12521#253806 , 
@elvisangelaccio wrote:
  
  > Every application that opens a file dialog is supposed to do this in their 
own startup code (usually in `main()`).
  
  
  Looks like this is the case:
  
  F5822284: .PNG 
  
  Left is KolourPaint with blurry icons, right is Kate that already has this 
and scales well.
  I'll abandon this patch because this needs application level fix for Qt apps.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, broulik, ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D12521#253764 , @anemeth wrote:
  
  > In D12521#253761 , @broulik 
wrote:
  >
  > > A widget setting an attribute on the application is bad
  >
  >
  > Where should I set it?
  >  I can't find a mainwindow class in kio
  
  
  Every application that opens a file dialog is supposed to do this in their 
own startup code (usually in `main()`).

REPOSITORY
  R241 KIO

BRANCH
  qt_scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, broulik, ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

[Alex Nemeth]

anemeth added a comment.


  In D12521#253761 , @broulik wrote:
  
  > A widget setting an attribute on the application is bad
  
  
  Where should I set it?
  I can't find a mainwindow class in kio

REPOSITORY
  R241 KIO

BRANCH
  qt_scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

[Nathaniel Graham]

ngraham added a comment.


  Only for the purpose of showing this dialog though, right?

REPOSITORY
  R241 KIO

BRANCH
  qt_scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

[Kai Uwe Broulik]

broulik added a comment.


  -1
  
  A widget setting an attribute on the application is bad

REPOSITORY
  R241 KIO

BRANCH
  qt_scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Well that was easy, lol.

REPOSITORY
  R241 KIO

BRANCH
  qt_scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

[Alex Nemeth]

anemeth retitled this revision from "KFileWidget fix hidpi icons" to 
"KFileWidget use hidpi icons".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12521

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns