D12593: KFileWidget: Save places panel width also after hiding panel

[Henrik Fehlauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0bcc7eadf5ca: KFileWidget: Save places panel width also 
after hiding panel (authored by rkflx).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12593?vs=33275=33447

REVISION DETAIL
  https://phabricator.kde.org/D12593

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: rkflx, #frameworks, ngraham
Cc: ngraham, elvisangelaccio, michaelh, bruns

D12593: KFileWidget: Save places panel width also after hiding panel

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice catch.

REPOSITORY
  R241 KIO

BRANCH
  fix-hidden-places-width-saving (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12593

To: rkflx, #frameworks, ngraham
Cc: ngraham, elvisangelaccio, michaelh, bruns

D12593: KFileWidget: Save places panel width also after hiding panel

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12593

To: rkflx, #frameworks
Cc: elvisangelaccio, michaelh, bruns

D12593: KFileWidget: Save places panel width also after hiding panel

[Henrik Fehlauer]

rkflx created this revision.
rkflx added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
rkflx requested review of this revision.

REVISION SUMMARY
  In certain situations the user-set width of the places panel was not
  remembered.
  
  As `placesViewWidth` is initialized by `configGroup.readEntry` and
  updated in reaction to user actions, it makes sense to also save the
  same variable back to the config file, instead of looking directly at
  the `placesViewSplitter`.
  
  Depends on D12592 
  
  Ref T8552 
  
  FIXED-IN: 5.46

TEST PLAN
  `kdialog --getopenfilename`, change width of places panel, hide places
  panel with [F9], close dialog by clicking on Cancel, reopen
  dialog, close dialog a second time, reopen dialog, press [F9] again
  and check that previously set width is restored.

REPOSITORY
  R241 KIO

BRANCH
  fix-hidden-places-width-saving (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12593

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: rkflx, #frameworks
Cc: michaelh, bruns