D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

ntninja added a comment.


  Thanks, I'll keep that in mind for next time.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[David Faure]

dfaure closed this revision.
dfaure added a comment.


  
https://commits.kde.org/frameworkintegration/4cc12a5ad1fa92f8b934f02ff2e401539ec9b9f7

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[David Faure]

dfaure added a comment.


  Ah, you need to specify that you don't have a developer account, otherwise 
the assumption is simply that you'll push the patch once approved.
  
  I'll land it now.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

ntninja added a comment.


  Since these changes have been approved and marked read-to-land for quite some 
time, could this please be done soon? Thank you!

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  We have done similar things in other frameworks, to indeed make it easier to 
reuse them in contexts where not all dependencies are wanted.
  See SONNET_USE_WIDGETS, KSYNTAXHIGHLIGHTING_USE_GUI, KCONFIG_USE_GUI, 
kxmlgui's FORCE_DISABLE_KGLOBALACCEL, ki18n's BUILD_WITH_QTSCRIPT, 
KACTIVITIES_LIBRARY_ONLY, KIOCORE_ONLY...
  
  Making KF5 frameworks reusable outside of the KDE community was and is still 
goal number 1 of the rearchitecture (compared to kdelibs4), so I'd say, yes, 
this change is good.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

tundracomp added a comment.


  The target application I'm building has only very minimal dependencies on Qt 
(just QtCore + QtWidgets + PyQt5) and no real dependencies on KDE. The 
application only has a size footprint of about 6MiB, the required Qt libraries 
use about 10MiB of space, the selected set of KDE integration libraries (a 
minimalist build of the KDE `plasmaintegration` package including dependencies) 
add another 10MiB. By contrast `org.kde.Platform` alone adds more than 150MiB 
in size requirements – this is not acceptable for an app that uses less than 
20% percent of its contents IMHO. You can take a look at the project here 
. I'm planning on making this 
available as a runtime extension for the FreeDesktop runtime so that other 
people can reuse it too.
  
  If you're not merging this I'll keep the patch on my side.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Aleix Pol Gonzalez]

apol added a comment.


  If you are building a flatpak, please use org.kde.Sdk.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

tundracomp added a comment.


  I build a Qt app with „just enough“ KDE-integration for the Flatpak sandbox 
where I have no use for this KPackage stuff. I know I could just include the 
install handlers in the build and drop them afterwards, but that would require 
a build KNS (and all of *its* dependencies) as well. IMHO „only build what you 
use“ is surpreme in this case.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Aleix Pol Gonzalez]

apol added a comment.


  Why would we want to make it optional?
  In fact, the only one that is mandatory is the KNS one.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

tundracomp added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Any review of this would be greatly apprechiated…

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

tundracomp created this revision.
tundracomp added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
tundracomp requested review of this revision.

REVISION SUMMARY
  Currently building the KPackage install handlers is mandatory when building 
the `frameworkintegration`. This package allows them to be disabled if they do 
not seem useful for the given target environment. Explicit Opt-In is required 
for this.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: tundracomp
Cc: #frameworks, michaelh, ngraham, bruns