D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria added a comment.


  Thanks.
  
  Sadly the commit went without the GIT_SILENT, sorry about that. I did:
   arc amend
   git commit -amend # to add the GIT_SILENT
   arc land
  I guess that the arc land called another arc amend.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D12867

To: maximilianocuria, #frameworks, alexmerry, kossebau, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D12867

To: maximilianocuria, #frameworks, alexmerry, kossebau, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D12867: Fix minor documentation typos

2018-05-14 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  Thanks.
  
  Please use the GIT_SILENT keyword for typo fixes.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  doc_typos (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12867

To: maximilianocuria, #frameworks, alexmerry, kossebau, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria added a comment.


  Please let me know if it's okay to land this kind of changes directly.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D12867

To: maximilianocuria, #frameworks, alexmerry, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D12867

To: maximilianocuria, #frameworks, alexmerry, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria created this revision.
maximilianocuria added reviewers: Frameworks, alexmerry, kossebau.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  These typos show up in the generated manpages.
  
  Please let me know if it's okay to land this kind of changes directly.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  doc_typos (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12867

AFFECTED FILES
  modules/ECMAddQch.cmake
  modules/ECMSetupVersion.cmake

To: maximilianocuria, #frameworks, alexmerry, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns