D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.
Closed by commit R249:918e304f057b: KF5I18NMacros: Dont install an empty 
dir when no po files exist (authored by heikobecker).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12905?vs=34222=35777

REVISION DETAIL
  https://phabricator.kde.org/D12905

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: heikobecker, ilic, ltoscano
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Luigi Toscano]

ltoscano accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic, ltoscano
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

heikobecker marked an inline comment as done.
heikobecker added a comment.


  Considering the feedback I'll probably merge this in a few days if no 
objections turn up in the meantime.

INLINE COMMENTS

> ltoscano wrote in KF5I18NMacros.cmake.in:138-139
> I guess that those two lines are the critical parts (the call to file), but 
> probably it's not bad to avoid processing other instructions too.

Yes. And that was my thought as well and reason to move the rest inside the if

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Luigi Toscano]

ltoscano added a comment.


  Looks fine by me, let's see if there are other comments.

INLINE COMMENTS

> KF5I18NMacros.cmake.in:138-139
>  
> -file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname})
> -install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION 
> ${destname})
> +file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname})
> +install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION 
> ${destname})
> +endif()

I guess that those two lines are the critical parts (the call to file), but 
probably it's not bad to avoid processing other instructions too.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Luigi Toscano]

ltoscano added a reviewer: ilic.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  I saw this happen with kdecoration from git since
  64d9f92f6a8708814f414dda0bb0d0e91c27235f 
. 
The directory passed in
  its ki18n_install call doesn't exist, resulting in an empty
  directory (LOCALE_INSTALL_DIR) getting installed, which at least
  some packaging systems don't like.

TEST PLAN
  Tested with kdecoration from git and tarballs where podir
  exists

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12905

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns