D13158: Fix i18n issues in Phabricator Plugin

2018-05-27 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> phabricatorplugin_config.qml:125
>  // use i18n().arg() to avoid showing the "%1" when inactive
> -text: i18n("Summary of the update to %1:").arg(updateDR)
> +text: updateDR != "unknown" && updateDR.length > 0 ? i18n("Summary 
> of the update t %1:").arg(updateDR) : i18n("Summary of the update")
>  enabled: updateOld.checked

Change to `i18n("Summary of the update t %1:", updateDR)`, without .arg().

REPOSITORY
  R495 Purpose Library

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D13158

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13158: Fix i18n issues in Phabricator Plugin

2018-05-27 Thread Nicolas Fella 
nicolasfella edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13158

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13158: Fix i18n issues in Phabricator Plugin

2018-05-27 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When the diffs combo box is empty i18n reports issues. This is a quick and 
dirty fix

REPOSITORY
  R495 Purpose Library

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D13158

AFFECTED FILES
  src/plugins/phabricator/phabricatorplugin_config.qml

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns