D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  In D13216#397326 , @smithjd wrote:
  
  > "Locking" the scheduler is simpler here than identifying that it "has gone 
idle". "Locking" only happens here for a small number of runnables (two) that 
can't run concurrently.
  
  
  If you don't understand the code, do not change it.
  
  This is not about avoiding to be scheduled, but missing the schedule signal.
  
  You are mixing a ton of different things here, clean it up!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  "Locking" the scheduler is simpler here than identifying that it "has gone 
idle". "Locking" only happens here for a small number of runnables (two) that 
can't run concurrently.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  STOP IT!
  You are reverting recent, required changes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 49977.
smithjd added a comment.


  - Re-write the file index scheduler. Combine content indexer suspend logic.
  - Update the balooctl tool with the changed suspend/resume behaviour.
  - Re-order and use IndexerState to prioritize the indexer thread pool.
  - Newline and tab fixes.
  - Prevent a scheduler race condition.
  - Separate runnableStateChanged into two functors.
  - Allow the first run indexer to complete before running any other runnables. 
Prevent the new file and unindexed file runnables from running at the same time.
  - Revert "Re-order and use IndexerState to prioritize the indexer thread 
pool."
  - Simplify locking the scheduler.
  - Adapt index cleaner to scheduler.
  - Rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=43623=49977

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 43623.
smithjd added a comment.


  - Re-write the file index scheduler. Combine content indexer suspend logic.
  - Update the balooctl tool with the changed suspend/resume behaviour.
  - Re-order and use IndexerState to prioritize the indexer thread pool.
  - Newline and tab fixes.
  - Prevent a scheduler race condition.
  - Separate runnableStateChanged into two functors.
  - Allow the first run indexer to complete before running any other runnables. 
Prevent the new file and unindexed file runnables from running at the same time.
  - Revert "Re-order and use IndexerState to prioritize the indexer thread 
pool."
  - Simplify locking the scheduler.
  - Adapt index cleaner to scheduler.
  
  Exporting the storage object is not part of this patchset.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=43355=43623

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files 
with check command..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 43355.
smithjd marked an inline comment as done.
smithjd added a comment.


  - Re-write the file index scheduler. Combine content indexer suspend logic.
  - Update the balooctl tool with the changed suspend/resume behaviour.
  - Re-order and use IndexerState to prioritize the indexer thread pool.
  - Newline and tab fixes.
  - Prevent a scheduler race condition.
  - Separate runnableStateChanged into two functors.
  - Allow the first run indexer to complete before running any other runnables. 
Prevent the new file and unindexed file runnables from running at the same time.
  - Revert "Re-order and use IndexerState to prioritize the indexer thread 
pool."
  - Simplify locking the scheduler.
  - Adapt index cleaner to scheduler.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=40393=43355

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 40393.
smithjd added a comment.


  - Revert "Re-order and use IndexerState to prioritize the indexer thread 
pool."
  
  Avoid setting a priority on the runnables.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=40343=40393

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> smithjd wrote in fileindexscheduler.cpp:117
> This starts a QRunnable at a negative priority (in this case the negative 
> integer value for NewFiles) and then calls runnableStarted(NewFiles) with the 
> enum of the started runnable.

Yeah, I suspected that - fugly as hell!

If you need different priorities, make it explicit.

> smithjd wrote in fileindexscheduler.h:92
> There is no cast from int to enum anywhere here. There is a cast fron enum to 
> int, to a negative integer used to set the QRunnable thread priority.

Sigh ...
Make each state a bit in the flags. No bits set -> Idle, one or multiple bits 
set -> Suspended, or runners active.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added inline comments.

INLINE COMMENTS

> bruns wrote in fileindexscheduler.cpp:117
> Whats that supposed to do (I have an idea, but thats ugly ...)

This starts a QRunnable at a negative priority (in this case the negative 
integer value for NewFiles) and then calls runnableStarted(NewFiles) with the 
enum of the started runnable.

> bruns wrote in fileindexscheduler.h:92
> Make this a QFlags ...

There is no cast from int to enum anywhere here. There is a cast fron enum to 
int, to a negative integer used to set the QRunnable thread priority.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  ... and thats the problem - this change does 3 different things. Make each 
one a separate revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Split this into independent changes.
  Add add comprehensive description to the summary - a bug reference is 
insufficient.

INLINE COMMENTS

> fileindexscheduler.cpp:98
> -Q_EMIT stateChanged(m_indexerState);
> -return;
>  }

You sneak in a unmentioned and significant change - you allow to run several 
indexer tasks to run in parallel!

> fileindexscheduler.cpp:117
>  
> -m_threadPool.start(runnable);
> -m_modifiedFiles.clear();
> -m_indexerState = ModifiedFiles;
> -Q_EMIT stateChanged(m_indexerState);
> -return;
> +m_threadPool.start(runnable, -(int)NewFiles);
> +runnableStarted(NewFiles);

Whats that supposed to do (I have an idea, but thats ugly ...)

> fileindexscheduler.h:92
>  
> +QList m_indexerStates;
> +

Make this a QFlags ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 40343.
smithjd added a comment.


  - Re-write the file index scheduler. Combine content indexer suspend logic.
  - Update the balooctl tool with the changed suspend/resume behaviour.
  - Re-order and use IndexerState to prioritize the indexer thread pool.
  - Newline and tab fixes.
  - Prevent a scheduler race condition.
  - Separate runnableStateChanged into two functors.
  - Allow the first run indexer to complete before running any other runnables. 
Prevent the new file and unindexed file runnables from running at the same time.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=36701=40343

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexerstate.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files 
with check command..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 36701.
smithjd added a comment.


  re-word commits.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=36417=36701

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files 
with check command..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd removed a dependent revision: D13424: Run a file changed check when the 
file watches are updated..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 36417.
smithjd added a comment.


  - Re-write the the file index scheduler.
  - Update the balooctl tool with the changed suspend/resume behaviour.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=35810=36417

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  This still contains two unrelated changes.  Can you please submit each one 
individually?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a dependent revision: D13425: Quit the file indexer when closing..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a dependent revision: D13424: On config change, halt the file 
indexer and run a file changed check when the file watches are updated..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 35810.
smithjd added a comment.


  - Re-write the the file index scheduler.
  - Update the balooctl tool with the changed suspend/resume behaviour.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=35730=35810

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[Nathaniel Graham]

ngraham added a comment.


  For future reference, the preferred method to implement a multi-commit patch 
chain is with multiple Phabricator revisions. See 
https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  In D13216#275582 , @bruns wrote:
  
  > In D13216#275581 , @smithjd 
wrote:
  >
  > > According to the arc documentation, a --merge commit should land the 
commits separately.
  >
  >
  > Still, **I** can not see the individual commits.
  
  
  That appears to be a Phabricator limitation.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  In D13216#275581 , @smithjd wrote:
  
  > According to the arc documentation, a --merge commit should land the 
commits separately.
  
  
  Still, **I** can not see the individual commits.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  According to the arc documentation, a --merge commit should land the commits 
separately.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  In D13216#275546 , @smithjd wrote:
  
  > In D13216#275538 , @bruns wrote:
  >
  > > @smithjd You have probaly become another victim of phabricator/arc.  Your 
commits have been squashed by arc ...
  > >  If you wan't your commits to stay separated, you have to do a `git 
checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next 
commit, `arc diff HEAD^1`, and so on.
  >
  >
  > Commits are squashed on arc land anyway, but the branch can be manually 
pushed keeping the separate patches. If you mean separated into different 
reviews, I don't think it's unclear why there are small changes to code related 
to the scheduler, or why it might be advantageous to separate these into 
different reviews.
  >
  > Is there any practical reason why a simple arc land wouldn't suffice here?
  
  
  Because pushing independent stuff in a single commit just sucks for the 
reviewer, and it sucks if you want to understand the git history later.
  
  You are changing 5 different things in your patches. I can not see which 
changed source line relates to which change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  In D13216#275538 , @bruns wrote:
  
  > @smithjd You have probaly become another victim of phabricator/arc.  Your 
commits have been squashed by arc ...
  >  If you wan't your commits to stay separated, you have to do a `git 
checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next 
commit, `arc diff HEAD^1`, and so on.
  
  
  Commits are squashed on arc land anyway, but the branch can be manually 
pushed keeping the separate patches. If you mean separated into different 
reviews, I don't think it's unclear why there are small changes to code related 
to the scheduler, or why it might be advantageous to separate these into 
different reviews.
  
  Is there any practical reason why a simple arc land wouldn't suffice here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  @smithjd You have probaly become another victim of phabricator/arc.  Your 
commits have been squashed by arc ...
  If you wan't your commits to stay separated, you have to do a `git checkout` 
of the first commit, do a `arc diff HEAD^1`, checkout the next commit, `arc 
diff HEAD^1`, and so on.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 35730.
smithjd added a comment.


  Split-up scheduler overhaul patchset.
  
  - The power state signal should only be emitted when the power state changes.
  - Re-write the the file index scheduler.
  - Update the balooctl tool with the changed suspend/resume behaviour.
  - Make use of the scheduler halt method.
  - Check for unindexed files when folder watches are installed.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=35199=35730

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/mainhub.cpp
  src/file/powerstatemonitor.cpp
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  If I understand your summary correctly, your patch changes different things. 
While these are clearly related, can you try to separate the changes?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Matthieu Gallien]

mgallien added a comment.


  Sounds good to me. I will try to do a proper review as soon as I can. Sorry 
for the delay.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a reviewer: bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a reviewer: mgallien.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files 
with check command..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 35199.
smithjd added a comment.


  - Minor simplification + fix: call checkUnindexedFiles when folder watches 
are installed instead of scheduleIndexing which can't check for changes in 
indexable files.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=35195=35199

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/mainhub.cpp
  src/file/powerstatemonitor.cpp
  src/tools/balooctl/main.cpp

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd retitled this revision from "Overhaul the file index scheduler. Allow 
all operations except the content indexer to work when suspended. Allow 
manually resuming file content indexing while on battery. balooctl stop now 
stops file indexing." to "Overhaul the file index scheduler.".
smithjd edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now sto

[James Smith]

smithjd created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
smithjd requested review of this revision.

REVISION SUMMARY
  BUG: 353559
  BUG: 378597

REPOSITORY
  R293 Baloo

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/mainhub.cpp
  src/file/powerstatemonitor.cpp
  src/tools/balooctl/main.cpp

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns