D13482: Implement support for the Voice and Call interfaces
This revision was automatically updated to reflect the committed changes. Closed by commit R281:7b9d2badd52a: Implement support for the Voice and Call interfaces (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13482?vs=36011&id=36266 REVISION DETAIL https://phabricator.kde.org/D13482 AFFECTED FILES src/CMakeLists.txt src/call.cpp src/call.h src/call_p.h src/dbus/CMakeLists.txt src/dbus/callinterface.cpp src/dbus/callinterface.h src/dbus/dbus.h src/dbus/fakedbus.h src/dbus/introspection/org.freedesktop.ModemManager1.Call.xml src/dbus/introspection/org.freedesktop.ModemManager1.Modem.Voice.xml src/dbus/voiceinterface.cpp src/dbus/voiceinterface.h src/generictypes.h src/modemvoice.cpp src/modemvoice.h src/modemvoice_p.h To: aleksanderm, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13482: Implement support for the Voice and Call interfaces
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me. Having a test for this would be nice, but looks that not all interfaces are unit tested. REPOSITORY R281 ModemManagerQt BRANCH master-fixes REVISION DETAIL https://phabricator.kde.org/D13482 To: aleksanderm, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13482: Implement support for the Voice and Call interfaces
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. aleksanderm added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksanderm requested review of this revision. REVISION SUMMARY The Voice and Call interfaces were introduced in ModemManager 1.6, and they provide access to voice-related operations (e.g. start a call, hangup a call, get notified of incoming calls..). This commit adds bindings for those 2 interfaces in ModemManagerQt. REPOSITORY R281 ModemManagerQt BRANCH master-fixes REVISION DETAIL https://phabricator.kde.org/D13482 AFFECTED FILES src/CMakeLists.txt src/call.cpp src/call.h src/call_p.h src/dbus/CMakeLists.txt src/dbus/callinterface.cpp src/dbus/callinterface.h src/dbus/dbus.h src/dbus/fakedbus.h src/dbus/introspection/org.freedesktop.ModemManager1.Call.xml src/dbus/introspection/org.freedesktop.ModemManager1.Modem.Voice.xml src/dbus/voiceinterface.cpp src/dbus/voiceinterface.h src/generictypes.h src/modemvoice.cpp src/modemvoice.h src/modemvoice_p.h To: aleksanderm, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns