D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Aleix Pol Gonzalez]

apol added a comment.


  In D13541#578027 , @bcooksley 
wrote:
  
  > This broke the build on FreeBSD - Please see 
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/
  
  
  fixed

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: bcooksley, davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Ben Cooksley]

bcooksley added a comment.


  This broke the build on FreeBSD - Please see 
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: bcooksley, davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:9f868681b26e: Port solid from Qt5::Widgets to Qt5::Gui 
(authored by graesslin, committed by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13541?vs=36167=71569#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13541?vs=36167=71569

REVISION DETAIL
  https://phabricator.kde.org/D13541

AFFECTED FILES
  CMakeLists.txt
  src/solid/CMakeLists.txt
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[David Edmundson]

davidedmundson added a comment.


  do it

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Aleix Pol Gonzalez]

apol added a comment.


  I see this patch still works and applies. I'd say landing it would still make 
sense. If nobody disagrees I'll do so in a week.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Dominik Haumann]

dhaumann added a comment.


  @graesslin pong? One year passed.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Dominik Haumann]

dhaumann added a comment.


  @graesslin ping

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  const auto would be even nicer, if possible. Besides that, lgtm.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Martin Flöser]

graesslin created this revision.
graesslin added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  The only usage of widgets was to get the active window. Incorrectly this
  was done through QWidget which would fail for any application using just
  QtGui (e.g. QtQuick).
  
  As QGuiApplication also provides access to the focus window we can use
  QtGui API instead. As a note: the whole thing is X11 specific as a
  window ID is passed to another process, which cannot work on Wayland.
  It's possible to get it work on Wayland, but that would require:
  
  - changes to the dbus protocol
  - add a dependency to KWayland
  - or extend QtWayland to generate the required code

TEST PLAN
  Compiles

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

AFFECTED FILES
  CMakeLists.txt
  src/solid/CMakeLists.txt
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: graesslin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns