D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files). If there was no more error it was because I saw them in the conflicts. Currently I put `find_package (ECM 5.31.0 ...` (instead of 5.49.0) and delete `include (ECMAddQch)` which I think should be in `if (BUILD_QCH)`. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
This revision was automatically updated to reflect the committed changes. Closed by commit R216:ee8969a8437f: fix reference files empty lines have different attributes after the fixes to… (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14603?vs=40004=40006#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14603?vs=40004=40006 REVISION DETAIL https://phabricator.kde.org/D14603 AFFECTED FILES autotests/reference/highlight.css.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref autotests/reference/test.css.ref To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. The unit tests fail du to errors like: - - + + Could it be your local version wasn't up to date? I will regen the references, I see only empty lines change their attributes. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
This revision was automatically updated to reflect the committed changes. Closed by commit R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14603?vs=39067=40004#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14603?vs=39067=40004 REVISION DETAIL https://phabricator.kde.org/D14603 AFFECTED FILES autotests/folding/highlight.scss.fold autotests/html/highlight.css.html autotests/html/highlight.scss.html autotests/html/review128925-1.scss.html autotests/html/review128925-2.scss.html autotests/input/highlight.scss autotests/reference/highlight.css.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.scss.ref autotests/reference/review128925-2.css.ref autotests/reference/review128925-2.scss.ref autotests/reference/test.css.ref data/syntax/css.xml data/syntax/scss.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. Ok, i'm doing this in the week. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I would be for merging this and later replacing with the include list stuff. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. Yes, I can start tomorrow. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
cullmann added a reviewer: vkrause. cullmann added a comment. Hi, the idea "I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with ## as for IncludeRules." sounds reasonable. Do you want to give it a try to implement that? Volker, what do you think about that? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with `##` as for IncludeRules. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 AFFECTED FILES autotests/folding/highlight.scss.fold autotests/html/highlight.css.html autotests/html/highlight.scss.html autotests/html/review128925-1.scss.html autotests/html/review128925-2.scss.html autotests/input/highlight.scss autotests/reference/highlight.css.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.scss.ref autotests/reference/review128925-2.css.ref autotests/reference/review128925-2.scss.ref autotests/reference/test.css.ref data/syntax/css.xml data/syntax/scss.xml To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars
