D15091: Compile python bindings with the same sip flags used by PyQt
This revision was automatically updated to reflect the committed changes. Closed by commit R240:05bd97492704: Compile python bindings with the same sip flags used by PyQt (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=42116&id=42625 REVISION DETAIL https://phabricator.kde.org/D15091 AFFECTED FILES find-modules/FindPythonModuleGeneration.cmake find-modules/run-sip.py To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15091: Compile python bindings with the same sip flags used by PyQt
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Confirmed to work with PyQt 5.10.1 and Qt 5.11.1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15091: Compile python bindings with the same sip flags used by PyQt
arojas updated this revision to Diff 42116. arojas added a comment. Rebase REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40570&id=42116 REVISION DETAIL https://phabricator.kde.org/D15091 AFFECTED FILES find-modules/FindPythonModuleGeneration.cmake find-modules/run-sip.py To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15091: Compile python bindings with the same sip flags used by PyQt
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15091: Compile python bindings with the same sip flags used by PyQt
bruns added a comment. Can you rebase, please? And upload the patch with `arc diff`, to have the full context available. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15091: Compile python bindings with the same sip flags used by PyQt
arojas updated this revision to Diff 40570. arojas retitled this revision from "Compile python bindings with the same sipname used by PyQt" to "Compile python bindings with the same sip flags used by PyQt". arojas edited the summary of this revision. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40479&id=40570 REVISION DETAIL https://phabricator.kde.org/D15091 AFFECTED FILES find-modules/FindPythonModuleGeneration.cmake find-modules/run-sip.py To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns